detecting pushbutton

[shir]

hi.. i need help with this program. this is a program to turn 'ON' and 'OFF' 1 LED using 2 push buttons.
the underline statement suppose to wait for button press. but it is alway false even i have press the button. is there any one who can tell me what's wrong with the statement.. thank alot..

#include <p18f4620.h>
 
#pragma config OSC = HS                              
#pragma config WDT = OFF
#pragma config LVP = OFF
 
#define btn_on     PORTBbits.RB4
#define btn_off     PORTBbits.RB5
#define led           PORTAbits.RA0
 
void on(void);
void off(void);
void Delay(void);
 
void main(void)
{
TRISA = 0;                             //set Port A(LED) as output
PORTAbits.RA0 = 0;               //reset LED
Rpt:
    if (btn_on || btn_off)               //wait for btn press
    {   
              if (btn_on == 1)         //btn on pressed 
              {
                      Delay();            //This is the real trick, Debounce the input!!
                      if (!btn_on)        //btn on still pressed?
                          goto Rpt;      //No
                      on();
              }
               if (btn_off == 1)        //btn off pressed
              {
                      Delay();           //This is the real trick, Debounce the input!!
                      if (!btn_off)       //btn off still pressed?
                          goto Rpt;    //No
                      off();
              }
}
goto Rpt;
} //end main
 
    void on(void)
    {
Rpt_on:
       while(btn_on);            //wait for btn(RB4) released 
        Delay();                    //debounce
        if (btn_on)                 //btn on still released?
            goto Rpt_on;        //No
       PORTAbits.RA0 = 0x0F;       //on LED
    } //end on
 
    void off(void)
    {
Rpt_off:
       while(btn_off);            //wait for btn(RB5) released 
        Delay();                   //debounce
        if (btn_off)                //btn off still released?
            goto Rpt_off;        //No
       PORTAbits.RA0 = 0x00;       //off LED
    } //end off
 
void Delay(void)
{
int i;
for(i=0; i<2048; i++);
}
 

[arunmib]

Did you check the status of btn_on and btn_off before the if loop?

[shir]

Did you check the status of btn_on and btn_off before the if loop?

what do i need to check for..?

[arunmib]

what do i need to check for..?

Your point was the if loop fails whatever be the states of btn_on and btn_off right..So just thought if both of them are '0's then the loop will fail...

Or did i get something completely wrong, if so enlighten me...

[shir]

Your point was the if loop fails whatever be the states of btn_on and btn_off right..So just thought if both of them are '0's then the loop will fail...

Or did i get something completely wrong, if so enlighten me...

if both '0's become false then it will loop agian and again untill 1 button is pressed. this part is right, but the problem is when i press 1 button it still become false. it did not execute the next statement.

[HEMANTHPG]

hi,

give some debounce delay before you check the push button.



debounce delay : its just some 100ms delay


just write one 100ms delay function


call this function before you check the key status






try this ,you will get

[arunmib]

Ok I will put the question this way, how certain are you that when you press BUTTON 1 it's corresponding bit in the register is set. Like did you try using the bit value in the register directly in the code or did you probe the signal level using an oscilloscope etc..etc...Because, if my understanding is correct we are conversing based on the assumption that there is no problem in the signal levels or no hardware problems....

Again if I am missing something, then enlighten me....

[shir]

Ok I will put the question this way, how certain are you that when you press BUTTON 1 it's corresponding bit in the register is set.

that i not sure. because when i press nothing happen.

Like did you try using the bit value in the register directly in the code or did you probe the signal level using an oscilloscope etc..etc...

i dont really understand. what should i check for..??

[shir]

do i need to set PORT B as input..?

[arunmib]

that i not sure. because when i press nothing happen.


i dont really understand. what should i check for..??

In simple terms, when you press a button there will be some voltage level variation (for eg : either from 0V to 5V or from 5V to 0V) and this variation will be the one acting as input to your PortB register. If you do not find this variation, then the corresponding 'bit' in the PortB register will be not set (either to '1' or to '0'). This means whatever you do with your code, there will be not output.

The reason I am asking you to do this is, since your code seem fine the problem could be on the hardware side. That is you might not be getting any input in port B. check with your electronics engineer...