Pass a struct array to a function

[Hypnotik]

Hey everyone. I need to pass a struct array to a function, and calculate the average of one of the members of the struct. My code is posted below.
With the current code, it takes the last value of the TotalPay variable and divides it by 25. I need to add the entire TotalPay column, and then divide by 25.

There is some info commented out, which I have used for my own troubleshooting.

Thanks,
J

#include <fstream>
#include <iostream>
#include <iomanip>
using namespace std;
struct Person
{
    double IDNumber,HoursWorked,PayRate,TotalPay[26];
    char FirstName[10],LastName[10];
};
void Output (Person Person_Info[])
{
    cout<<"LastName"<<"    "<<setw(10)<<"IDNumber"<<"  "<<setw(10)<<"TotalPay"<<endl;
    for (int i=0;i<25;++i)
    {
        cout<<setw(6)<<Person_Info[i].LastName<<setw(14)<<Person_Info[i].IDNumber<<setw(12)<<setprecision(5)<<showpoint<<Person_Info[i].TotalPay[0]<<endl;
    }
}
double Average (Person Person_Info[])
{
    double sum=0.0,avg=0.0;
    int j=0;
 
    for (j=0;j<25;++j)
    {
        sum=sum+Person_Info[j].TotalPay[j];
    }
    avg=sum/25;
    cout<<avg<<endl;
    return (avg);
}
int main ()
{
    int i=0;
    Person Person_Info[26]={0};
    ifstream ifp;
    ofstream ofp;
    ifp.open("C:\\Documents and Settings\\Jeff Young\\My Documents\\Visual Studio Projects\\Lab 3 External Files and Structs\\Lab2.in");
    ofp.open("C:\\Pay.out");
//    cout<<"FirstName"<<" "<<"LastName"<<" "<<"IDNumber"<<" "<<"HoursWorked"<<" "<<"PayRate"<<" "<<"TotalPay"<<endl;
//    cout<<"LastName"<<"     "<<"IDNumber"<<"     "<<"TotalPay"<<endl;
    ofp<<"LastName"<<"     "<<"IDNumber"<<"     "<<"TotalPay"<<endl;
    while (ifp>>Person_Info[i].FirstName>>Person_Info[i].LastName>>Person_Info[i].IDNumber>>Person_Info[i].HoursWorked>>Person_Info[i].PayRate)
    {
        if (Person_Info[i].HoursWorked<=40&&Person_Info[i].HoursWorked>=0)                    
        {
            Person_Info[i].TotalPay[i]=(Person_Info[i].HoursWorked*Person_Info[i].PayRate);                
        }
        else if (Person_Info[i].HoursWorked>40)                        
        {
            Person_Info[i].TotalPay[i]=(40*Person_Info[i].PayRate)+(Person_Info[i].HoursWorked-40)*(Person_Info[i].PayRate*1.5);
        }
    //    ofp<<Person_Info[i].LastName<<"     "<<Person_Info[i].IDNumber<<"     "<<Person_Info[i].TotalPay[i]<<endl;
    //    cout<<Person_Info[i].FirstName<<"     "<<Person_Info[i].LastName<<"     "<<Person_Info[i].IDNumber<<"    "<<Person_Info[i].HoursWorked<<"     "<<Person_Info[i].PayRate<<"     "<<Person_Info[i].TotalPay[i]<<endl;
    //    Average(Person_Info);
    }
    Average(Person_Info);
//    Output (Person_Info);
 
}
 

[Savage]

Here is your problem..

double Average (Person Person_Info[])
{
    double sum=0.0,avg=0.0;
    int j=0;
 
    for (j=0;j<25;++j)
    {
        sum=sum+Person_Info[j].TotalPay[j];//problem is here
    }
    avg=sum/25;
    cout<<avg<<endl;
    return (avg);
}

This function will take from every Person_Info just one TotalPay.

You will need to add another loop inside.

for(j=0;j<25;j++)
{
     for(i=0;i<25;i++) sum+=Person_Info[j].TotalPay[i];//added another loop
}

Savage

[Hypnotik]

That still returns the last value of the TotalPay divided by 25. So the same answer as without that loop.

Thanks,
J

[Savage]

int i=0;
 
while (ifp>>Person_Info[i].FirstName>>Person_Info[i].LastName>>Person_Info[i].IDNumber>>Person_Info[i].HoursWorked>>Person_Info[i].PayRate)
    {
        if (Person_Info[i].HoursWorked<=40&&Person_Info 
        [i].HoursWorked>=0)          
        {
            Person_Info[i].TotalPay[i]=(Person_Info[i].HoursWorked*Person_Info
            [i].PayRate);    
        }
        else if (Person_Info[i].HoursWorked>40)      
        {
            Person_Info[i].TotalPay[i]=(40*Person_Info[i].PayRate)+(Person_Info
            [i].HoursWorked-40)*(Person_Info[i].PayRate*1.5);
        }
       //  ofp<<Person_Info[i].LastName<<"     "<<Person_Info
       [i].IDNumber<<"     "<<Person_Info[i].TotalPay[i]<<endl;
       //  cout<<Person_Info[i].FirstName<<"     "<<Person_Info
       [i].LastName<<"     "<<Person_Info[i].IDNumber<<"    "<<Person_Info
       [i].HoursWorked<<"     "<<Person_Info[i].PayRate<<"     "<<Person_Info
       [i].TotalPay[i]<<endl;
    //  Average(Person_Info);
    }

I don't see that u are increasing counter i here.If u don't increase him data will be owerwriten and only last TotalPay will remain.Also whay is Totalpay array,when every time u are writing over secound person.



Savage

[Hypnotik]

Awesome. That was it, I needed to increment i. Thanks a ton, I've been staring at this program all day.


Thanks again,

J

[Hypnotik]

found the answer to this question too.


thanks again.
j

[Savage]

Awesome. That was it, I needed to increment i. Thanks a ton, I've been staring at this program all day.


Thanks again,

J

I'm more than happy to help you..

Savage

[Hypnotik]

Well I'd like to ask a quick question if it's ok. When I had the code:

 
while (ifp>>Person_Info[i].FirstName>>Person_Info[i].LastName>>Person_Info[i].IDNumber>>Person_Info[i].HoursWorked>>Person_Info[i].PayRate)
    {
        if (Person_Info[i].HoursWorked<=40&&Person_Info[i].HoursWorked>=0)                    
        {
            Person_Info[i].TotalPay[i]=(Person_Info[i].HoursWorked*Person_Info[i].PayRate);                
        }
        else if (Person_Info[i].HoursWorked>40)                        
        {
            Person_Info[i].TotalPay[i]=(40*Person_Info[i].PayRate)+(Person_Info[i].HoursWorked-40)*(Person_Info[i].PayRate*1.5);
        }
        ofp<<Person_Info[i].LastName<<"     "<<Person_Info[i].IDNumber<<"     "<<Person_Info[i].TotalPay[i]<<endl;
        cout<<Person_Info[i].FirstName<<"     "<<Person_Info[i].LastName<<"     "<<Person_Info[i].IDNumber<<"    "<<Person_Info[i].HoursWorked<<"     "<<Person_Info[i].PayRate<<"     "<<Person_Info[i].TotalPay[i]<<endl;
 

I didn't need to increment i because it was in the while loop???

This is just for my understanding.

Thanks,
J

[Savage]

No,you don't need to worry about counter incrementation only in for loop(look at for loop syntax),in do-while and while you must increase it manualy..

Savage