help for concatenation of string and object.

[Sivakumar Kotamraju]

Hi,
this is the code to print s.

main() {
sample s1(10,20,30);
char *s;
s="Hello"+s1;
}
 
 friend char * operator +(char *s,sample &b) {
        char *s1;
        s1 = new char[50];
        char *s2;
        s2 = new char[10];
        strcpy(s1,s);
        strcat(s1,"Width");
        sprintf(s2,"%g",b.width);
        strcat(s1,s2);
        strcat(s1,"Height");
        sprintf(s2,"%g",b.height);
        strcat(s1,s2);
        strcat(s1,"depth");
        sprintf(s2,"%g",b.depth);
        strcat(s1,s2);
        delete [] s2;
 
        return s1;
        delete []s1;
    }
 

Could anybody help me for optimization?

[AdrianH]

Hi,
this is the code to print s.

main() {
sample s1(10,20,30);
char *s;
s="Hello"+s1;
}
 
 friend char * operator +(char *s,sample &b) {
        char *s1;
        s1 = new char[50];
        char *s2;
        s2 = new char[10];
        strcpy(s1,s);
        strcat(s1,"Width");
        sprintf(s2,"%g",b.width);
        strcat(s1,s2);
        strcat(s1,"Height");
        sprintf(s2,"%g",b.height);
        strcat(s1,s2);
        strcat(s1,"depth");
        sprintf(s2,"%g",b.depth);
        strcat(s1,s2);
        delete [] s2;
 
        return s1;
        delete []s1;
    }
 

Could anybody help me for optimization?

Optimisation? How can you optimise something that doesn't work? The friend function is inside of a class? I'm pretty sure that friend injection is a deprecated feature in C++. If not, then what is it a friend of?

Other than that, it looks like quite a mess. What are you attempting to do, and what problems are you encountering?


Adrian

[weaknessforcats]

Yes, and may I ask why you are not using a string and a strignstream object. All this works has been done for you. Why re-invent the wheel?

stringstream str;
 str << " Hello" << 10 << 20 << 30;
 
string result;
str >> result;
 

[AdrianH]

Yes, and may I ask why you are not using a string and a strignstream object. All this works has been done for you. Why re-invent the wheel?

I assumed it was part of the assignment.


Adrian

[Sivakumar Kotamraju]

Optimisation? How can you optimise something that doesn't work? The friend function is inside of a class? I'm pretty sure that friend injection is a deprecated feature in C++. If not, then what is it a friend of?

Other than that, it looks like quite a mess. What are you attempting to do, and what problems are you encountering?


Adrian

I used friend function because i need to make the statement char*s="Hello"+s1;
work. thats why i overloaded + using friend functions because the parameters iam passing are different.

I also overloaded << to output the object s1. My aim is to see how string class is implemented.and to test the overloading concepts etc..

[Sivakumar Kotamraju]

Yes, and may I ask why you are not using a string and a strignstream object. All this works has been done for you. Why re-invent the wheel?

stringstream str;
 str << " Hello" << 10 << 20 << 30;
 
string result;
str >> result;
 

I want to see how string class is implemented internally. I implemented using string class.In the code above you are taking primitive int type,but my aim is to see for objects.

[AdrianH]

I used friend function because i need to make the statement char*s="Hello"+s1;
work. thats why i overloaded + using friend functions because the parameters iam passing are different.

I also overloaded << to output the object s1. My aim is to see how string class is implemented.and to test the overloading concepts etc..

Yes, but what I am saying is that you cannot declare a friend outside of a class and you’re not supposed to declare a friend with its body inside of one (well if I understand friend injection correctly, your case could work under the new standard, but you will start getting into trouble when you start doing this using templated classes so be careful, see this article for more info).


Adrian

[weaknessforcats]

I want to see how string class is implemented internally. I implemented using string class.In the code above you are taking primitive int type,but my aim is to see for objects.

Why?

Just write an operator << for your classes and you are done.

[AdrianH]

Why?

Just write an operator << for your classes and you are done.

Yes, and by doing it with ostream as your left hand side (first) parameter, it would work for stringstream too since it inheirits from ostream.


Adrian