Comparing Arrays

[flyaway888]

Hi, I need to write a code that compares two arrays (draw and entry) and see if there are any matching numbers in them. I have tried a few different things and I don't understand why this doesn't work. Here is my code

int matches (int draw[], int entry[])
{
     int noofmatches = 0;
     for(int i=0;i<MAXSIZE;i++)
     {
         for(int j=0;j<MAXSIZE;j++)
         {
             if(draw[i]==entry[j])
              noofmatches++;   
         }
 
     }
     return noofmatches;
}

Any idea's about what is wrong with it?
Thanks

[AdrianH]

Hi, I need to write a code that compares two arrays (draw and entry) and see if there are any matching numbers in them. I have tried a few different things and I don't understand why this doesn't work. Here is my code

int matches (int draw[], int entry[])
{
     int noofmatches = 0;
     for(int i=0;i<MAXSIZE;i++)
     {
         for(int j=0;j<MAXSIZE;j++)
         {
             if(draw[i]==entry[j])
              noofmatches++;   
         }
 
     }
     return noofmatches;
}

Any idea's about what is wrong with it?
Thanks

Nothing, it work fine. It counts the number of elements in draw that are also in entry. What were you expecting?

BTW, this is not exactly safe to do. You have to be absolutely sure that you are passing an arrays that has only MAXSIZE or more elements in it.

If you are happy with just MAXSIZE elements in them, try using the following signature:

int matches (int (&draw)[MAXSIZE], int (&entry)[MAXSIZE])

Otherwise, I'd use something like a vector.

Adrian

[flyaway888]

Oh really, it isn't working for me. Maybe it's my output and input...
maxsize is fine as it is always going to be the same size and i declared it as a constant. This is the in/output....

cout << "Please enter the six numbers of the Draw: " << endl;
    for (int i=0; i<MAXSIZE; i++)
    {
       cin >> draw[MAXSIZE];
    }
    cout << "Please enter the six numbers of your entry: " << endl;
    for (int i=0; i<MAXSIZE; i++)
    {
       cin >> entry[MAXSIZE];
    }
 
      cout << matches(draw, entry) << endl;                         
 

Is there something wrong with this?

[AdrianH]

Oh really, it isn't working for me. Maybe it's my output and input...
maxsize is fine as it is always going to be the same size and i declared it as a constant. This is the in/output....

cout << "Please enter the six numbers of the Draw: " << endl;
    for (int i=0; i<MAXSIZE; i++)
    {
       cin >> draw[MAXSIZE];
    }
    cout << "Please enter the six numbers of your entry: " << endl;
    for (int i=0; i<MAXSIZE; i++)
    {
       cin >> entry[MAXSIZE];
    }
 
      cout << matches(draw, entry) << endl;                         
 

Is there something wrong with this?

Yes, what element are you putting your input into?


Adrian

[scruggsy]

Oh really, it isn't working for me. Maybe it's my output and input...

It could be your test input.
If either the first or second batch of numbers contains duplicate elements, your noOfMatches is going to be higher than you expect.
If that doesn't help, try to be define "isn't working" more specifically.

EDIT: Oops, Adrian spotted the more serious problem. :) But you still have an issue with non-unique elements.

[flyaway888]

I'm not quite sure what you mean by element but I am putting 6 numbers into each array. So six into entry[] and six into draw[].

[AdrianH]

I'm not quite sure what you mean by element but I am putting 6 numbers into each array. So six into entry[] and six into draw[].

Look at line 4. What index are you using? Same goes for line 9.


Adrian

[scruggsy]

I'm not quite sure what you mean by element but I am putting 6 numbers into each array. So six into entry[] and six into draw[].

The 6 numbers make up the 6 elements of each array.
The problem with your input-reading code is here:

for (int i=0; i<MAXSIZE; i++)
    {
       cin >> draw[MAXSIZE];
    }
 

What you want to do is store one number in each element (from 0 to MAXSIZE - 1) of your array.
What you're actually doing is storing each input into draw[MAXSIZE], so each successive input overwrites the previous one, and they are all written into memory outside of your array.
Replace cin >> draw[MAXSIZE] with cin >> draw[i].

[flyaway888]

Thanks for that, that does make sense but it still doesn't seem to be working. I keep getting zero for the number of matches. So here is the code all together....

#include <iostream>
using namespace std;
 
const int MAXSIZE = 6;
int matches (int draw[], int entry[]);
 
int main()
{
    int draw[MAXSIZE];
    int entry[MAXSIZE];
 
    cout << "Please enter the six numbers of the Draw: " << endl;
    for (int i=0; i<MAXSIZE; i++)
    {
       cin >> draw[i];
    }
    cout << "Please enter the six numbers of your entry: " << endl;
    for (int i=0; i<MAXSIZE; i++)
    {
       cin >> entry[i];
    }
 
      cout << matches(draw, entry) << endl;                         
 
 
    system("pause");
    return 0;
}// end of main
 
 
 
int matches (int draw[], int entry[])
{
     int noofmatches = 0;
     for(int i=0;i<MAXSIZE;i++)
     {
         for(int j=i+1;j<MAXSIZE;j++)
         {
             if(draw[i]==entry[j]&& i!=j)
             noofmatches++;
 
         }
 
     }
     return noofmatches;
}

Can you see anything that is wrong?
Thanks again

[AdrianH]

Thanks for that, that does make sense but it still doesn't seem to be working. I keep getting zero for the number of matches. So here is the code all together....

#include <iostream>
using namespace std;
 
const int MAXSIZE = 6;
int matches (int draw[], int entry[]);
 
int main()
{
    int draw[MAXSIZE];
    int entry[MAXSIZE];
 
    cout << "Please enter the six numbers of the Draw: " << endl;
    for (int i=0; i<MAXSIZE; i++)
    {
       cin >> draw[i];
    }
    cout << "Please enter the six numbers of your entry: " << endl;
    for (int i=0; i<MAXSIZE; i++)
    {
       cin >> entry[i];
    }
 
      cout << matches(draw, entry) << endl;                         
 
 
    system("pause");
    return 0;
}// end of main
 
 
 
int matches (int draw[], int entry[])
{
     int noofmatches = 0;
     for(int i=0;i<MAXSIZE;i++)
     {
         for(int j=i+1;j<MAXSIZE;j++)
         {
             if(draw[i]==entry[j]&& i!=j)
             noofmatches++;
 
         }
 
     }
     return noofmatches;
}

Can you see anything that is wrong?
Thanks again

Try using your original matches() function.

EDIT: Also don't use system("pause"), it is not standard, use cin.ignore(). It will wait for you to press enter.


Adrian

[flyaway888]

Ok it finally works!!! Thankyou sooo much.
I just changes it that many times I didn't realise I hadn't tried changing it back!
Thanks again.

[flyaway888]

Hi again,
Now I need to output the numbers that match and nothing i've tried works. This is what i've got so far...

int numbers (int draw[], int entry[])
{
    int samenumbers = 0;
    for(int i=0; i<MAXSIZE; i++)
    {
        for(int j=0; j<MAXSIZE; j++)
        {
            if(draw[i]==entry[j])
            samenumbers = draw[i];
            break;
 
        }
 
    }
    return samenumbers;
 
}

Any ideas?
Thanks

[AdrianH]

Hi again,
Now I need to output the numbers that match and nothing i've tried works. This is what i've got so far...

int numbers (int draw[], int entry[])
{
    int samenumbers = 0;
    for(int i=0; i<MAXSIZE; i++)
    {
        for(int j=0; j<MAXSIZE; j++)
        {
            if(draw[i]==entry[j])
            samenumbers = draw[i];
            break;
 
        }
 
    }
    return samenumbers;
 
}

Any ideas?
Thanks

Please restate, your question is too vague.


Adrian