Calling for a char from a different class.

[Firepony]

Main.cpp:

#include <iostream>
#include "Rooms.h"
using namespace std;
 
void main()
{
 
    Rooms town;
    town.setName((char)"town");
    cout << town.getName();
}

Rooms.cpp:

#include <iostream>
#include "Rooms.h"
 
Rooms::Rooms()
{
}
 
Rooms::~Rooms()
{
}
 
void Rooms::setName(char input)
{
    name =(char) input;
}
 
char Rooms::getName()
{
    return (char)"name";
}

Rooms.h:

#ifndef ROOMS_H
#define ROOMS_H
 
class Rooms
{
public:
    Rooms();
    ~Rooms();
    void setName(char input);
    char getName();
    char name;
};
 
#endif

am i too tired to find a problem or am i just coding it worng? i run it and i get a funny symbol not name like i thought i should.

[gpraghuram]

HI,
I think problem is with the function

char Rooms::getName()
{
    return (char)"name";
}
 

First u are returning wrongle,instead of returning the variable name u are returning the string "name" typecasting it to char.
chage the code like this

char Rooms::getName()
{
    return name;
}
 

Raghuram

[svlsr2000]

Main.cpp:

#include <iostream>
#include "Rooms.h"
using namespace std;
 
void main()
{
 
    Rooms town;
    town.setName((char)"town");
    cout << town.getName();
}

Rooms.cpp:

#include <iostream>
#include "Rooms.h"
 
Rooms::Rooms()
{
}
 
Rooms::~Rooms()
{
}
 
void Rooms::setName(char input)
{
    name =(char) input;
}
 
char Rooms::getName()
{
    return (char)"name";
}

Rooms.h:

#ifndef ROOMS_H
#define ROOMS_H
 
class Rooms
{
public:
    Rooms();
    ~Rooms();
    void setName(char input);
    char getName();
    char name;
};
 
#endif

am i too tired to find a problem or am i just coding it worng? i run it and i get a funny symbol not name like i thought i should.

"Name" would give a pointer to a character and your trying to cast it to character. Change your setname prototype to setName(char *Input) and use town.setName("town");. Try to find out the difference between two. :)

[svlsr2000]

"Name" would give a pointer to a character and your trying to cast it to character. Change your setname prototype to setName(char *Input) and use town.setName("town");. Try to find out the difference between two. :)

Sorry i was bit late. :)

[DhananjayNangare]

code removed as per posting guidelines

Hope this helps

char* Rooms::getName()
{
    return name;
}

[gpraghuram]

Hi,
You got it right.

Thanks
Raghuram

[Firepony]

thanks guys that helped.

[weaknessforcats]

Not a good choice:

char* Rooms::getName()
{
    return name;
}
 

You have broken encapsulation by returning a pointer to your name. That means someone outside the class can use the pointer to change the name without needing to use the class member functions. Worse, if the name is a literal, the program will crash if an attempt is made to change the name.

You should return a const char* from this method. Ans since the method itself does not change meember data, the method shoulc be const:

const char* Rooms::getName() const
{
    return name;
}