By using this site, you agree to our updated Privacy Policy and our Terms of Use. Manage your Cookies Settings.
440,581 Members | 2,007 Online
Bytes IT Community
+ Ask a Question
Need help? Post your question and get tips & solutions from a community of 440,581 IT Pros & Developers. It's quick & easy.

passing command line argument to array

P: n/a
Good evening,

I would like to pass the size of an array from the commandline.

int main(int argc, int *argv[]) {
....
max=*argv[1];

int list[max];
....

This does not work, because the size should be a constant.

How can I work around this? I tried const or static, nothing works.

Thank you,

Ernst
May 4 '07 #1
Share this Question
Share on Google+
6 Replies


P: n/a
In article <f1*************@news.t-online.com>,
virgincita schmidtmann <do*******@t-online.dewrote:
>I would like to pass the size of an array from the commandline.
>int main(int argc, int *argv[]) {
...
max=*argv[1];
int list[max];
...
>This does not work, because the size should be a constant.
>How can I work around this? I tried const or static, nothing works.
What you propose is not legal in C89, but is (if I understand
correctly) legal in C99 "variable length arrays".

In C89, what you need to do is malloc() the space you need and
store the returned pointer. int *list = malloc(max * sizeof int)
--
Okay, buzzwords only. Two syllables, tops. -- Laurie Anderson
May 4 '07 #2

P: n/a
On Fri, 4 May 2007 22:33:25 +0200, "virgincita schmidtmann"
<do*******@t-online.dewrote:
>Good evening,

I would like to pass the size of an array from the commandline.

int main(int argc, int *argv[]) {
...
max=*argv[1];

int list[max];
Even under a C99 compiler, this will not do what you want. *argv[1]
is, by definition, a character. If it happened to be the character
'2' and you run this on an ASCII system, it will define an array of 50
int. And if the command line argument was the value "75", you would
not allocate enough space. On an EBCDIC system, '2' would produce an
array 242 int.
>...

This does not work, because the size should be a constant.
This is true in C89 but C99 does allow variable length arrays.
>
How can I work around this? I tried const or static, nothing works.
Since you don't have a C99 compiler, the solution is in two parts:

First convert the data argv1 points at to an integer. strtol
would be the method of choice because it provides a convenient method
for error checking.

Second, allocate memory for the desired array and store the
address of this memory in a pointer. malloc is a good choice here.
You can then refer to elements of the array using normal array
notation such as ptr[i].
Remove del for email
May 5 '07 #3

P: n/a
virgincita schmidtmann wrote:
Good evening,

I would like to pass the size of an array from the commandline.

int main(int argc, int *argv[]) {
...
max=*argv[1];

int list[max];
...

This does not work, because the size should be a constant.

How can I work around this? I tried const or static, nothing works.

Thank you,

Ernst

Create a dynamic array with malloc?

int *list;
int max;
max = atoi(argv[1]);
list = malloc(max * sizeof *list);

The above is not a program, it is only a clue. The task is yours.

--
Joe Wright
"Everything should be made as simple as possible, but not simpler."
--- Albert Einstein ---
May 5 '07 #4

P: n/a
Thank you all!

1. Mhmm. If I allocate memory to a pointer, can I use this pointer
without defining an array?

I think, array is a pointer to the first element of the array. Memory
size from malloc and list[] is the same. Does the compiler have to
know the size of an element in the array?

2. In the past I took integer arguments from the commandline by
defining argv[] as int. Well, there is a problem with argv[0], because
it is definitely the name of the program. But if I don't use it?

3. I am not really sure, if I need a variable length array.

However, I will try it.

Best regards,

Ernst

Barry Schwarz wrote:
On Fri, 4 May 2007 22:33:25 +0200, "virgincita schmidtmann"
<do*******@t-online.dewrote:

>>Good evening,

I would like to pass the size of an array from the commandline.

int main(int argc, int *argv[]) {
...
max=*argv[1];

int list[max];


Even under a C99 compiler, this will not do what you want. *argv[1]
is, by definition, a character. If it happened to be the character
'2' and you run this on an ASCII system, it will define an array of 50
int. And if the command line argument was the value "75", you would
not allocate enough space. On an EBCDIC system, '2' would produce an
array 242 int.

>>...

This does not work, because the size should be a constant.


This is true in C89 but C99 does allow variable length arrays.

>>How can I work around this? I tried const or static, nothing works.


Since you don't have a C99 compiler, the solution is in two parts:

First convert the data argv1 points at to an integer. strtol
would be the method of choice because it provides a convenient method
for error checking.

Second, allocate memory for the desired array and store the
address of this memory in a pointer. malloc is a good choice here.
You can then refer to elements of the array using normal array
notation such as ptr[i].
Remove del for email
May 5 '07 #5

P: n/a
Please don't top-post. Put what you're replying below what you cite
from the previous post.

Ernst Schmidtmann <do*******@ulcus.owl.dewrote:
1. Mhmm. If I allocate memory to a pointer, can I use this pointer
without defining an array?
You don't allocate "momory to a pointer", you allocate memory and
assign the address you receive from malloc() to a pointer. And
yes, of course, you can then use the pointer to access the
memory you allocated in an array-like fashion using the pointer.
I think, array is a pointer to the first element of the array.
Definitely not. An array is an array, not a pointer. Only when
the compiler finds an array in a place where a value is required
the array is replaced by a pointer to the first element of the
array. This happens e.g. when an array is used as a function
argument since in C all function arguments are passed by value
but an array isn't a value. And thus in this situation it gets
converted to a value, which is the address of its first element.
Memory
size from malloc and list[] is the same. Does the compiler have to
know the size of an element in the array?
If you create an array the compiler alreays knows the size
of the elements from the type of the array. But if you call
malloc() you need to tell malloc() exactly how much memory
you need, e.g. for enough memory to store 75 ints you do

int *ip;
ip = malloc( 75 * sizeof *ip );

where 'sizeof *ip' is the number of bytes required for the
type 'ip' points to, in this case the number of bytes needed
to store an int.
2. In the past I took integer arguments from the commandline by
defining argv[] as int. Well, there is a problem with argv[0], because
it is definitely the name of the program. But if I don't use it?
Then you did something wrong. The elements of argv are all
pointers to strings, pointing to strings with the command
line arguments (except argv[0] and the very last element,
which is always NULL). So if your first command line argu-
ment was 2 then argv[1] points to the string "2". And if
you now do

int max = *argv[1];

then you assign to 'max' the numerical value of the character
'2' and _not_ the integer value 2. And if the command line
argument had been 75 the argv[1] would point to the string
"75" and with the above assignment you would assign the
numerical value of the character '7' to 'max' and neither
the integer value 7 nor 75. You first have to convert the
string you got to an integer, using e.g. strtol().
3. I am not really sure, if I need a variable length array.
If you need memory with a size that only can be determined at
run-time and not already when the program gets compiled then
you either need a variable length array (which requires a com-
piler that implements at least this part of C99) or you must
obtain the memory via malloc().

Regards, Jens
--
\ Jens Thoms Toerring ___ jt@toerring.de
\__________________________ http://toerring.de
May 5 '07 #6

P: n/a
On May 5, 8:33 am, "virgincita schmidtmann" <doc.er...@t-online.de>
wrote:
>
int main(int argc, int *argv[]) {
This is an error. Not sure why nobody else noticed it;
perhaps they subconsciously filitered it out !

The second argument to main must have 'char' where
you current have 'int'. Who knows what your compiler
is doing with that code. Probably not what you expect!

May 6 '07 #7

This discussion thread is closed

Replies have been disabled for this discussion.