Incompatible types in assignment

[canteyn]

/*
     File Name:  lab7.c
     Author:  Nick Cantey
     Description:  This application reads a binary file of employee information
                   sorts by last name and prints the sorted information to  
                   to the screen in a table.
*/
 
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
 
typedef struct
{
     char lname[25];
     char fname[25];
     int age;
     double salary;
} employee_t;
 
void sort(employee_t*, int);
 
int main ()
{
 
FILE* in;
employee_t employees[10];
int i, n, j, k;
double temp;
 
 
in = fopen("lab7.in", "rb");
i=0;  
while( fread(&employees[i], sizeof(employee_t), 1, in ) == 1)
{
i++;
}
fclose(in);
n=i;
printf("%d\n", n);
printf("%s %s\n", employees[0].lname, employees[0].fname);
printf("%s\n", employees[1].lname);
 
 
 
 
sort(employees, n);
printf("%s %s\n", employees[0].lname, employees[0].fname);
 
}
 
/* Function Name:  sort
   Parameters:  &employees(address to array) and int(number of elements in array
   Description:  This function sorts employees in ascending order by last name
*/
 
void sort(employee_t* e, int n)
{
int temp, min, current, j;
 
for(current=0; current<n-1; current++)
   {
   min=current;
      for(j=current; j<n; j++)
      {
      if(strcmp(e[j].lname, e[min].lname) < 0) 
        temp=e[min];
        e[min]=e[current];
        e[current]=temp;
      }
   } 
}
 

Here is my question/problem. In my "sort function" I am having issues with the "temp=e[min];" line and "e[current]=temp" line. The error I get when compiling this program is "Incompatible types in assignment" for those two lines. If anyone could help me with this, that would be great. Thank you in advance.

[JosAH]

Here is my question/problem. In my "sort function" I am having issues with the "temp=e[min];" line and "e[current]=temp" line. The error I get when compiling this program is "Incompatible types in assignment" for those two lines. If anyone could help me with this, that would be great. Thank you in advance.

'e' is a pointer to an employee_t so e[min] has type employee_t; temp has int
type, hence the error diagnostic. Better make temp an employee_t too.

kind regards,

Jos

[canteyn]

thanks that helped, however I am now receiving weird characters on from the "printf()" statements I am using to check to make sure everything is getting sorted correctly. If you wouldn't mind compiling the code and seeing if you might be able to catch the mistakes, that would be fantastic.

/*
     File Name:  lab7.c
     Author:  Nick Cantey
     Description:  This application reads a binary file of employee information
                   sorts by last name and prints the sorted information to  
                   to the screen in a table.
*/
 
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
 
typedef struct
{
     char lname[25];
     char fname[25];
     int age;
     double salary;
} employee_t;
 
void sort(employee_t*, int);
 
int main ()
{
 
FILE* in;
employee_t employees[10];
int i, n, j, k;
double temp;
 
 
in = fopen("lab7.in", "rb");
i=0;  
while( fread(&employees[i], sizeof(employee_t), 1, in ) == 1)
{
i++;
}
fclose(in);
n=i;
printf("%d\n", n);
printf("%s %s\n", employees[0].lname, employees[0].fname);
printf("%s\n", employees[1].lname);
 
 
 
 
sort(employees, n);
printf("%s %s\n", employees[0].lname, employees[0].fname);
 
}
 
/* Function Name:  sort
   Parameters:  &employees(address to array) and int(number of elements in array
   Description:  This function sorts employees in ascending order by last name
*/
 
void sort(employee_t* e, int n)
{
int min, current, j;
employee_t temp;
 
for(current=0; current<n-1; current++)
   {
   min=current;
      for(j=current; j<n; j++)
      {
      if(strcmp(e[j].lname, e[min].lname) < 0) 
        e[min]=temp;
        e[min]=e[current];
        e[current]=temp;
      }
   }
printf("%s %s \n", e[0].lname, e[1].lname);
}
 
 

Here is what the out put looks like:
2
Smith John
Cantey
ÿ4 Cantey
ÿ4


those y's and 4's should not be there at all, which leads me to believe that what would be the lname string has now been replaced with something, please take a look at my sort and see if it is working correctly.

[JosAH]

If you *don't* sort those records does the output show correctly then? If so,
it was the sorting that corrupted the data, if not you incorrectly read the
data from the file or the file already contained corrupted data.

kind regards,

Jos

[canteyn]

If you *don't* sort those records does the output show correctly then? If so,
it was the sorting that corrupted the data, if not you incorrectly read the
data from the file or the file already contained corrupted data.

kind regards,

Jos

Yes before I sort the records the data is shown correctly, so it is in my sorting that the data gets corrupted, but I don't have the slightest idea how to correct that. Any suggestions?

[weaknessforcats]

Shouldn't this code in your sort be looked at carefully?

e[min]=temp;
e[min]=e[current];