checking is a 2d array of numbers are in order

[silversnake]

hi I'm trying to write a function that check through a 2d array of numbers and check if they are in order or not
e.g 1 2 3
4 5 6 the function will return TURE

3 2 4
6 1 5 will return FALSE

 int checkPuzzle(int puzzle[][COLS])
{
   for (row=0; row<ROWS; row++)
   {
      for (col=0; col<COLS; col++)
      {
        if (puzzle[row][col] > puzzle[row][col+1]);
        {
          return TRUE
        }       
        else
        {
          return FALSE;
        }
      }
 
  }
 

can anyone help ?
thanks

[sicarie]

hi I'm trying to write a function that check through a 2d array of numbers and check if they are in order or not
e.g 1 2 3
4 5 6 the function will return TURE

3 2 4
6 1 5 will return FALSE


int checkPuzzle(int puzzle[][COLS])
{
for (row=0; row<ROWS; row++)
{
for (col=0; col<COLS; col++)
{
if (puzzle[row][col] > puzzle[row][col+1]);
{
return TRUE
}
else
{
return FALSE;
}
}

}


can anyone help ?
thanks

Please use [ code] and [ /code] tags around your code, it helps greatly with readability.

What do you need help with? You posted code, is there something with that that doesn't work? Is it returning an error?

[silversnake]

I need to return true only when the whole array is checked. it steps through the whole array checking if the number aheand of it is larger and will keep on going unitl the end. once a false condition is detected false will be returned

[silversnake]

problem is is returning true everytime the one step , i need to return true only when the array has been stepped through

[sicarie]

I need to return true only when the whole array is checked. it steps through the whole array checking if the number aheand of it is larger and will keep on going unitl the end. once a false condition is detected false will be returned

Okay, so you're having trouble with this line:

if (puzzle[row][col] > puzzle[row][col+1])

What's happening is that because you have 'puzzle[row][col]' those are being resolved to actual values, for instance, if puzzle [0][0] holds the value of 5, 5 is being returned, and if puzzle [0][1] holds 10, 10 is being returned for that, so the compiler sees it as:

if ( 5 > 10 )

I would recommend using the ROWS and row variables directly (not in the array). Then you'll get the actual element number that resides there.