sprintf style printing in C++

[2b|!2b==?]

I am not making much progress porting some old C code to C++ ...

I am porting the lines below, which prints an ISO8601 date string:

char buff[16] ;
memset(buff, '\0',16);
sprintf(buff,"%02d:%02d:%02d", hours, minutes, seconds) ;

to :

std::ostringstream os ;
os << std::setprecision(2) << hours << ":" << std::setprecision(2) <<
minutes << std::setprecision(2) << seconds ;
The C++ code compiles ok, but I am getting the wrong formatting (i.e.
for old time C programmers) - its as if I'm using the format string
"%2d:%2d%2d"

Can anyone spot where I'm going wrong ?

[Victor Bazarov]

2b|!2b==? wrote:

I am not making much progress porting some old C code to C++ ...

I am porting the lines below, which prints an ISO8601 date string:

char buff[16] ;
memset(buff, '\0',16);
sprintf(buff,"%02d:%02d:%02d", hours, minutes, seconds) ;

to :

std::ostringstream os ;
os << std::setprecision(2) << hours << ":" << std::setprecision(2) <<
minutes << std::setprecision(2) << seconds ;
The C++ code compiles ok, but I am getting the wrong formatting (i.e.
for old time C programmers) - its as if I'm using the format string
"%2d:%2d%2d"

Can anyone spot where I'm going wrong ?

You need to add setfill('0'), I believe.

V
--
Please remove capital 'A's when replying by e-mail
I do not respond to top-posted replies, please don't ask

[Sylvester Hesp]

"2b|!2b==?" <ro**@your.box.comwrote in message
news:Dc******************************@bt.com...

>I am not making much progress porting some old C code to C++ ...

I am porting the lines below, which prints an ISO8601 date string:

char buff[16] ;
memset(buff, '\0',16);
sprintf(buff,"%02d:%02d:%02d", hours, minutes, seconds) ;

to :

std::ostringstream os ;
os << std::setprecision(2) << hours << ":" << std::setprecision(2) <<
minutes << std::setprecision(2) << seconds ;
The C++ code compiles ok, but I am getting the wrong formatting (i.e. for
old time C programmers) - its as if I'm using the format string
"%2d:%2d%2d"

Can anyone spot where I'm going wrong ?

You should use width instead of precision, and use a '0' fill character (see
std::setw and std::setfill in <iomanip>)

- Sylvester Hesp

[David Harmon]

On Mon, 23 Apr 2007 15:51:44 +0100 in comp.lang.c++, "2b|!2b==?"
<ro**@your.box.comwrote,

> os << std::setprecision(2) << hours << ":" << std::setprecision(2) <<
minutes << std::setprecision(2) << seconds ;

You need setfill('0') and width(2).
setprecision is for floating point.

[James Kanze]

On Apr 23, 5:23 pm, "Sylvester Hesp" <[e-mail]:

"2b|!2b==?" <[e-mail] in message
news:Dc******************************@bt.com...

I am not making much progress porting some old C code to C++ ...

I am porting the lines below, which prints an ISO8601 date string:

char buff[16] ;
memset(buff, '\0',16);
sprintf(buff,"%02d:%02d:%02d", hours, minutes, seconds) ;

to :

std::ostringstream os ;
os << std::setprecision(2) << hours << ":" << std::setprecision(2) <<
minutes << std::setprecision(2) << seconds ;

The C++ code compiles ok, but I am getting the wrong formatting (i.e. for
old time C programmers) - its as if I'm using the format string
"%2d:%2d%2d"

Can anyone spot where I'm going wrong ?

You should use width instead of precision, and use a '0' fill
character (see std::setw and std::setfill in <iomanip>)

Just for the record, in the more general case (outputting to a
file), you should save the previous fill character, and restore
it when you're through. (Obviously, it doesn't matter here,
since the stream is a local variable which will go immediately
out of scope when he's through.)

More generally, for time, I would not use ostringstream, but the
old C standby: strftime. It avoids most of the problems
inherent with sprintf, and it allows for localization when
appropriate.

--
James Kanze (GABI Software) email:ja*********@gmail.com
Conseils en informatique orientée objet/
Beratung in objektorientierter Datenverarbeitung
9 place Sémard, 78210 St.-Cyr-l'École, France, [phone]

[Marcus Kwok]

James Kanze <ja*********@gmail.comwrote:

>"2b|!2b==?" <[e-mail] in message
news:Dc******************************@bt.com...

I am porting the lines below, which prints an ISO8601 date string:

[snip]

More generally, for time, I would not use ostringstream, but the
old C standby: strftime. It avoids most of the problems
inherent with sprintf, and it allows for localization when
appropriate.

I would agree with James Kanze's advice to use strftime(). However, I
do not think localization is relevant in this particular instance since
the OP said he wanted to print an ISO8601 string, which AFAIU is
designed to eliminate localization issues :)

See:
http://www.cl.cam.ac.uk/~mgk25/iso-time.html

where he gives conversion specifiers for strftime() to output in
ISO8601 format.

--
Marcus Kwok
Replace 'invalid' with 'net' to reply