Help - Segmentation Fault

[ahab]

Hi,

when I execute this code I receive a segmentation fault. I know that somethig's happening when I try to erase an element from the string list but I don't know a solution
The line which cause the erros is marked with a comment.
Any help is appreciated.

Thanks

Platform, OS, Version
i386, Linux, 2.6.5-7.191-bigsmp

#include <iostream>
#include <sstream>
#include <fstream>
#include <cstring>
#include <list>
 
using namespace std;
 
class ReadNC
{
public:
    ReadNC();
    ~ReadNC();
    bool addNC(string);  // add a string in the string list
    bool delNCEnt(string);  // delete a string from the string list
    list<string> ncColl;
};
 
ReadNC::ReadNC(){}
ReadNC::~ReadNC(){}
 
bool ReadNC::addNC(string toAdd)
{
    bool rVal = false;
    ncColl.push_back(toAdd);
    return rVal;
}
 
bool ReadNC::delNCEnt(string toDel)
{
    bool rVal=false;
    list<string>::iterator it;
    for (it=ncColl.begin(); it!=ncColl.end(); ++it){
            string toComp=*it;
        if (toComp.compare(toDel) == 0){
            ncColl.erase(it);   //           ERROR!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
            rVal=true;
        }        
    }
    return rVal;
}
int main()
{
        string a;
    ReadNC nc;
    cout<<nc.addNC("ABCD")<<endl;
    cout<<nc.delNCEnt("ABCD")<<endl;
    return 0;
}
 

[Ganon11]

Whenever you use the list's erace method, the iterator you are using becomes invalid. You should either use the iterator's erase method (or remove(), or some such similar function) or find an alternate way to delete.