How to compare two different arrays.

[bing3121]

Good-day,

I am doing a class project in C++ and am having trouble with one of my menu items. I am trying to inplement a test for the user to try in a fraction class/ porgram. I have filled one array with the answers to the test and then am filling the second array with answers form the user. The third array is a bool array and is being filled by comparing the first two arrays and recording correct/ incorrect anwers. In turn, I am counting the correct answers. All this is done within three functions.

When the choice (S) is made from the menu - the test is displayed and the user is prompted to enter his answers. When the return key is hit - a continuous loop occurs.

I am very new to programing and to be honest not very good at it.

Help is greatly appreciated.

Here is the main program.

[Savage]

Good-day,

I am doing a class project in C++ and am having trouble with one of my menu items. I am trying to inplement a test for the user to try in a fraction class/ porgram. I have filled one array with the answers to the test and then am filling the second array with answers form the user. The third array is a bool array and is being filled by comparing the first two arrays and recording correct/ incorrect anwers. In turn, I am counting the correct answers. All this is done within three functions.

When the choice (S) is made from the menu - the test is displayed and the user is prompted to enter his answers. When the return key is hit - a continuous loop occurs.

I am very new to programing and to be honest not very good at it.

Help is greatly appreciated.

Hi,there.I don't understand your problem.Can you be a little more specific?

(Are there any errors ,are you stucked,where are you stucked...)

And please don't post full code because it will be snniped by a moderator.Post only troubleshooting part

Savage

[sicarie]

bing3121-
Please read the Posting Guidelines in the FAQ tab at the top of this page. You have not asked any sort of a question, please repost a specific question with only the relevant portions of code (but thank you for using code tags!).

[bing3121]

Hi,there.I don't understand your problem.Can you be a little more specific?

(Are there any errors ,are you stucked,where are you stucked...)

And please don't post full code because it will be snniped by a moderator.Post only troubleshooting part

Savage

Point taken about the code.

The question I am asking, is from the functions I am displaying, am I accomplishing what I said I want to do in the initial posting. That is I am trying to fill an array from an input file and having the user fill in the other array with the answers he/she has calculated on their own. Then I am trying to compare the array with the input file answers with the arry filled with the user answers to return a score. From the code posted it is not working. I am using Visual C++ 6.0 to build. Everything compiles and the program will run fine - until the choice (S) is selected. The test questions will display and and the user is prompted for an answer. As soon as the user enters an answer a continual loop occurs.

void get_scored_test()
{
    ifstream input ("fractest.in");
    string next;
 
    if (input.is_open())
    {
        while (!input.eof())
        {
            getline(input, next);
            cout<<next<< endl;
        }
        input.close();
    }
    else
        cout<<"Sorry Test is not available"<< endl;
}
 
void fill_scored_test()
{
    ifstream test_input; 
    int test_answers[5];
    int answers[5];
 
    test_input.open("testanswers.in");
    if(test_input.fail())
    {
        cout<<"Test Answers not available" <<endl;
        exit(1);
    }
 
    for(int i=0;i<5;i++)
    {
        test_input>>test_answers[i];
    }
 
    test_input.close();
 
    for(int x = 0; x<5;++x)
    {
        cout<<"Enter your answers one at a time. " <<endl;
        cin>>answers[x];
    }
}
 
int mark_scored_test()
{
    bool check[5];
    int count=0;
    int test_answers[5];
    int answers[5];
 
    for(int z = 0; z<5;z++)
    {
        if(test_answers[z]==answers[z])
        {
            check[z]=true;
            ++count;
        }
        else
            check[z]=false;
    }
    return(count);
 
    cout<< "your score for the test is ==> " << count << endl;
}

[bing3121]

bing3121-
Please read the Posting Guidelines in the FAQ tab at the top of this page. You have not asked any sort of a question, please repost a specific question with only the relevant portions of code (but thank you for using code tags!).

Understood, new to this

[sicarie]

void get_scored_test()
{
    ifstream input ("fractest.in");
    string next;
 
    if (input.is_open())
    {
        while (!input.eof())
        {
            getline(input, next);
            cout<<next<< endl;
        }
        input.close();
    }
    else
        cout<<"Sorry Test is not available"<< endl;
}
 
void fill_scored_test()
{
    ifstream test_input; 
    int test_answers[5];
    int answers[5];
 
    test_input.open("testanswers.in");
    if(test_input.fail())
    {
        cout<<"Test Answers not available" <<endl;
        exit(1);
    }
 
    for(int i=0;i<5;i++)
    {
        test_input>>test_answers[i];
    }
 
    test_input.close();
 
    for(int x = 0; x<5;++x)
    {
        cout<<"Enter your answers one at a time. " <<endl;
        cin>>answers[x];
    }
}
 
int mark_scored_test()
{
    bool check[5];
    int count=0;
    int test_answers[5];
    int answers[5];
 
    for(int z = 0; z<5;z++)
    {
        if(test_answers[z]==answers[z])
        {
            check[z]=true;
            ++count;
        }
        else
            check[z]=false;
    }
    return(count);
 
    cout<< "your score for the test is ==> " << count << endl;
}

How are your variables declared? You have a lot of local variables that aren't returned...

[bing3121]

How are your variables declared? You have a lot of local variables that aren't returned...

Hello,

Everything is local to the fucntion it is in. The only return is count - how the user scored on the test.

Maybe arrays are not the way to go. Do you have any suggestions?

I am using a fraction class and have been trying to modify mu usage file.

Here is a copy of the menu. You can see how the functions are called.

choice = toupper(get_user_command());
 
    do
    {
        switch (choice)
        {
            case 'T': fraction_tutorial();
                      break;
            case 'M': print_menu();
                      break;
            case '-': get_fraction(f1);
                      get_fraction(f2);
                      f3=f1-f2;
                      cout << "\n" << f1 << "-" << f2 << " = " << f3 << endl;
                      break;
            case '+': get_fraction(f1);
                      get_fraction(f2);
                      f3=f1+f2;
                      cout << "\n" << f1 << "+" << f2 << " = " << f3 << endl;
                      break;
            case '*': get_fraction(f1);
                      get_fraction(f2);
                      f3=f1*f2;
                      cout << "\n" << f1 << "*" << f2 << " = " << f3 << endl;
                      break;
            case '/': get_fraction(f1);
                      get_fraction(f2);
                      f3=f1/f2;
                      cout << "\n" << f1 << "/" << f2 << " = " << f3 << endl;
                      break;
            case 'R': get_fraction(f1);
                      f1.reduce();
                      cout << "The reduced form is:" << f1 << endl;    
                      break;
            case 'D': get_fraction(f1);
                      f1.decimal_value();
                      cout<<"the Decimal value is ==> " << f1 << endl; 
                      break;
            case 'P': get_practice_test();
                      break;
            case 'S': get_scored_test();
                      fill_scored_test();
                      mark_scored_test();
                      break;
            case 'Q': cout <<"Math only leads to greatness or a big headache and sometimes both" << endl;
                      cout <<"If you must quit then enter W" << endl;
                      break;
            default: cout << "The" << choice << "is not a valid choice" << endl;
        }
 
        choice = toupper(get_user_command());
    }while(choice != 'W');