Open File/Print Output File with in a loop

[undshan]

I am writing a code that needs to open a file, create an output file, run through my function, prints the results to the output file, and closes them within a loop. Here is my code:

#include <stdlib.h>
#include <stdio.h>
#include <math.h>
#include <string.h>
 
#include "util.h"
 
//Main Loop
int main()
{
 
   int   i, flag;
   int   num_files;
   int   len_str;
   char  *idir = "/home/smurphy/data/20060117/";
   char  **file_names;
   char  *fullfn;
   char  *output;
 
   //Define variables needed from the metar data:
  char station[5];             //Station identifier
   char weather[3];
 
   int snow_value;
 
   /*  Get list of files to be processed. */
   flag = get_dir_list(idir, &num_files, &file_names);
 
   for(i=0; i<num_files; ++i){
 
      printf("file name #%d = %s\n", i, file_names[i]);
      len_str = strlen(idir) + strlen(file_names[i]) + 1;
      fullfn = calloc(len_str, sizeof(char));
 
      strcat(fullfn, idir);
      strcat(fullfn, file_names[i]);
      printf("fullfn = %s\n", fullfn);
 
      sprintf(output, "output%d.dat", i);
 
      FILE *input_stream;
      FILE *output_stream;
 
      output_stream = fopen(output, "w");
 
      if (output == NULL){
         printf("I could not open your output file.\n");
      }
 
      //Opens input file
      input_stream = fopen(fullfn,"r");
 
 
      //Loop reads in input file and detemines at which stations snow is occuring at.
 
      while(fscanf(fullfn, "%s\t%s\n", station, weather) >= 1){
 
         if (strcmp(weather, "S") == 0){
            snow_value = 2;
            fprintf(output, "Stat: %s SigWx: %s SnoVal: %i\n", station, weather, snow_value);
         }
         else if (strcmp(weather, "S-") == 0){
            snow_value = 1;
            fprintf(output, "Stat: %s SigWx: %s SnoVal: %i\n", station, weather, snow_value);
         }
 
         else if (strcmp(weather, "+S") == 0){
            snow_value = 3;
            fprintf(output, "Stat: %s SigWx: %s SnoVal: %i\n", station, weather, snow_value);
         }
 
         else{
            snow_value = 0;
            fprintf(output, "Stat: %s  SigWx: None SnoVal: %i\n", station, snow_value);
         }
      }
 
   //Closes files
   //fclose(fullfn);
   //fclose(output);
 
   free(fullfn);
   free (output);
   }
 
}
 

I am getting incompatible pointer types for arg 1 for my fscanf, fprintf. Can anyone help me out? I have never worked with opening/closing files within a loop, any suggestions?

[mweitz]

This program worked in college where was made. Check how it is

:: Code removed per FAQ::

MWZ

[sicarie]

This program worked in college where was made. Check how it is

:: Code removed per FAQ::

MWZ

mweitz-

Please read our Posting Guidelines and abide by them. We ask that you not 1) post complete code or 2) give out code.

The OP has posted code, and it will help them more to show them where their program is not working, as they understand that better than what was posted, and they will learn more by fixing it.

[Clfy]

Well, this looks like homework but I am in a good mood.

The errors you were getting:

a.c:56: warning: passing arg 1 of `fscanf' from incompatible pointer type
a.c:60: warning: passing arg 1 of `fprintf' from incompatible pointer type
a.c:64: warning: passing arg 1 of `fprintf' from incompatible pointer type
a.c:69: warning: passing arg 1 of `fprintf' from incompatible pointer type
a.c:74: warning: passing arg 1 of `fprintf' from incompatible pointer type

I will give you a hint:

You declared fullfn and output as

char *fullfn;
char *output;

notice in your errors above the function that is being complained about...fscanf and fprintf. Hmmm...what does the "f" in fscanf and fprintf represent...Perhaps fullfn and output should be a different type of variable.