473,327 Members | 2,065 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,327 software developers and data experts.

C++ Code

5
What is wrong with this code?
Expand|Select|Wrap|Line Numbers
  1. int *array (int n)
  2. {
  3.     return new int(n);
  4. }
  5.  
  6. int main()
  7. {
  8.     int *p = array(10);
  9.  
  10.     for(int i = 0; i < 10; i++)
  11.     {
  12.         p[i]= 0;    // initialize all to 0
  13.     }
  14.  
  15.     printf( "%d\n", p[0]);
  16.     p = array(10);
  17.     printf ("%d\n", p[0]);
  18.     return 0;
  19. }
  20.  
Mar 19 '07 #1
9 1346
RedSon
5,000 Expert 4TB
Is this an assignment, try to find the problems in the code? Next time you should use CODE tags.
Mar 19 '07 #2
micko
5
yes, try to find problem
Mar 19 '07 #3
Ganon11
3,652 Expert 2GB
We won't do your homework for you. What do you think is wrong with it?
Mar 19 '07 #4
micko
5
I think there is a problem with the array function, it should return new array if integers.

// CODE

int *array (int n)
{
return new int(n); // should be new int[ ];
}
//

Am I wrong?
Mar 19 '07 #5
Ganon11
3,652 Expert 2GB
That's one of the problems I spotted - there is one other similar to this one somewhere else in the code.
Mar 19 '07 #6
micko
5
Dynamic allocation, using delete [ ] array?
Mar 19 '07 #7
Ganon11
3,652 Expert 2GB
Yes, that would be the other problem.

If you add these two things, do you think the code will work? Try running it through a compiler to see if it does work as expected.
Mar 20 '07 #8
micko
5
It compiles, first printout is 0 and the second is some address like -84551551.
But the program gives the same result without delete [ ] array.
I think it is good, it is always good to use delete.
Mar 20 '07 #9
Ganon11
3,652 Expert 2GB
I'd say that's correctly working now. The first result is the correct value, as the array returned by the function is filled with 0s. The second result is expected, too, because a new array is created, but not filled.

Do you think it is a problem that the second array is never filled, or that the first array is not deleted?
Mar 20 '07 #10

Sign in to post your reply or Sign up for a free account.

Similar topics

51
by: Mudge | last post by:
Please, someone, tell me why OO in PHP is better than procedural.
9
by: bigoxygen | last post by:
Hi. I'm using a 3 tier FrontController Design for my web application right now. The problem is that I'm finding to have to duplicate a lot of code for similar functions; for example, listing...
4
by: jason | last post by:
Hello. Newbie on SQL and suffering through this. I have two tables created as such: drop table table1; go drop table table2; go
16
by: Dario de Judicibus | last post by:
I'm getting crazy. Look at this code: #include <string.h> #include <stdio.h> #include <iostream.h> using namespace std ; char ini_code = {0xFF, 0xFE} ; char line_sep = {0x20, 0x28} ;
109
by: Andrew Thompson | last post by:
It seems most people get there JS off web sites, which is entirely logical. But it is also a great pity since most of that code is of such poor quality. I was looking through the JS FAQ for any...
5
by: ED | last post by:
I currently have vba code that ranks employees based on their average job time ordered by their region, zone, and job code. I currently have vba code that will cycle through a query and ranks each...
0
by: Namratha Shah \(Nasha\) | last post by:
Hey Guys, Today we are going to look at Code Access Security. Code access security is a feature of .NET that manages code depending on its trust level. If the CLS trusts the code enough to...
18
by: Joe Fallon | last post by:
I have some complex logic which is fairly simply to build up into a string. I needed a way to Eval this string and return a Boolean result. This code works fine to achieve that goal. My...
37
by: Alan Silver | last post by:
Hello, Newbie here, so please forgive what is probably a basic question ... I see a lot of discussion about "code behind", which if I have understood correctly, means that the script code goes...
171
by: tshad | last post by:
I am just trying to decide whether to split my code and uses code behind. I did it with one of my pages and found it was quite a bit of trouble. I know that most people (and books and articles)...
0
by: ryjfgjl | last post by:
ExcelToDatabase: batch import excel into database automatically...
0
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 6 Mar 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, we are pleased to welcome back...
0
by: Vimpel783 | last post by:
Hello! Guys, I found this code on the Internet, but I need to modify it a little. It works well, the problem is this: Data is sent from only one cell, in this case B5, but it is necessary that data...
0
by: jfyes | last post by:
As a hardware engineer, after seeing that CEIWEI recently released a new tool for Modbus RTU Over TCP/UDP filtering and monitoring, I actively went to its official website to take a look. It turned...
0
by: ArrayDB | last post by:
The error message I've encountered is; ERROR:root:Error generating model response: exception: access violation writing 0x0000000000005140, which seems to be indicative of an access violation...
1
by: PapaRatzi | last post by:
Hello, I am teaching myself MS Access forms design and Visual Basic. I've created a table to capture a list of Top 30 singles and forms to capture new entries. The final step is a form (unbound)...
1
by: Defcon1945 | last post by:
I'm trying to learn Python using Pycharm but import shutil doesn't work
0
by: af34tf | last post by:
Hi Guys, I have a domain whose name is BytesLimited.com, and I want to sell it. Does anyone know about platforms that allow me to list my domain in auction for free. Thank you
0
isladogs
by: isladogs | last post by:
The next Access Europe User Group meeting will be on Wednesday 3 Apr 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM). In this session, we are pleased to welcome former...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.