467,915 Members | 1,797 Online
Bytes | Developer Community
New Post

Home Posts Topics Members FAQ

Post your question to a community of 467,915 developers. It's quick & easy.

std::string and gcc problem ?

Hi Guys,
i've problem with my small C++ programm. I've just small template
class which represetns a array, everything works fine up to
combination with std::string. I did tried it with M$ VC++ and with GCC
(Cygwin and Linux) and my problem is when i try do this

int main(int argc, char **argv) {
array<std::stringa(10);

a[0] = "Huhuhu"; <--- with gcc i got a crash !

std::string = a[0];
return 0;
}
the program crashes with segmentation fault on std::string::assign(),
but just with gcc ?!
Can somebode help me solve this problem ?

peter

.... and here is my code

#ifndef _array_h
#define _array_h
#include <stdexcept>
#include <sstream>
#include <stdlib.h>
#include <memory.h>
#ifdef _DEBUG
#include <iostream>
#endif

template <typename T>
class array {
public:
array(size_t ) throw(std::bad_alloc &);
array(const array<T& ) throw(std::bad_alloc &);
~array();

T& operator[](size_t ) throw(std::out_of_range &);
const T&operator[](size_t ) const throw(std::out_of_range &);

size_t length() const { return size; }

int compare(const array<T& ) const;

bool operator==(const array<T&arg ) { return compare(arg) == 0; }
bool operator!=(const array<T&arg ) { return compare(arg) != 0; }
bool operator<(const array<T&arg ) { return comapre(arg) < 0; }
bool operator>(const array<T&arg ) { return compare(arg) 0; }
bool operator!() const { return length 0; }

private:
T *data;
size_t size;
};

#endif

template <typename T>
array<T>::array(size_t e) throw(std::bad_alloc & )
{
data = NULL; size = 0;
data = new T[e];
size = e;
}

template <typename T>
array<T>::~array()
{
if(data != NULL)
delete [] data;
data = NULL;
size = 0;
}

template <typename T>
const T& array<T>::operator[](size_t idx) const
throw(std::out_of_range &)
{
if(idx size) {
std::stringstream error;
error << "idx size " << __FILE__ << "(" << __FUNCTION__ << ":" <<
__LINE__ << ")";
#ifdef _DEBUG
std::cerr << error.c_str() << std::endl;
#endif
throw std::out_of_range(error.str());
}

return data[idx];
}
template <typename T>
T& array<T>::operator[](size_t idx) throw(std::out_of_range &)
{
if(idx size) {
std::stringstream error;
error << "idx size " << __FILE__ << "(" << __FUNCTION__ << ":" <<
__LINE__ << ")";
#ifdef _DEBUG
std::cerr << error.str().c_str() << std::endl;
#endif
throw std::out_of_range(error.str());
}

return data[idx];
}

Mar 7 '07 #1
  • viewed: 10655
Share:
4 Replies
da*****@gmx.net wrote:
i've problem with my small C++ programm. I've just small template
class which represetns a array, everything works fine up to
combination with std::string. I did tried it with M$ VC++ and with GCC
(Cygwin and Linux) and my problem is when i try do this

int main(int argc, char **argv) {
Why do you need 'argc' and 'argv'? You never use them!
array<std::stringa(10);
'array' is undeclared at this point. But presuming you have included
your template definition from below somehow... Supposedly here you
have create an array that internally allocates 10 strings and allows
you the use of all of them, right?
>
a[0] = "Huhuhu"; <--- with gcc i got a crash !
And with VC++ you don't, correct?

So, 'a[0]' returns a reference to the zeroth element in your array in
the 'a' object. Having looked at the operator[], I don't see any
problem with it. Did you try using a debugger to see what values you
get into the 'std::string::assign'?
>
std::string = a[0];
This shouldn't even compile! How did you get a crash? Are you
sure you posted your _real_ code?
return 0;
}
the program crashes with segmentation fault on std::string::assign(),
but just with gcc ?!
Can somebode help me solve this problem ?
If it's a GNU-specific problem, GNU people should be able to help.
The code looks fine but only if one assumes that the stuff that you
omitted is correct.
>
peter

... and here is my code

#ifndef _array_h
#define _array_h
Avoid leading underscores like the plague. Any identifier that begins
with an underscore is reserved in the global namespace.
#include <stdexcept>
No such standard header.
#include <sstream>
#include <stdlib.h>
#include <memory.h>
#ifdef _DEBUG
#include <iostream>
#endif

template <typename T>
class array {
public:
array(size_t ) throw(std::bad_alloc &);
array(const array<T& ) throw(std::bad_alloc &);
~array();

T& operator[](size_t ) throw(std::out_of_range &);
const T&operator[](size_t ) const throw(std::out_of_range &);

size_t length() const { return size; }

int compare(const array<T& ) const;

bool operator==(const array<T&arg ) { return compare(arg) == 0; }
bool operator!=(const array<T&arg ) { return compare(arg) != 0; }
bool operator<(const array<T&arg ) { return comapre(arg) < 0; }
bool operator>(const array<T&arg ) { return compare(arg) 0; }
Why aren't those operators 'const'?
bool operator!() const { return length 0; }

private:
T *data;
size_t size;
};

#endif

template <typename T>
array<T>::array(size_t e) throw(std::bad_alloc & )
{
data = NULL; size = 0;
What is that for?
data = new T[e];
size = e;
}

template <typename T>
array<T>::~array()
{
if(data != NULL)
delete [] data;
data = NULL;
size = 0;
}

template <typename T>
const T& array<T>::operator[](size_t idx) const
throw(std::out_of_range &)
{
if(idx size) {
std::stringstream error;
error << "idx size " << __FILE__ << "(" << __FUNCTION__ << ":" <<
__LINE__ << ")";
#ifdef _DEBUG
std::cerr << error.c_str() << std::endl;
#endif
throw std::out_of_range(error.str());
}

return data[idx];
}
template <typename T>
T& array<T>::operator[](size_t idx) throw(std::out_of_range &)
{
if(idx size) {
std::stringstream error;
error << "idx size " << __FILE__ << "(" << __FUNCTION__ << ":" <<
__LINE__ << ")";
#ifdef _DEBUG
std::cerr << error.str().c_str() << std::endl;
#endif
throw std::out_of_range(error.str());
}

return data[idx];
}
V
--
Please remove capital 'A's when replying by e-mail
I do not respond to top-posted replies, please don't ask
Mar 7 '07 #2
On 7 Mar, 13:59, "Victor Bazarov" <v.Abaza...@comAcast.netwrote:
daro...@gmx.net wrote:
#include <stdexcept>

No such standard header.
Where does your implementation declare std::logic_error and the like
then?

Gavin Deane

Mar 7 '07 #3
Gavin Deane wrote:
On 7 Mar, 13:59, "Victor Bazarov" <v.Abaza...@comAcast.netwrote:
>daro...@gmx.net wrote:
>>#include <stdexcept>

No such standard header.

Where does your implementation declare std::logic_error and the like
then?
My mistake.
Mar 7 '07 #4

da*****@gmx.net wrote:
>
int main(int argc, char **argv)
argc, argv are never used
{
array<std::stringa(10);

a[0] = "Huhuhu"; <--- with gcc i got a crash !
comment sign // lost
>
std::string = a[0];
error assignment to type

std::string tmp= a[0];
return 0;
}

template <typename T>
class array {
public:
array(size_t ) throw(std::bad_alloc &);
array(const array<T& ) throw(std::bad_alloc &);
extra <Tfor "array<T&"
array(const array& ) throw(std::bad_alloc &);

assignment operator lost
array& operator=(const array& ) throw(std::bad_alloc &);
>
template <typename T>
array<T>::array(size_t e) throw(std::bad_alloc & )
{
data = NULL; size = 0;
data = new T[e];
size = e;
}
assignment instead of initialization,
extra assignment to data, size

template <typename T>
array<T>::array(size_t e) throw(std::bad_alloc & )
:data( e? new T[e]: 0),
size(e)
{}
>
template <typename T>
array<T>::~array()
{
if(data != NULL)
rare needed, here extra comparsion with "data"
delete [] data;
data = NULL;
rare needed, here extra assignment to "data"
size = 0;
more rare needed, here extra assignment to "size"
}

template <typename T>
const T& array<T>::operator[](size_t idx) const
throw(std::out_of_range &)
{
if(idx size) {
if(idx >= size) {

assuming idx, size unsigned
size is 1..N or empty
idx is 0..size-1 or overflow
std::stringstream error;
error << "idx size " << __FILE__ << "(" << __FUNCTION__ << ":" <<
__LINE__ << ")";
#ifdef _DEBUG
std::cerr << error.c_str() << std::endl;
#endif
throw std::out_of_range(error.str());
}

return data[idx];
}
template <typename T>
T& array<T>::operator[](size_t idx) throw(std::out_of_range &)
{
if(idx size) {
if(idx >= size) {
std::stringstream error;
error << "idx size " << __FILE__ << "(" << __FUNCTION__ << ":" <<
__LINE__ << ")";
#ifdef _DEBUG
std::cerr << error.str().c_str() << std::endl;
#endif
throw std::out_of_range(error.str());
}

return data[idx];
}
***********
a[0] = "Huhuhu"; //<--- with gcc i got a crash !
std::string::assign(...
/**
* The data is copied,

so must not be errors here

--
Maksim A. Polyanin
http://grizlyk1.narod.ru/cpp_new

"In thi world of fairy tales rolls are liked olso"
/Gnume/
Mar 8 '07 #5

This discussion thread is closed

Replies have been disabled for this discussion.

Similar topics

10 posts views Thread by Angus Leeming | last post: by
11 posts views Thread by Christopher Benson-Manica | last post: by
22 posts views Thread by Jason Heyes | last post: by
19 posts views Thread by Erik Wikström | last post: by
8 posts views Thread by Patrick Kowalzick | last post: by
16 posts views Thread by Khuong Dinh Pham | last post: by
84 posts views Thread by Peter Olcott | last post: by
11 posts views Thread by Jacek Dziedzic | last post: by
By using this site, you agree to our Privacy Policy and Terms of Use.