searching word in textfile?

[Growl]

Hi, i'm a beginner of C++ and would like some help figuring out some things, any suggestions would be appreciated.

I'm trying to search a word in an array and if it's found, the output would just put found and if not, then not found.

Here is what i came up with.

#include <iostream>
#include <string>
#include <fstream>
using namespace std;
 
int main()
{
  int i=10000;
 
  string filename;
  string s;
  string word[i];
 
  cout << "Enter a filename: "; 
  cin >> filename;
 
  ifstream infile3(filename.c_str());
  if(infile3.is_open()) {
      cout << "Enter a word: "; 
      cin >> word[i];           //prompts the user to enter a word into an array
      while (infile3>>s && !infile3.eof()){
    if (s==word[i]){                       // if the word input == text word
       cout<<"found"<<endl;
           break;
                    }
        else 
       cout<<"not found"<<endl;
           break;
                                          }
        infile3.close();
                        }
  return 0;
}
 

It does compile but it keeps on telling me not found, which means that it never ever finds the word even when the word is in there. I can't figure it out, any suggestions would be great :)! thanks

[horace1]

you had a few errors - this now checks every word printing not found - if the word is found it prints found and stops you need to tidy it up

#include <iostream>
#include <string>
#include <fstream>
using namespace std;
 
int main()
{
  int i=10000;
 
  string filename;
  string s;
  string word;
 
  cout << "Enter a filename: "; 
  cin >> filename;
 
  ifstream infile3(filename.c_str());
  if(infile3.is_open()) {
      cout << "Enter a word: "; 
      cin >> word;           //prompts the user to enter a word into an array
      while (infile3>>s && !infile3.eof()){
  cout << "word " << s << endl;
    if (s==word){                       // if the word input == text word
       cout<<"found"<<endl;
           break;
                    }
        else 
       cout<<"not found"<<endl;
           //break;
                                          }
 
                        }
        infile3.close();
                                system("pause");
  return 0;
}
 

[Growl]

you had a few errors - this now checks every word printing not found - if the word is found it prints found and stops you need to tidy it up

#include <iostream>
#include <string>
#include <fstream>
using namespace std;
 
int main()
{
  int i=10000;
 
  string filename;
  string s;
  string word;
  bool found = false;
 
 
  cout << "Enter a filename: "; 
  cin >> filename;
 
  ifstream infile3(filename.c_str());
  if(infile3.is_open()) {
      cout << "Enter a word: "; 
      cin >> word;           //prompts the user to enter a word into an array
      while (infile3>>s && !infile3.eof()){
  cout << "word " << s << endl;
    if (s==word){                       // if the word input == text word
       cout<<"found"<<endl;
           found = true;
           break;
                         }
                                                   }
        if (!found){
           cout<<"not found"<<endl;
                     }
        infile3.close();
                              }
  return 0;
}
 

is there a way to do that so that it wouldn't output like fifty thousand "not found" before found?

I tried using a bool found, and set it so that when the word input is the same as the text, it's true and would cout found, and when it's not true, it would print out not found, but got the same result as the first time, which just prints out "not found" and also, what is a system "pause" do?

Thanks again,
Growl

[horace1]

move your print "not found" out of the while loop so you only test when you have finished reading the file, e.g.

      }
       if (!found){
           cout<<"not found"<<endl;
        infile3.close();
 

system("pause"); halts the program until you press enter key - some IDEs automatically close the stdout window when the program terminates so this halts the program so you can see the output before the window closes.

[Growl]

move your print "not found" out of the while loop so you only test when you have finished reading the file, e.g.

      }
       if (!found){
           cout<<"not found"<<endl;
        infile3.close();
 

system("pause"); halts the program until you press enter key - some IDEs automatically close the stdout window when the program terminates so this halts the program so you can see the output before the window closes.

Ohhh! thanks a lot O_O!