need help with my code.

[wastedhello]

ok.

here are a list of things i cant fix. ive been trying for way to long now.

1. if more then 1000 values are told, will still continue with program.
2. if -max, min, average etc run, and 2 values are given they will work, but will cause a random segmentation fault. (BUT only with giving two values.)
3. -average doesnt give average.
4. -gta is ment to give all the values greater then the average. but doesnt do anything
5. -gt is ment to give all the values greater then valueX. which doesnt do anything either.

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
 
int  main(int argc, char ** argv)
{
// Mainline Variable Declarations
FILE * output = stdout;
FILE * input = stdin;
 
int count;
int maxsize;
 
float valueX;
float total;
float average;
float max;
float min;
float maxX;
float maxA;
 
 fprintf(output,"please enter the number of values that will be given: "); fflush(output);
 fscanf(input,"%d",&maxsize);
 
 float values[maxsize];
 
 
 if (maxsize<=1000 || maxsize>0)
 {
  for (count=0;count<maxsize;count++)
  {
   fprintf(output,"please enter a value: "); fflush(output);
   fscanf(input,"%f",&values[count]);
  }
 }
 else
 {
  fprintf(output,"please enter a value greater then 0 or 1000 or less\n");
 }
 
for (count=0; count<=argc-1;count++)
{
 if (strcmp(argv[count],"-help")==0)
 {
  fprintf(output,"help\n");
  return 0;
 }
 
 if (strcmp(argv[count],"-max")==0)
 {
  max=values[0];
  for (count=0;count<maxsize;count++)
  {
   if ( values[count]>max)
   {
    max=values[count];
   }
  }
  fprintf(output,"the max value is: %f\n",max);
 }
 
 if (strcmp(argv[count],"-min")==0)
 {
  min=values[0];
  for (count=0;count<maxsize;count++)
  {
   if (values[count]<min)
   {
    min=values[count];
   }
  }
  fprintf(output,"the min value is: %f\n",min);
 }
 if (strcmp(argv[count],"-average")==0)
 {
  total=values[0];
  for (count=0;count<maxsize;count++)
  {
   total+=values[count];
  }
  average=total/2;
 
  fprintf(output,"the average for these values is: %f\n",average);
 }
 if (strcmp(argv[count],"-gta")==0)
 {
  for (count=0;count<maxsize;count++)
  {
    total=total+values[count];
  }
  average=total/2;
 
  maxA=average
  for (count=average; count<maxsize;count++)
  {
   if (values[count]>maxA)
   {
    maxA=values[count];
   }
    fprintf(output,"values greater then the average are: %f\n", maxA);
  }
 }
 
 if (strcmp(argv[count],"-gt")==0)
 {
  if (argc<4)
  {
  fprintf(output,"please enter a  value\n");
  }
  else
  {
   valueX = atof(argv[count+1]);//takes value off the command line and assigns to valuex
 
   maxX=valueX;
   for (count=valueX; count<maxsize;count++)
   {
    if (values[count]>maxX)
    {
     maxX=values[count];
     fprintf(output,"values which are greater: %f\n",maxX);
    }
   }
 }
}
}
}
 

[MuraliCoder]

ok.

here are a list of things i cant fix. ive been trying for way to long now.

1. if more then 1000 values are told, will still continue with program.
2. if -max, min, average etc run, and 2 values are given they will work, but will cause a random segmentation fault. (BUT only with giving two values.)
3. -average doesnt give average.
4. -gta is ment to give all the values greater then the average. but doesnt do anything
5. -gt is ment to give all the values greater then valueX. which doesnt do anything either.

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
 
int  main(int argc, char ** argv)
{
// Mainline Variable Declarations
FILE * output = stdout;
FILE * input = stdin;
 
int count;
int maxsize;
 
float valueX;
float total;
float average;
float max;
float min;
float maxX;
float maxA;
 
 fprintf(output,"please enter the number of values that will be given: "); fflush(output);
 fscanf(input,"%d",&maxsize);
 
 float values[maxsize];
 
 
 if (maxsize<=1000 || maxsize>0)
 {
  for (count=0;count<maxsize;count++)
  {
   fprintf(output,"please enter a value: "); fflush(output);
   fscanf(input,"%f",&values[count]);
  }
 }
 else
 {
  fprintf(output,"please enter a value greater then 0 or 1000 or less\n");
 }
 
for (count=0; count<=argc-1;count++)
{
 if (strcmp(argv[count],"-help")==0)
 {
  fprintf(output,"help\n");
  return 0;
 }
 
 if (strcmp(argv[count],"-max")==0)
 {
  max=values[0];
  for (count=0;count<maxsize;count++)
  {
   if ( values[count]>max)
   {
    max=values[count];
   }
  }
  fprintf(output,"the max value is: %f\n",max);
 }
 
 if (strcmp(argv[count],"-min")==0)
 {
  min=values[0];
  for (count=0;count<maxsize;count++)
  {
   if (values[count]<min)
   {
    min=values[count];
   }
  }
  fprintf(output,"the min value is: %f\n",min);
 }
 if (strcmp(argv[count],"-average")==0)
 {
  total=values[0];
  for (count=0;count<maxsize;count++)
  {
   total+=values[count];
  }
  average=total/2;
 
  fprintf(output,"the average for these values is: %f\n",average);
 }
 if (strcmp(argv[count],"-gta")==0)
 {
  for (count=0;count<maxsize;count++)
  {
    total=total+values[count];
  }
  average=total/2;
 
  maxA=average
  for (count=average; count<maxsize;count++)
  {
   if (values[count]>maxA)
   {
    maxA=values[count];
   }
    fprintf(output,"values greater then the average are: %f\n", maxA);
  }
 }
 
 if (strcmp(argv[count],"-gt")==0)
 {
  if (argc<4)
  {
  fprintf(output,"please enter a  value\n");
  }
  else
  {
   valueX = atof(argv[count+1]);//takes value off the command line and assigns to valuex
 
   maxX=valueX;
   for (count=valueX; count<maxsize;count++)
   {
    if (values[count]>maxX)
    {
     maxX=values[count];
     fprintf(output,"values which are greater: %f\n",maxX);
    }
   }
 }
}
}
}
 

hi, i guess ur requirement will work with this code...

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
 
int  main(int argc, char ** argv)
{
// Mainline Variable Declarations
FILE * output = stdout;
FILE * input = stdin;
 
int count;
int maxsize;
 
float valueX;
float total;
float average;
float max;
float min;
float maxX;
float maxA;
 
 fprintf(output,"please enter the number of values that will be given: "); fflush(output);
 fscanf(input,"%d",&maxsize);
 
 float values[maxsize];
 
 
 if (maxsize>0 && maxsize<=1000)
 {
  for (count=0;count<maxsize;count++)
  {
   fprintf(output,"please enter a value: "); fflush(output);
   fscanf(input,"%f",&values[count]);
  }
 }
 else
 {
  fprintf(output,"please enter a value greater then 0 or 1000 or less\n");
 }
 
for (count=0; count<=argc-1;count++)
{
 if (strcmp(argv[count],"-help")==0)
 {
  fprintf(output,"help\n");
  return 0;
 }
 
 if (strcmp(argv[count],"-max")==0)
 {
  max=values[0];
  for (count=0;count<maxsize;count++)
  {
   if ( values[count]>max)
   {
    max=values[count];
   }
  }
  fprintf(output,"the max value is: %f\n",max);
 }
 
 if (strcmp(argv[count],"-min")==0)
 {
  min=values[0];
  for (count=0;count<maxsize;count++)
  {
   if (values[count]<min)
   {
    min=values[count];
   }
  }
  fprintf(output,"the min value is: %f\n",min);
 }
 if (strcmp(argv[count],"-average")==0)
 {
  total=values[0];
  for (count=0;count<maxsize;count++)
  {
   total+=values[count];
  }
  average=total/maxsize;
 
  fprintf(output,"the average for these values is: %f\n",average);
 }
 if (strcmp(argv[count],"-gta")==0)
 {
  maxA=average;
  for (count=0; count<maxsize;count++)
  {
   if (values[count]>maxA)
   {
        fprintf(output,"values greater then the average are: %f\n", values[count]);
 
   }
  }
 }
 
 if (strcmp(argv[count],"-gt")==0)
 {
  if (argc<4)
  {
  fprintf(output,"please enter a  value\n");
  }
  else
  {
   valueX = atof(argv[count+1]);//takes value off the command line and assigns to valuex
 
   maxX=valueX;
   for (count=0; count<maxsize;count++)
   {
    if (values[count]>maxX)
    {
        fprintf(output,"values which are greater: %f\n",values[count]);
    }
   }
 }
}
}
}

As i dont know ur requirements properly.. i cud solve some of your problems..
let me know if u get some other problems...

[wastedhello]

it fixed a bit.

lets see..

average seems to be printing out random numbers.
not the average.

-gta.
this command is ment to find the average.
then print out all the values greater then the average.

-gt.
this command is ment to get the user to input a value.
then print all values greater then that.

everything else works fine.

[MuraliCoder]

If that is the case...
above code should work..

[wastedhello]

-gta prints out the 5 values given, not the values greater then the average..

i will try..
does the code to find the average have to be typed again under -gta

[wastedhello]

well i got it.

just testing -gt now.

[wastedhello]

that wasnt expected.

with -gt.

the else statement didnt work.

i had to change it to an else if statement.

so i put else if (argc=3).

dont know if its the best way to put it. but it works. :D

[wastedhello]

oh theres 1 thing i want to edit.

is it possible.

if -help is specified.

i want it to give a list of help commands then stop.

because at the moment it still asks for the array values.

[Ganon11]

At this point, your program is asking for the values before it checks for the "-help" flag. If you want the program to stop before entering values if -help is typed in the command line, you will have to check for "-help" before your fscanf loop.