473,387 Members | 1,834 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,387 software developers and data experts.

passing pointer to function - modify in different function not working

Hi all,
What I am trying to do is to pass a pointer to the first element of
an array to a function, modify it in that function, and then print out
the values of the array (which has been modified by the function) in
main. However, I am getting a segmentation fault. Here is the code:
(Please note, the size is fixed in this code, but in my code where I am
actually going to use this, the size of the array is not known until
you get to the modify function which is why I am using pointer
notation).

#include <stdio.h>

void modifiy( int* nums );

int main() {
int* nums;
int i;

for (i=0; i < 5; i++) {
printf("%d", nums[i]);
}

}

void modify( int* nums ) {
int i;
nums = (int*)malloc( 5*sizeof(int));
for (i=0; i < 5; i++) {
nums[i] = i;
}
}

Once I can get this to work, I want to do the same thing w/ double
arrays, so if there are any pitfalls associated with that, any help
would be greatly appreciated.

thanks!

Jan 18 '07 #1
6 7855
"Kiran" <Ki*********@gmail.comwrites:
int main() {
int* nums;
int i;

for (i=0; i < 5; i++) {
printf("%d", nums[i]);
}
You should return a value from main(), probably 0.
}

void modify( int* nums ) {
int i;
nums = (int*)malloc( 5*sizeof(int));
I don't recommend casting the return value of malloc():

* The cast is not required in ANSI C.

* Casting its return value can mask a failure to #include
<stdlib.h>, which leads to undefined behavior.

* If you cast to the wrong type by accident, odd failures can
result.

In unusual circumstances it may make sense to cast the return value of
malloc(). P. J. Plauger, for example, has good reasons to want his
code to compile as both C and C++, and C++ requires the cast, as he
explained in article <9s*****************@nwrddc01.gnilink.net>.
However, Plauger's case is rare indeed. Most programmers should write
their code as either C or C++, not in the intersection of the two.

When calling malloc(), I recommend using the sizeof operator on
the object you are allocating, not on the type. For instance,
*don't* write this:

int *x = malloc (128 * sizeof (int)); /* Don't do this! */

Instead, write it this way:

int *x = malloc (128 * sizeof *x);

There's a few reasons to do it this way:

* If you ever change the type that `x' points to, it's not
necessary to change the malloc() call as well.

This is more of a problem in a large program, but it's still
convenient in a small one.

* Taking the size of an object makes writing the statement
less error-prone. You can verify that the sizeof syntax is
correct without having to look at the declaration.

for (i=0; i < 5; i++) {
nums[i] = i;
}
}
Your real problem is in the FAQ:

4.8: I have a function which accepts, and is supposed to initialize,
a pointer:

void f(int *ip)
{
static int dummy = 5;
ip = &dummy;
}

But when I call it like this:

int *ip;
f(ip);

the pointer in the caller remains unchanged.

A: Are you sure the function initialized what you thought it did?
Remember that arguments in C are passed by value. The called
function altered only the passed copy of the pointer. You'll
either want to pass the address of the pointer (the function
will end up accepting a pointer-to-a-pointer), or have the
function return the pointer.

See also questions 4.9 and 4.11.

--
"Large amounts of money tend to quench any scruples I might be having."
-- Stephan Wilms
Jan 18 '07 #2
Ben Pfaff writes:
Your real problem is in the FAQ:
He'd also be a step closer if main() actually called modify() :-)

--
Hallvard
Jan 18 '07 #3
Hi all,
first of all thanks for your responses.
yes, i forgot to put that in (and also the function prototype is
misspelled), but the result is the same, and after reading the faq, i
think i understand why its going wrong, but not how to fix it.

This is my understanding.
The pointer itself is a variable, in this case containing the address
of the first element in the array called nums, so when i pass modify
nums, the function modify gets its own copy of where nums in main
points to? (but if thats the case, shouldnt they both still point to
the same thing?) I think I am confusing myself here.

anyway, thanks again for all of yoru help.

Hallvard B Furuseth wrote:
Ben Pfaff writes:
Your real problem is in the FAQ:

He'd also be a step closer if main() actually called modify() :-)

--
Hallvard
Jan 18 '07 #4
Kiran writes:
This is my understanding.
The pointer itself is a variable, in this case containing the address
of the first element in the array called nums, so when i pass modify
nums, the function modify gets its own copy of where nums in main
points to? (but if thats the case, shouldnt they both still point to
the same thing?) I think I am confusing myself here.
If you allocate the memory in main(), yes. Or if you just declare
int nums[5];
or whatever in main().

If you allocate 'nums' in modify(), then when you modify the pointer
in that function, the change doesn't affect 'nums' in main(). Unless
you return 'nums' from modify() and do 'nums = modify()' in main,
or if you do
void modify(int **nums_ptr);
and call it as
main(&nums);

--
Hallvard
Jan 18 '07 #5
Kiran wrote:
Hi all,
first of all thanks for your responses.
Please don't top-post. Your replies belong following or interspersed
with properly trimmed quotes. See the majority of other posts in the
newsgroup, or:
<http://www.caliburn.nl/topposting.html>
Jan 18 '07 #6
Ben Pfaff <bl*@cs.stanford.eduwrote:
I don't recommend casting the return value of malloc():
Neither does the FAQ: http://c-faq.com/malloc/cast.html (Not to say
that your explanation wasn't excellent, just possibly unnecessary.)

--
C. Benson Manica | I *should* know what I'm talking about - if I
cbmanica(at)gmail.com | don't, I need to know. Flames welcome.
Jan 18 '07 #7

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

58
by: jr | last post by:
Sorry for this very dumb question, but I've clearly got a long way to go! Can someone please help me pass an array into a function. Here's a starting point. void TheMainFunc() { // Body of...
1
by: george doubleu | last post by:
hi, i'm using "gcc version 3.3.3 (Debian)" to compile the program pasted below. I get the two warnings you can see in the remarks. The second warning is perfectly OK for me, but the first one I...
18
by: hzmonte | last post by:
typedef int t_compare_func(const void *, const void *); struct node *tree_search(struct node *root, const void *keyy, t_compare_func *comp) { struct node *cur_item; int result; if (root ==...
11
by: John Pass | last post by:
Hi, In the attached example, I do understand that the references are not changed if an array is passed by Val. What I do not understand is the result of line 99 (If one can find this by line...
1
by: Shawn | last post by:
As if it won't be clear enough from my code, I'm pretty new to C programming. This code is being compiled with an ANSI-C compatible compiler for a microcontroller. That part, I believe, will be...
12
by: Mike | last post by:
Consider the following code: """ struct person { char *name; int age; }; typedef struct person* StructType;
17
by: I.M. !Knuth | last post by:
Hi. I'm more-or-less a C newbie. I thought I had pointers under control until I started goofing around with this: ...
6
by: Roman Mashak | last post by:
Hello, I belive the reason of problem is simple, but can't figure out. This is piece of code: struct timeval { long tv_sec; /* seconds */ long tv_usec; /* microseconds */ };
7
by: TS | last post by:
I was under the assumption that if you pass an object as a param to a method and inside that method this object is changed, the object will stay changed when returned from the method because the...
0
by: taylorcarr | last post by:
A Canon printer is a smart device known for being advanced, efficient, and reliable. It is designed for home, office, and hybrid workspace use and can also be used for a variety of purposes. However,...
0
by: Charles Arthur | last post by:
How do i turn on java script on a villaon, callus and itel keypad mobile phone
0
by: ryjfgjl | last post by:
If we have dozens or hundreds of excel to import into the database, if we use the excel import function provided by database editors such as navicat, it will be extremely tedious and time-consuming...
0
by: emmanuelkatto | last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud. Please let me know. Thanks! Emmanuel
0
BarryA
by: BarryA | last post by:
What are the essential steps and strategies outlined in the Data Structures and Algorithms (DSA) roadmap for aspiring data scientists? How can individuals effectively utilize this roadmap to progress...
1
by: nemocccc | last post by:
hello, everyone, I want to develop a software for my android phone for daily needs, any suggestions?
0
marktang
by: marktang | last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However,...
0
by: Hystou | last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can...
0
jinu1996
by: jinu1996 | last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.