Can someone look through this code for me?

[Nhd]

#include <iostream>
#include <sstream>
#include <string>
 
using namespace std;
int main(int argc, char* argv[]) {
 
    int Count1 = 1;
    int Count2 = 1;
    int Count = 0;
    int number1,number2;
 
cin>>number1>>number2;   
 
    while (number1 != 1)  
    {      
           if (number1%2==0)     
           {
              number1 = number1/2;  
              cout<<number1<<" ";
           }  
           else 
           {
                number1 = 3*number1+1;      
                cout<<number1<<" ";
           }
           ++Count1;
    }
while (number2 != 1)
    {
          if (number2%2==0)
          {
                 number2 = number2/2;  
                 cout<<number2<<" ";
          }
          else
          {
                  number2 = 3*number2+1;      
                  cout<<number2<<" ";
          }
          ++Count2;
    }
 
          Count = Count1 + Count2; 
 
    cout<<endl<<number1<<" "<<number2<<" "<<Count<<endl;
 
    system("pause");
    return 0;

The problem states that,
For any two numbers i and j you are to determine the maximum
cycle length over all numbers between i and j. (in this case, i put i and j as number1 and number 2)..

sample input is 1 10
sample output is 1 10 20

Howver, for my codes, when i input in 1 10, i get 1 1 8.. I cant get the output as wat it wants.. :(

[r035198x]

#include <iostream>
#include <sstream>
#include <string>

using namespace std;
int main(int argc, char* argv[]) {

int Count1 = 1;
int Count2 = 1;
int Count = 0;
int number1,number2;

cin>>number1>>number2;

while (number1 != 1)
{
if (number1%2==0)
{
number1 = number1/2;
cout<<number1<<" ";
}
else
{
number1 = 3*number1+1;
cout<<number1<<" ";
}
++Count1;
}
while (number2 != 1)
{
if (number2%2==0)
{
number2 = number2/2;
cout<<number2<<" ";
}
else
{
number2 = 3*number2+1;
cout<<number2<<" ";
}
++Count2;
}

Count = Count1 + Count2;

cout<<endl<<number1<<" "<<number2<<" "<<Count<<endl;

system("pause");
return 0;


The problem states that,
For any two numbers i and j you are to determine the maximum
cycle length over all numbers between i and j. (in this case, i put i and j as number1 and number 2)..

sample input is 1 10
sample output is 1 10 20

Howver, for my codes, when i input in 1 10, i get 1 1 8.. I cant get the output as wat it wants.. :(

Can you or someone else please explain how one gets the maximum cycle length over two numbers i and j? I've never heard about this cycle length thing.

[Nhd]

Can you or someone else please explain how one gets the maximum cycle length over two numbers i and j? I've never heard about this cycle length thing.

Hi... I can only explain this much to u cos i only know what is cycle length but not maximum cycle length...


Total numbers of elements in sequence until it reaches 1, including input number and 1, is called cycle of the sequence of that given input no. For example if user input 5 then the sequence will be something like this.

5 16 8 4 2 1 = cycle length equals to 6..

[r035198x]

Hi... I can only explain this much to u cos i only know what is cycle length but not maximum cycle length...


Total numbers of elements in sequence until it reaches 1, including input number and 1, is called cycle of the sequence of that given input no. For example if user input 5 then the sequence will be something like this.

5 16 8 4 2 1 = cycle length equals to 6..

All I can see is that from 16 we are dividing by two until we get to 1. but how did we get from 5 to 16? Or am I just incredibly dumb?

[Nhd]

All I can see is that from 16 we are dividing by two until we get to 1. but how did we get from 5 to 16? Or am I just incredibly dumb?

No, ur not... Its juz that the question itself is very confusing... I'll explain it..

when an input is an even number, the outcome will be number=number/2. thats where you can see the number above from 16, is divided into two until we get 1. when it reaches 1, it is considered end of the cycle.

however, when an input is an odd number, the outcome is number=3*number+1, and hence in this case, since 5 is an odd number, it will result in 5*3+1 which is 16.

this will result in the total cycle length which is 6. Howver, I'm supposed to fing the max cycle length in which i still cant figure it out, thus seeking help... I'm so sory to make u so confused over this codes.

[RedSon]

This sounds like a permutation problem. Given a list of numbers from i to j what is the maximum possible permutations before repeating. In otherwords what is the maximum possible cycle length before repeating. This is a classic problem in combinitorics and can be expressed by the equation:

factorial(n)/(factorial(n-r)) 
where r is the size of each permutation and n is the size of the sequence from which the elements are permuted
 

The trick for your program is going to be the factorial calculation if you are not able to use math libraries.