need some help with DEV C++

[angelcd]

hi guys, i have here my sample program, actually it compiles and run but some of the output does'nt come out on the screen.. can someone help me what's wrong with this...

here's my code:

#include <iostream>
#include <string>
using std::cin;
using std::cout;
 
class Grade
 
{
public:
 
    Grade () {};
    ~Grade(){};
    int GradeTotalEntry ( int total);
    int GradeFailed (int failed, int total );
    int GradeD (int D, int total);
    int GradeC (int C, int total);
    int GradeB (int B, int total);
    int GradeA (int A, int total);
    int GradeDistinction (int Dis, int total);
 
};
 
int Grade::GradeTotalEntry (int total )
 
{
    return total;
}
 
int Grade::GradeFailed (int failed, int total)
 
{
    return (failed/total)*100;
}
 
int Grade::GradeD (int D, int total)
 
{
    return (D/total)*100;
}
 
 
int Grade::GradeC (int C, int total)
 
{
    return (C/total)*100;
}
 
 
int Grade::GradeB (int B, int total)
 
{
    return (B/total)*100;
}
 
 
int Grade::GradeA (int A, int total)
 
{
    return (A/total)*100;
}
 
int Grade::GradeDistinction (int Dis, int total)
 
{
    return (Dis/total)*100;
}
 
int main ()
 
{
 
    int n[100],j,total=0;
    int failed=0,A=0,B=0,C=0,D=0,Dis=0;
    char answer[5] ="yes";
    Grade *p = new Grade;
 
 
 
    cout <<"Welcome to your Grade Computation:\n";
 
    while (strcmp (answer, "no")!=0)
 
 
      {
        cout <<"Enter Mark:\t";
        cin >> n[total];
        total++;
 
          {
 
        if (n[j]>100)
          {
        cout <<"can't be more than 100, pls enter another number from 0 to 100:\n";
          }
        cout <<"Would you like to enter another mark? (yes), or (no)";
        std::cin >> answer;
          }
 
 
        while ((strcmp (answer, "yes")!=0) && (strcmp (answer, "no")!=0))
 
          {
        cout << "Please answer only by \"yes\" or \"no\"!";
        std::cin >> answer;
 
          }
}
        cout <<"\n";
        cout<<"Your total input:\t"<<p->GradeTotalEntry(total)<<"\n";
 
        for ( j=0; j<total; j++)
    {
         if (n[j] >=90)
        Dis ++;
         else if (n[j] >=80)
        A++;
         else if (n[j] >=70)
        B++;
         else if (n[j] >=60)
        C++;
         else if (n[j] >=50)
        D++;
         else if (n[j] < 50)
        failed++;
    }
        cout <<"\n";
        cout << "Percentage Distinction:\t"<<p->GradeDistinction(Dis,total) <<"%" <<"\n";
        cout << "Percentage A:\t"<<p->GradeA (A,total)<<"%"  <<"\n";
        cout << "Percentage B:\t"<<p->GradeB (B,total) <<"%" <<"\n";
        cout << "Percentage C:\t"<<p->GradeC (C,total) <<"%" <<"\n";
        cout << "Percentage D:\t"<<p->GradeD (D,total) <<"%" <<"\n";
        cout << "Percentage failed:\t"<<p->GradeFailed (failed,total) <<"%" <<"\n";
 
     delete p;
     system ( "pause");
     return 0;
}
 

when i input something it works and it ask me the question if i want to enter another mark and it continues up to the time i answers no, it actually reads my total number, but it doesnt print the percentage of the grades, he always read zero for all grades even i enter all the inputs, and when i enter 101 for example because it exceed my limit, and i enter the number again the out put of

"can't be more than 100, pls enter another number from 0 to 100:\n"

does'nt erase on the screen even i enter smaller number, what happen to this

i need some help

thanks in advance'

angel

[Banfa]

Ok here are a couple of problems you have, in this section of code

    cout <<"Enter Mark:\t";
    cin >> n[total];
    total++;
 
    {
        if (n[j]>100)
        {
            cout <<"can't be more than 100, pls enter another number from 0 to 100:\n";
        }
 
        cout <<"Would you like to enter another mark? (yes), or (no)";
        std::cin >> answer;
    }
 
 

The { and } in bold are unrequired
You check n[j] in the if statement but j is not initalised yet
Even if the if statement was working correctly you have already incremented total so the erroneous mark gets included into your list of marks anyway.


The following error and explaination applies to GradeFailed, GradeD, GradeC, GradeB, GradeA and GradeDistinction but I will only consider GradeA

int Grade::GradeA (int A, int total)
 
{
    return (A/total)*100;
}
 

This is supposed to calculate the % of grade As from the total number of grades, so if A is 23 and total is 46 you would expect an answer of 50% right?

Wrong, this is done in integer arithmatic, so no fractions and you specifically do A/total first. Puting the numbers into the calculation

(23 / 46) * 100

So we do 23 / 46 first. What is 23 / 46? Well 0.5 in real arithmatic but in integer arithmatic it is 0.

0 * 100 = 0

You need to perform the multiplication first, this is generally true for integer arithmatic except where performing the multiplication first would result in an overflow (i.e. the resulting number is too large to be held in the variable type).

So a re-write like this should cure the problem

int Grade::GradeA (int A, int total)
 
{
    return A * 100 / total;
}
 

[angelcd]

Ok here are a couple of problems you have, in this section of code

    cout <<"Enter Mark:\t";
    cin >> n[total];
    total++;
 
    {
        if (n[j]>100)
        {
            cout <<"can't be more than 100, pls enter another number from 0 to 100:\n";
        }
 
        cout <<"Would you like to enter another mark? (yes), or (no)";
        std::cin >> answer;
    }
 
 

The { and } in bold are unrequired
You check n[j] in the if statement but j is not initalised yet
Even if the if statement was working correctly you have already incremented total so the erroneous mark gets included into your list of marks anyway.


The following error and explaination applies to GradeFailed, GradeD, GradeC, GradeB, GradeA and GradeDistinction but I will only consider GradeA

int Grade::GradeA (int A, int total)
 
{
    return (A/total)*100;
}
 

This is supposed to calculate the % of grade As from the total number of grades, so if A is 23 and total is 46 you would expect an answer of 50% right?

Wrong, this is done in integer arithmatic, so no fractions and you specifically do A/total first. Puting the numbers into the calculation

(23 / 46) * 100

So we do 23 / 46 first. What is 23 / 46? Well 0.5 in real arithmatic but in integer arithmatic it is 0.

0 * 100 = 0

You need to perform the multiplication first, this is generally true for integer arithmatic except where performing the multiplication first would result in an overflow (i.e. the resulting number is too large to be held in the variable type).

So a re-write like this should cure the problem

int Grade::GradeA (int A, int total)
 
{
    return A * 100 / total;
}
 

hi sir, thanks for your help i think your surely right, i will try this one, maybe thats the real problem because all aswers in percentage came out zero, so in your explanation it was really true....

thanks again,

regards,
angel