C Problem

[dineshchand]

/*# ReadRealyLongTextLine() needs to be written (by you). The text line could be very very very very long!!! upto 30K characters or more than this
# There is a logical error in the code – you need to find it and fix it.*/

/***
PrintX.c
Prints the file C:\X.TXT line by line.
*/

char * ReadRealyLongTextLine(File* p_fhInFile)
{

}

void PrintX(void)
{

File* fhInFile;

char *strLineBuf;
fhInFile = fopen(“c:\\x.txt”, “r”);

if(fhInfile)

{

while( (strLineBuf = ReadRealyLongTextLine(fhInFile)) != NULL)

printf(“%s”, strLineBuf);

fclose(fhInFile);

}

else

printf(“\r\nCould not find C:\\X.TXT!!”);



}
int main()

{

PrintX();

}

/* only FUNCTION readrealylongtextline() needs to be written and the logical problem needs to be figured out
plz do post ur replies .

[willakawill]

/*# ReadRealyLongTextLine() needs to be written (by you). The text line could be very very very very long!!! upto 30K characters or more than this
# There is a logical error in the code – you need to find it and fix it.*/

/***
PrintX.c
Prints the file C:\X.TXT line by line.
*/

char * ReadRealyLongTextLine(File* p_fhInFile)
{

}

void PrintX(void)
{

File* fhInFile;

char *strLineBuf;
fhInFile = fopen(“c:\\x.txt”, “r”);

if(fhInfile)

{

while( (strLineBuf = ReadRealyLongTextLine(fhInFile)) != NULL)

printf(“%s”, strLineBuf);

fclose(fhInFile);

}

else

printf(“\r\nCould not find C:\\X.TXT!!”);



}
int main()

{

PrintX();

}

/* only FUNCTION readrealylongtextline() needs to be written and the logical problem needs to be figured out
plz do post ur replies .

Hi. I think this part:
while( (strLineBuf = ReadRealyLongTextLine(fhInFile)) != NULL)

is a logical error as an assignment operation will always evaluate to true and never to NULL

this part
if(fhInfile)
is a syntax error (typo maybe)

[dineshchand]

no i think bug is at some other place , also u need to write the function ReadReallyLongTextLine()

[willakawill]

no i think bug is at some other place , also u need to write the function ReadReallyLongTextLine()

this snippet works. Perhaps you can work out the answer to your problem from this

#include "stdafx.h"
#include <iostream>
#include <fstream>
#include <string>
using namespace std;
 
string inputtextfile(ifstream &pt)
{
    string buff;
    getline(pt, buff);
    return buff;
}
 
int main(int argc, char* argv[])
{
    string s;
    ifstream f( "c:\\x.txt" );
 
    if(!f) {
    cerr << "Couldn't open file\n";
    }
 
    while (f) {
        s = inputtextfile(f);
        cout << s << '\n';
    }
 
    cout << endl;
    return 0;
}
 

[dineshchand]

no answer has to be in that form only as in the original question
same ReadRealyLongTextLine() function has to be implemented and with same return arguments as stated , thanks for this reply but was not required

[willakawill]

no answer has to be in that form only as in the original question
same ReadRealyLongTextLine() function has to be implemented and with same return arguments as stated , thanks for this reply but was not required

You're welcome and you have to do some work.
When someone asks me to complete a project where they do not do any work I charge them $50 per hour. I take checks and PayPal :)

[svsandeep]

/*# ReadRealyLongTextLine() needs to be written (by you). The text line could be very very very very long!!! upto 30K characters or more than this
# There is a logical error in the code – you need to find it and fix it.*/

/***
PrintX.c
Prints the file C:\X.TXT line by line.
*/

char * ReadRealyLongTextLine(File* p_fhInFile)
{

}

void PrintX(void)
{

File* fhInFile;

char *strLineBuf;
fhInFile = fopen(“c:\\x.txt”, “r”);

if(fhInfile)

{

while( (strLineBuf = ReadRealyLongTextLine(fhInFile)) != NULL)

printf(“%s”, strLineBuf);

fclose(fhInFile);

}

else

printf(“\r\nCould not find C:\\X.TXT!!”);



}
int main()

{

PrintX();

}

/* only FUNCTION readrealylongtextline() needs to be written and the logical problem needs to be figured out
plz do post ur replies .

Dude,

#include <stdio.h>
#include <stdlib.h>
#include <iostream.h>

//Global Declarations.
struct iread
{
char c[];
} *ptr;
int getout=0;

char* ReadRealyLongTextLine(FILE *p_fhInFile)
{
char ch;

//used to get out of the program once EOF has reached

if (getout == 1)
return NULL;

//32 kb allocation. Increase this if you want more. Nothing related to exception handling is taken care here. What if we cant allocate the
//Memory?? so dude do it yourself..

ptr = (iread*) malloc(32768);

int count = 0;
while(p_fhInFile != NULL )
{
ch = fgetc(p_fhInFile);
ptr->c[count]=ch;

//Found the end of line throw the entire line back to the parent function

if (ptr->c[count] == '\n')
return ptr->c;

//This in other words is useful if we have reached the last line
//(which will not have \n at the end of line)

if ( ch == EOF )
{
getout = 1;
return ptr->c;
}

count++;
}
}


void PrintX(void)
{
FILE *fhInFile;
char *strLineBuf;
fhInFile = fopen("c:/X.TXT", "r");

if(fhInFile)
{
while( (strLineBuf = ReadRealyLongTextLine(fhInFile)) != NULL)
{
printf("%s", strLineBuf);
//The below two statements are for taking the memory back from ptr's.
ptr=NULL;
free(ptr);
}
fclose(fhInFile);
}
else
printf("\r\nCould not find C:\\X.TXT!!");
}
int main()
{
PrintX();
}


You can sure improve the above program ;)

Regards,
ShaggY@FtF

[dineshchand]

hi

ur program is good but lost of resources are wasted eg- consider when the no. of characters in the line r less i.e . 10 or so

Thats the main area where u function has to handle resources .

Hope u look into it.

[gurutheexpert]

Hi,
This is my first post. I have found a solution . Any suggestions are welcome.


#include <stdio.h>
#include <memory.h>

char * ReadRealyLongTextLine(FILE * p_fhInFile)
{
// status variable to decide whether to continue reading or not
static bool bContinue = true;

// create a buffer of suitabele size in my case i took 1000
static char *pVeryVeryLongTextLine = new char [1000];
memset (pVeryVeryLongTextLine,'\0',1000);

char newChar;
char * TempPtrToTextLine = pVeryVeryLongTextLine;
int ncReadThisTime = 0;


// check if we need to continue reading or not
if (!bContinue)
{
delete pVeryVeryLongTextLine;
return NULL;
}

// continue reading file until end of file reached
// or a line ends or buffer capcity is over
while ( (newChar != EOF) && ( newChar != '\n') && (ncReadThisTime != 999) )
{
newChar = getc(p_fhInFile);

*TempPtrToTextLine++ = newChar;
ncReadThisTime++;
}

if (ncReadThisTime == 999)
bContinue = true;
else
bContinue = false;

// if line ended or end of file detected
// return the characers read this time and next time return NULL
return pVeryVeryLongTextLine;
}

void PrintX(void)
{

FILE* fhInFile;

char *strLineBuf;
fhInFile = fopen("x.txt", "r");

if(fhInFile)

{

while( (strLineBuf = ReadRealyLongTextLine(fhInFile)) != NULL)

printf("%s", strLineBuf);

fclose(fhInFile);

}

else

printf("\r\nCould not find C:\\X.TXT!!");


}
int main()

{

PrintX();
return 1;
}

[dineshchand]

i looked into ur code and i found out the following things
1. what if the line is greater than 1000 characters ,e g if it is 1050 characters long than u have to return whole characters in the in the same line ....

[gurutheexpert]

Hi,

If line contains more than 1000 chars , then it will return the chars in chunks of 999 at one time until the line ends or end of file is reached.

I think u haven't noticed the bool variable and comment written there. it is a static variable whose status will change to "false" only when new line starts or end of file reached and then it will return NULL which will terminate ur while int Print ();

I hope i cleared ur doubt. u can test and verify the same as i have done.

[gurutheexpert]

Hi,

One more thinhg ,your while loop is to decide when to stop reading . Until ReadRealyLongTextLine() doesn't return NULL , it isn't going to terminate.

Here ReadRealyLongTextLine() returns NULL only when whole line is read.
Only thing is that you have a slight trade of betwwen execution time ie. ReadRealyLongTextLine function will be called more times , if line size is large.

But it is upto you to decide whether you want time efficiency or memory.

[dineshchand]

Hi,

One more thinhg ,your while loop is to decide when to stop reading . Until ReadRealyLongTextLine() doesn't return NULL , it isn't going to terminate.

Here ReadRealyLongTextLine() returns NULL only when whole line is read.
Only thing is that you have a slight trade of betwwen execution time ie. ReadRealyLongTextLine function will be called more times , if line size is large.

But it is upto you to decide whether you want time efficiency or memory.

hi
yaar thanks for the reply and so much of effort u r giving for this .
yes i understood ur logic (u r calling the ReadRealyLongLine function for every 999 characyers read ) but there r some compile time errors
Will u plz look into this ?

[gurutheexpert]

hi
yaar thanks for the reply and so much of effort u r giving for this .
yes i understood ur logic (u r calling the ReadRealyLongLine function for every 999 characyers read ) but there r some compile time errors
Will u plz look into this ?

hi,
Sure. What errors ,as far as I know , there are no errors in this program. I have tested it . Let me know .

[dineshchand]

hi,
Sure. What errors ,as far as I know , there are no errors in this program. I have tested it . Let me know .

Thanks for ur effort .... there was some petty errors ....i highly appreciate ur logic ...
Thanks once more ..

[svsandeep]

hi

ur program is good but lost of resources are wasted eg- consider when the no. of characters in the line r less i.e . 10 or so

Thats the main area where u function has to handle resources .

Hope u look into it.

Dude,

Thx for the suggestion. Okie then we will do one thing, how about counting number of chr's the line (the line we are going to read) have? This can be easily done by using fgetc function and a silly counter. According to this number, then we can allocate the memory required and also move back the file pointer to the required position using some seek function. This way there will not be waste of so called resources..

Regards,
ShaggY@FtF

[dineshchand]

guys
there is a major modification because we need to return whole line from the text file at once .can u guys come up with something ..i m looking forward to ur solution ...

[dineshchand]

The ReadRealyLongTextLine() needs to return whole line of the text file at one go

[svsandeep]

guys
there is a major modification because we need to return whole line from the text file at once .can u guys come up with something ..i m looking forward to ur solution ...

oopsie,

Confused!! i think that is what my code do...

Regards,
ShaggY@FtF