array help in battleship game.

[muna123]

hi,

I need help in battleship game
here is my code:


#include <stdio.h>

void draw_game(char board[ ], int maway, int mleft, int score, char prevmove[ ]);

int main( ) {
char board[391], prevmove[41];
int i, missles = 50, mleft = 0, score = 0;

strcpy(prevmove, ""); /* an empty string */

for(i=0; i<15*26; i++){
board[i] = '~';
}
board[i] = '\0';

draw_game(board, missles, mleft, score, prevmove);

draw_game(board, missles, mleft, score, prevmove);
return 0;
}


void draw_game(char board[ ], int maway, int mleft, int score, char prevmove[ ]) {
int i,input ,j;
char row_letters[16] = "123456789ABCDEF";

printf(" C Battleship...\n");
printf(" ABCDEFGHIJKLMNOPQRSTUVWXYZ\n");

for(i=0; i<15; i++) { /* rows */
printf("%c|", row_letters[i]);

for(j=0; j<26; j++) { /* columns */
printf("%c", board[j]);
}
printf("|\n");
}

printf(" Missiles Away:%.2d Missiles Left:%.2d\n", maway, mleft);
printf(" Current Score:%.3d Last Move: %s\n", score, prevmove);
printf(" Enter Target Coordinates--> ");
scanf("%d",&input);
board[input] ='X';
}

__________________________________________________ ________________

the output it should be like this:

C Battleship...
ABCDEFGHIJKLMNOPQRSTUVWXYZ
1|~~~~~~~~~~~~~~~~~~~~~~~~~~|
2|~~~~~~~~~~~~~~~~~~~~~~~~~~|
3|~~~~~~~~~~~~~~~~~~~~~~~~~~|
4|~~~~~~~~~~~~~~~~~~~~~~~~~~|
5|~~~~~~~~~~~~~~~~~~~~~~~~~~|
6|~~~~~~~~~~~~~~~~~~~~~~~~~~|
7|~~~~~~~~~~~~~~~~~~~~~~~~~~|
8|~~~~~~~~~~~~~~~~~~~~~~~~~~|
9|~~~~~~~~~~~~~~~~~~~~~~~~~~|
A|~~~~~~~~~~~~~~~~~~~~~~~~~~|
B|~~~~~~~~~~~~~~~~~~~~~~~~~~|
C|~~~~~~~~~~~~~~~~~~~~~~~~~~|
D|~~~~~~~~~~~~~~~~~~~~~~~~~~|
E|~~~~~~~~~~~~~~~~~~~~~~~~~~|
F|~~~~~~~~~~~~~~~~~~~~~~~~~~|
Missiles Away:00 Missiles Left:50
Current Score:000 Last Move:
Enter Target Coordinates--> 5T

C Battleship...
ABCDEFGHIJKLMNOPQRSTUVWXYZ
1|~~~~~~~~~~~~~~~~~~~~~~~~~~|
2|~~~~~~~~~~~~~~~~~~~~~~~~~~|
3|~~~~~~~~~~~~~~~~~~~~~~~~~~|
4|~~~~~~~~~~~~~~~~~~~~~~~~~~|
5|~~~~~~~~~~~~~~~~~~~X~~~~~~|
6|~~~~~~~~~~~~~~~~~~~~~~~~~~|
7|~~~~~~~~~~~~~~~~~~~~~~~~~~|
8|~~~~~~~~~~~~~~~~~~~~~~~~~~|
9|~~~~~~~~~~~~~~~~~~~~~~~~~~|
A|~~~~~~~~~~~~~~~~~~~~~~~~~~|
B|~~~~~~~~~~~~~~~~~~~~~~~~~~|
C|~~~~~~~~~~~~~~~~~~~~~~~~~~|
D|~~~~~~~~~~~~~~~~~~~~~~~~~~|
E|~~~~~~~~~~~~~~~~~~~~~~~~~~|
F|~~~~~~~~~~~~~~~~~~~~~~~~~~|
Missiles Away:01 Missiles Left:49
Current Score:000 Last Move: MISS on 5T
Enter Target Coordinates-->
__________________________________________________ ____

I have troubling with coordinates, i don't know how to do it. suppose if users enter 5T, the result should be X in row 5 and col T.

need help
thanks

[Banfa]

May I ask why you have implemented the board as a single dimentioned array. For this program a 2 dimensioned array would seem to be easier

board[15][26];

[muna123]

May I ask why you have implemented the board as a single dimentioned array. For this program a 2 dimensioned array would seem to be easier

board[15][26];

i know but i am troubling with the results plz help me out


thanks

[Banfa]

Well the reason for my last question is that you have accessed the board array incorrectly in the nested loop

 for(i=0; i<15; i++) { /* rows */
    printf("%c|", row_letters[i]);
 
    for(j=0; j<26; j++) { /* columns */
        printf("%c", board[j]);
    }
 
    printf("|\n");
}
 

printf("%c", board[j]);

should be

printf("%c", board[i*26+j]);

[muna123]

Well the reason for my last question is that you have accessed the board array incorrectly in the nested loop

 for(i=0; i<15; i++) { /* rows */
    printf("%c|", row_letters[i]);
 
    for(j=0; j<26; j++) { /* columns */
        printf("%c", board[j]);
    }
 
    printf("|\n");
}
 

printf("%c", board[j]);

should be

printf("%c", board[i*26+j]);

hi,

it works but it only count col. suppose if u enter 4T. it will only count ```x. it doesn't count char.

plz help me out
thanks

[Banfa]

That is because you have used

scanf("%d",&input);

You are requesting a number where as what you actually want as input is a string, a 1 char row id and a 1 char column id.

Use fgets to read in a line of data, then verify the first character is a valid row and the second character is a valid column and that the 3rd character is the termintor.