473,322 Members | 1,566 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,322 software developers and data experts.

Need fo help!

When I type every number=0,the largest is 4. It'sconfusing! What's
wrong with my program?
---------------------------(my source
code)-------------------------------
#include<iostream>
using namespace std;
int main()
{
int counter=0;
int largest,number;
while(counter<10)
{
cout<<"Enter a Number:";
cin>>number;
if (number>largest)
largest=number;
else
largest=largest;
counter=counter+1;
}
cout<<"The largest is "<<largest<<endl;
return 0;
}

Nov 19 '06 #1
8 1472
br*******@gmail.com wrote:
#include<iostream>
using namespace std;
int main()
{
int counter=0;
int largest,number;
// Insert here:
cerr << "TESTING: value of largest is: " << largest << '\n';
while(counter<10)
{
cout<<"Enter a Number:";
cin>>number;
if (number>largest)
largest=number;
else
largest=largest;
counter=counter+1;
}
cout<<"The largest is "<<largest<<endl;
return 0;
}
--
Salu2
Nov 19 '06 #2


On Nov 19, 2:29 pm, bryant...@gmail.com wrote:
When I type every number=0,the largest is 4. It'sconfusing! What's
wrong with my program?
---------------------------(my source
code)-------------------------------
#include<iostream>
using namespace std;
int main()
{
int counter=0;
int largest,number;

while(counter<10)
{
cout<<"Enter a Number:";
cin>>number;
if (number>largest)
largest=number;
else
largest=largest;

counter=counter+1;

}
cout<<"The largest is "<<largest<<endl;

return 0;

}- Hide quoted text -- Show quoted text -
int largest,number;
'largest' is not initialized and contains a random value which may be
greater than all your inputs . this is not pascal ,in c/c++ variables
of built in types are not automatically inititialized with zero.
furthur more i suggest the 'for' loop instead of 'while' .
you`d better replace your 'main' with this one:
int main()
{
int counter;
unsigned int number,largest=0;

for(counter=0;counter<10;counter++)
{
cout<<"Enter a Number:";
cin>>number;
if (number>largest)
largest=number;
};
cout<<"The largest is "<<largest<<endl;

return 0;
}-

Nov 19 '06 #3

br*******@gmail.com ¼g¹D¡G
When I type every number=0,the largest is 4. It'sconfusing! What's
wrong with my program?
---------------------------(my source
code)-------------------------------
#include<iostream>
using namespace std;
int main()
{
int counter=0;
int largest,number;
while(counter<10)
{
cout<<"Enter a Number:";
cin>>number;
if (number>largest)
largest=number;
else
largest=largest;
counter=counter+1;
}
cout<<"The largest is "<<largest<<endl;


return 0;
}
Nov 19 '06 #4

br*******@gmail.com ¼g¹D¡G
When I type every number=0,the largest is 4. It'sconfusing! What's
wrong with my program?
---------------------------(my source
code)-------------------------------
#include<iostream>
using namespace std;
int main()
{
int counter=0;
int largest,number;
while(counter<10)
{
cout<<"Enter a Number:";
cin>>number;
if (number>largest)
largest=number;
else
largest=largest;
counter=counter+1;
}
cout<<"The largest is "<<largest<<endl;


return 0;
}
Nov 19 '06 #5

br*******@gmail.com ¼g¹D¡G
When I type every number=0,the largest is 4. It'sconfusing! What's
wrong with my program?
---------------------------(my source
code)-------------------------------
#include<iostream>
using namespace std;
int main()
{
int counter=0;
int largest,number;
while(counter<10)
{
cout<<"Enter a Number:";
cin>>number;
if (number>largest)
largest=number;
else
largest=largest;
counter=counter+1;
}
cout<<"The largest is "<<largest<<endl;


return 0;
}
Thanks for all your help!!^ ^

Nov 19 '06 #6

terminator wrote in message ...
>

On Nov 19, 2:29 pm, bryant...@gmail.com wrote:
>When I type every number=0,the largest is 4. It'sconfusing! What's
wrong with my program?
<snip>
>
> int largest,number;
'largest' is not initialized and contains a random value which may be
greater than all your inputs . this is not pascal ,in c/c++ variables
of built in types are not automatically inititialized with zero.
furthur more i suggest the 'for' loop instead of 'while' .
you`d better replace your 'main' with this one:
int main(){
int counter;
unsigned int number,largest=0;
Note 'number'
>
for(counter=0;counter<10;counter++)
If 'counter' is not used outside the loop, just do:

for(int counter(0); counter < 10; ++counter)
{
cout<<"Enter a Number:";
cin>>number;
The user typed in 'A', 'number' is still UB.
Initialise both 'number' and 'largest'.
// unsigned int number(0), largest(0);
if (number>largest)
largest=number;
};
cout<<"The largest is "<<largest<<endl;
return 0;
}
--
Bob R
POVrookie
Nov 19 '06 #7

BobR äæÔÊå ÇÓÊ:
terminator wrote in message ...


On Nov 19, 2:29 pm, bryant...@gmail.com wrote:
When I type every number=0,the largest is 4. It'sconfusing! What's
wrong with my program?
<snip>
int largest,number;
'largest' is not initialized and contains a random value which may be
greater than all your inputs . this is not pascal ,in c/c++ variables
of built in types are not automatically inititialized with zero.
furthur more i suggest the 'for' loop instead of 'while' .
you`d better replace your 'main' with this one:
int main(){
int counter;
unsigned int number,largest=0;

Note 'number'

for(counter=0;counter<10;counter++)

If 'counter' is not used outside the loop, just do:

for(int counter(0); counter < 10; ++counter)
{
cout<<"Enter a Number:";
cin>>number;

The user typed in 'A', 'number' is still UB.
Initialise both 'number' and 'largest'.
// unsigned int number(0), largest(0);
if (number>largest)
largest=number;
};
cout<<"The largest is "<<largest<<endl;
return 0;
}

--
Bob R
POVrookie
U R write I forgot that we are using cin/cout and wrote that part in C
style .

Nov 21 '06 #8
sam

Hi ,
What you are doing is you are comparing numbe with largest.
But the
int largest=0; is the declaration.
and in for loop you are not changing the contents of it.
What you are doing is you are comparing the number with 0.
if(number>largest)
So infact in order to get the value real in largest.
you must have to constantly store big value in largest and compare it
with number.
using for loop then only will get the real largest value after 10
iterations.

Nov 21 '06 #9

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

6
by: mike | last post by:
Hello, After trying to validate this page for a couple of days now I was wondering if someone might be able to help me out. Below is a list of snippets where I am having the errors. 1. Line 334,...
5
by: John Flynn | last post by:
hi all i'm going to be quick i have an assignment due which i have no idea how to do. i work full time so i dont have the time to learn it and its due date has crept up on me .. As follows:...
0
by: xunling | last post by:
i have a question about answering ..... this topic is "need help" what do i have to write at te topic line, !after i have klicked the "answer message" button ive tried many possibilities,...
9
by: sk | last post by:
I have an applicaton in which I collect data for different parameters for a set of devices. The data are entered into a single table, each set of name, value pairs time-stamped and associated with...
7
by: Timothy Shih | last post by:
Hi, I am trying to figure out how to use unmanaged code using P/Invoke. I wrote a simple function which takes in 2 buffers (one a byte buffer, one a char buffer) and copies the contents of the byte...
15
by: Cheryl Langdon | last post by:
Hello everyone, This is my first attempt at getting help in this manner. Please forgive me if this is an inappropriate request. I suddenly find myself in urgent need of instruction on how to...
16
by: pamelafluente | last post by:
I am still working with no success on that client/server problem. I need your help. I will submit simplified versions of my problem so we can see clearly what is going on. My model: A client...
8
by: skumar434 | last post by:
i need to store the data from a data base in to structure .............the problem is like this ....suppose there is a data base which stores the sequence no and item type etc ...but i need only...
0
by: U S Contractors Offering Service A Non-profit | last post by:
Brilliant technology helping those most in need Inbox Reply U S Contractors Offering Service A Non-profit show details 10:37 pm (1 hour ago) Brilliant technology helping those most in need ...
20
by: mike | last post by:
I help manage a large web site, one that has over 600 html pages... It's a reference site for ham radio folks and as an example, one page indexes over 1.8 gb of on-line PDF documents. The site...
0
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 6 Mar 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, we are pleased to welcome back...
0
by: Vimpel783 | last post by:
Hello! Guys, I found this code on the Internet, but I need to modify it a little. It works well, the problem is this: Data is sent from only one cell, in this case B5, but it is necessary that data...
0
by: jfyes | last post by:
As a hardware engineer, after seeing that CEIWEI recently released a new tool for Modbus RTU Over TCP/UDP filtering and monitoring, I actively went to its official website to take a look. It turned...
0
by: ArrayDB | last post by:
The error message I've encountered is; ERROR:root:Error generating model response: exception: access violation writing 0x0000000000005140, which seems to be indicative of an access violation...
1
by: CloudSolutions | last post by:
Introduction: For many beginners and individual users, requiring a credit card and email registration may pose a barrier when starting to use cloud servers. However, some cloud server providers now...
1
by: Defcon1945 | last post by:
I'm trying to learn Python using Pycharm but import shutil doesn't work
1
by: Shællîpôpï 09 | last post by:
If u are using a keypad phone, how do u turn on JavaScript, to access features like WhatsApp, Facebook, Instagram....
0
by: Faith0G | last post by:
I am starting a new it consulting business and it's been a while since I setup a new website. Is wordpress still the best web based software for hosting a 5 page website? The webpages will be...
0
isladogs
by: isladogs | last post by:
The next Access Europe User Group meeting will be on Wednesday 3 Apr 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM). In this session, we are pleased to welcome former...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.