after assistance with Visual c++, multiple file redeclaration

[treegum]

Hi,

I am trying to compile my code from several small files, as it was getting unweildly in a large file.

I have simplified my problem somewhat, and if I could solve this example the rest may flow. (or I'll get into deeper water!) This is Visual c++ 2005 express edition.

file 1: aaa.hpp

#ifndef AAA_H
#define AAA_H
#pragma once
 
class aaa {
public:
    aaa(char *str);
    void setFile(char *str );
    int record_count() ;
private:
    char filename[256];    //  filename of the data file for the data
    int numrecords;
} ;
 
#endif
 
 

file 2: aaa.cpp

#include "aaa.hpp"
 
class aaa {
public:
    aaa(char *str) {
        //  Constructor
        std::cout << "\n\n----------\nData for:" << filename << "\n" ;
    } ;
    void setFile(char *str) {
        strcpy_s( filename, str );  //  store main directory
    } ;
    int record_count() {
        return numrecords ;
    } ;
private:
    char filename[256];    //  filename of the data file for the data
    int numrecords;
} ;
 
 

When I select aaa.cpp in the IDE, right click and select compile I get:

Compiling...
class aaa.cpp
.\class aaa.cpp(17) : error C2011: 'aaa' : 'class' type redefinition
 c:\documents and settings\fred\my documents\visual studio 2005\projects\testing classes\testing classes\aaa.hpp(5) : see declaration of 'aaa'

So far I have written my application nicely in a big file, and am referring to my books here at home to check on the content of the header file in case I have mucked up my definitions, but there is not a lot of info I can find to narrow it down.

Any assistance greatfully accepted,
Thanks,
Treegum

[treegum]

more information.
to try an simpl
ify my code a bit, I removed the variousother #include from aaa.cpp. I seem to be able to get a relatively simple aaa.hpp working when I so the following:

 #ifndef AAA_H
#define AAA_H
#pragma once
class aaa ;
#endif

So I figure I am doing my declarations incorrectly, but as soon as I add the {} to put anything after the class name, I get the redefinition error.

thanks for any suggestions,
Treegum

[Banfa]

file 2: aaa.cpp

#include "aaa.hpp"
 
class aaa {
public:
    aaa(char *str) {
        //  Constructor
        std::cout << "\n\n----------\nData for:" << filename << "\n" ;
    } ;
    void setFile(char *str) {
        strcpy_s( filename, str );  //  store main directory
    } ;
    int record_count() {
        return numrecords ;
    } ;
private:
    char filename[256];    //  filename of the data file for the data
    int numrecords;
} ;
 
 

In this file you have redeclared class aaa

class aaa {

You just need to define it's member functions

#include "aaa.hpp"
 
aaa::aaa(char *str) {
    //  Constructor
    std::cout << "\n\n----------\nData for:" << filename << "\n" ;
}
 
void aaa::setFile(char *str) {
    strcpy_s( filename, str );  //  store main directory
}
 
int aaa::record_count() {
    return numrecords ;
}
 

[treegum]

Thanks for this... which is somewhere I got to before which gave me a different error, so I figured I was going in the wrong direction...?

file 1: aaa.hpp

#ifndef AAA_H
#define AAA_H
#pragma once
 
class aaa {
public:
    aaa(char *);
    void setFile(char *);
    int record_count() ;
private:
    char filename[256];    //  filename of the data file for the data
    int numrecords;
}
 
#endif

and file 2: aaa.cpp

#include "aaa.hpp"
 
    aaa::aaa(char *str) {
        //  Constructor
        std::cout << "\n\n----------\nData for:" << filename << "\n" ;
    } ;
    void aaa::setFile(char *str) {
        strcpy_s( filename, str );  //  store main directory
    } ;
    int aaa::record_count() {
        return numrecords ;
    } ;

however now I get another error...

 Compiling...
class aaa.cpp
c:\documents and settings\u448467\my documents\visual studio 2005\projects\testing classes\testing classes\aaa.hpp(11) : error C2071: 'aaa::filename' : illegal storage class
.\class aaa.cpp(19) : error C2533: 'aaa::{ctor}' : constructors not allowed a return type

and if I compile it without 'aaa::aaa(){}', and just aaa(){}... ut I'll get to that shortly...
so, should I be using aaa::aaa(){} for a constructor, or aaa(){}?

Thanks,
treegum

[treegum]

Well thanks for the assistance banfa. I did a typo which resulted in my error in the last post. I am all good now, and your answer was quite correct (but I'm sure you knew that ;)

Cheers,
treegum