Password challenge

[chiefs]

C++ Code:
Help!!! Problem:

>>goto Password 1:

Enter pw1 & pw2
-Program only evaluates first character
-How can I evaluate all characters entered!!
-If first letter same >> "Good Match"
-If all char's are the same >> "Passwords don't match, Try Again"

What is the Answer to evaluating all characters @ one time?????


# include <iostream.h>
# include <stdio.h>
# include <string.h>

main()
{

char name[30];
int n;
int r;
char a;
int q;
char pw1;
char pw2;

printf ("What is your name?");
scanf ("%s", &name);
printf ("High (%s)\n\n", name);
printf ("Is this correct?");
scanf ("%s", &a);
if ((a == 'y') || (a == 'Y'))
goto PASS_WORD1;
else
goto NAME_1;

NAME_1:
printf ("Please Re-enter name!");
scanf("%s",&name);
printf ("Okay, %s\n\n", &name);
goto PASS_WORD1;

PASS_WORD1:

printf ("Please enter a password to feed your data into the system!!\n",&pw1);
scanf ("%s", &pw1);
printf ("Please Enter same password again for security reasons\n",&pw2);
scanf ("%s", &pw2);
if (pw1 == pw2)
{printf ("Good match, (%S) ...\n", &name);
goto QUESTION_1;}
else
{ printf ("Passwords don't match, Try again (%s) @@@\n", &name);
goto PASS_WORD2;

PASS_WORD2:
printf ("Please enter a password to feed your data into the system!!\n",&pw1);
scanf ("%s", &pw1);
printf ("Please Enter same password again for security reasons\n",&pw2);
scanf ("%s", &pw2);
if (pw1 != pw2)
{ printf ("Passwords don't match, consider remembering in your head\n");}
goto END_NOTEST;


QUESTION_1:
printf ("Please enter the Number of Questions you would like between (1-50) ?\n");
scanf ("%s", &q);

if ((q >= '1') && (q <= '50'))
{ printf ("Get Ready,(%s), !!!!!!\n",&name);
goto START_TEST;}

else
{ printf ("Invalid Entry, Try Again!!\n");
scanf ("%s", &q);}
if ((q >= '1') && (q <= '50'))
{ printf ("Finally, (%s), it took you long enough,!!!\n", &name);
goto START_TEST;}

else
{ goto END_NOTEST;

return 0;

START_TEST:

printf ("\nWelcome to the First Multiple Choice Test\n");
printf ("Created by Jonathan J. Soard, Oct 06");

END_NOTEST:
printf ("Bye Bye (%s), Better Luck next time\n", &name);
return 0;}
}
}

[Banfa]

To start with if you want to store a password of more than 1 character then you should declare pw1 and pw2 as having more than 1 character, you need to declare arrays. Has you currently have it if the user enters passwords of more than 1 character you write to unallocated memory and invoke undefined behaviour.

Also in modern program using goto is usually frowned upon, I think it would be especially frowned upon in the way you have used it since a lot of them are completely unrequired if you made proper use of code blocks after if statements.

Finally if you want to compare 2 string use the function

int strcmp ( const char * string1, const char * string2 );

declared in string.h

[chiefs]

To start with if you want to store a password of more than 1 character then you should declare pw1 and pw2 as having more than 1 character, you need to declare arrays. Has you currently have it if the user enters passwords of more than 1 character you write to unallocated memory and invoke undefined behaviour.

Also in modern program using goto is usually frowned upon, I think it would be especially frowned upon in the way you have used it since a lot of them are completely unrequired if you made proper use of code blocks after if statements.

Finally if you want to compare 2 string use the function

int strcmp ( const char * string1, const char * string2 );

declared in string.h

I'm new to the Programming arena, please elaborate on what you mean by declaring the char in array and allocating more space for the char's to be read.

Do you mean by declaring the char in an array like this

char pw1[8];
char pw2[8];

How about allocating enough space for the char's, what would be the line coding for this?

[chiefs]

I'm only trying to get a result that is True with correct Input!!

With these statements, after Confirm>>Comes back Good even if put different characters. If I make the If statement: if (pw1 == pw2)
Answer always comes back "No Good".
What would you suggest to fix the Incorrect Response?????

Possibly- add an algorithm to test each character and space it should work.
- loop with counter to test each character entered (Verify in reverse
order if correct sequence for both pw1 & pw2 Valid

After this, I plan on working on storing the name and password in a excel file with the password encrypted (Algorithm) then work on the question, scores, average, so fourth & so on!!

Right now I'm at 50/50

# include <iostream.h>
# include <stdio.h>
# include <string.h>

main()
{

char pw1[8];
char pw2[8];

PASS_WORD1:
printf ("Enter your 8 character password\n");
scanf ("%s", &pw1);
printf ("Confirm!!\n ");
scanf ("%s", &pw2);
if (pw1 != pw2)
{printf("Good");
goto QUESTION_1;}
else
{printf("No Good");
goto PASS_WORD1;}

QUESTION_1:

}

[arne]

I'm only trying to get a result that is True with correct Input!!

With these statements, after Confirm>>Comes back Good even if put different characters. If I make the If statement: if (pw1 == pw2)
Answer always comes back "No Good".
What would you suggest to fix the Incorrect Response?????

Possibly- add an algorithm to test each character and space it should work.
- loop with counter to test each character entered (Verify in reverse
order if correct sequence for both pw1 & pw2 Valid

After this, I plan on working on storing the name and password in a excel file with the password encrypted (Algorithm) then work on the question, scores, average, so fourth & so on!!

Right now I'm at 50/50

Try

if( strcmp(pw1, pw2) == 0 )
 

instead of your if statement (your code doesn't compare the strings, but the addresses).

[Banfa]

Please don't double post.