Hello All,
i'm currently working on a program wich asks the user to input an integer value of "n" to determine what value of the denominator in an equation for PI to work to.
this is written in c, and I have all the basic input, output, function calls etc; however, i'm relatively new to c and i'm a bit confused on how to turn the equation below into a c expression with variable input.
PI = 4(1 + 1/3 - 1/5 + 1/7 etc... (where int n is the value of the denominator to continue to)
anyone able to help? Thanks a lot!
7 4883 Banfa 9,065
Expert Mod 8TB
The thing that changes about that equation is the denominator, also remember that
PI = 4(1 + 1/3 - 1/5 + 1/7 ...) = 4 + 4/3 - 4/5 + 4/7 ...)
also I think you have you pluses and minuses the wrong way round it should be
PI = 4(1 - 1/3 + 1/5 - 1/7 ...) = 4 - 4/3 + 4/5 - 4/7 ...)
So you need a (for) loop controling the denominator. Then have a variable that is initialised to zero and for each iteration of the loop add (or subtract) another term of the series -
INITIALISE PI to 0
-
FOR NUMBER OF SERIES TERMS REQUIRED
-
ADD SERIES TERM TO PI
-
END FOR
-
my bad on the +'s and -'s that was simply a typo...
so if i was to write a for loop something like
int PI;
int n; //number of iterations
int den_val; //denominator value
for(PI = 0; n > den_val; PI += den_val) {
/*code*/
}
and assuming that is correct, i'm still a little confused on how to incorporate the equation into the loop. I understand the 4 - 4/3 + 4/5 etc... but i'm not quite sure how to tie that into the loop and have the the +'s and -'s alternating.
i hope that makes sense, and i appreciate your help.
Banfa 9,065
Expert Mod 8TB
You loop is not quite right, also remember PI is 3.141...., try and store it in a int and it will be 3. Your loop control variable should be an int but you will need to calculate PI as a double value.
The = and - are easy, just have a boolean variable (are you using C or C++?) to maintain an indication of what to do with the next term, also note that 1 = 1/1 -
GET NUMBER OF TERMS REQUIRED nTerm
-
SET ADD = TRUE
-
SET PI = 0
-
-
FOR EACH REQUIRED TERM
-
IF ADD == TRUE
-
SET PI = PI + VALUE OF TERM
-
SET ADD = FALSE
-
ELSE
-
SET PI = PI - VALUE OF TERM
-
SET ADD = TRUE
-
END FOR
-
-
PRINT PI
-
Note that the nth term of the series has the value 4/(n*2-1), verify this for yourself.
i'll give that a whirl, i see what you're getting at
i'm coding in standard C
i appreciate the help!
so here is what i've come up with...
it seems to me like it should execute correctly, but somewhere something is causing my output to be bogus large numbers; however, it will compile... does anyone see my error?
any help will be appreciated! -
#include<stdio.h>
-
-
void pi(int n, double *pi_value, int *iterations); //declare function
-
-
int main (void)
-
{
-
int n; //number of terms
-
int iterations; //number of actual loop iterations in pi
-
double pi_value; //computed value of pi
-
-
printf("Please enter an odd integer n; ")'
-
printf("quit with a non-positive or even integer:\n");
-
-
/*-- Read n and display pi. Quit with a non-positive n. --*/
-
scanf("%d", &n);
-
while(n>0 && n%2)
-
{
-
pi(n, &pi_value, &iterations);
-
printf("%17d: %0.81f with %d iterations\n", n, pi_value, iterations);
-
scanf("%d", &n);
-
}
-
-
return(0);
-
}
-
-
voi pi(int n, double *pi_value, int *iterations)
-
{
-
int i;
-
int ADD = 1 // 1 = true & 2 = false
-
-
for(i=0; i<n; i++)
-
{
-
pi_value += (4/((n*2)-1));
-
ADD = 2;
-
break;
-
}
-
for(ADD == 2)
-
{
-
pi_value -= (4/((n*2)-1));
-
ADD = 1;
-
break;
-
}
-
(*iterations)++
-
}
-
-
please ignore the code from my previous post, i typed it in a rush and realized it had many glaring syntax errors, try this one instead... -
#include<stdio.h>
-
-
void pi(int n, double *pi_value, int *iterations); //declare function
-
-
int main (void)
-
{
-
int n; //number of terms
-
int iterations = 0; //number of actual loop iterations in pi
-
double pi_value = 0; //computed value of pi
-
-
printf("Please enter an odd integer n; ")'
-
printf("quit with a non-positive or even integer:\n");
-
-
/*-- Read n and display pi. Quit with a non-positive n. --*/
-
scanf("%d", &n);
-
while(n>0 && n%2)
-
{
-
pi(n, &pi_value, &iterations);
-
printf("%17d: %0.81f with %d iterations\n", n, pi_value, iterations);
-
scanf("%d", &n);
-
}
-
-
return(0);
-
}
-
-
void pi(int n, double *pi_value, int *iterations)
-
{
-
int i;
-
int ADD = 1 // 1 = true & 2 = false
-
-
for(i=0; i<n; i++)
-
{
-
switch(ADD)
-
{
-
case 1:
-
*pi_value += (4/((n*2)-1));
-
ADD = 2;
-
break;
-
case 2:
-
*pi_value -= (4/((n*2)-1));
-
ADD = 1;
-
{ break;
-
}
-
(*iterations)++;
-
}
-
Banfa 9,065
Expert Mod 8TB
You have 5 errors (ignoreing the minor syntax errors you posted, once you have compiling code copy and paste is a good way to get it to the forum posting box).
They are all in this section of code, I am going to tell you about 4 of them. Once I have done this you should be able to find the other one by running your program. -
void pi(int n, double *pi_value, int *iterations)
-
{
-
int i;
-
int ADD = 1; // 1 = true & 2 = false
-
-
for(i=0; i<n; i++)
-
{
-
switch(ADD)
-
{
-
case 1:
-
*pi_value += (4/((n*2)-1));
-
ADD = 2;
-
break;
-
case 2:
-
*pi_value -= (4/((n*2)-1));
-
ADD = 1;
-
{ break;
-
}
-
(*iterations)++;
-
}
-
On a point of style it is slightly more normal to use the value 0 for false but your use of 2 does not stop the program working. -
This doesn't stop the program working but I suspect it does make it so that it is not doing what you think it is doing. Note n is always odd, making me think you were asking for the highest term denominator to use, however this loop uses it as the number. Does the series always require an odd number of terms or would it work with an even number? Actually this series works with any number of terms > 0. If n = 7 the text message give the impression of creating this series
PI = 4(1 - 1/3 + 1/5 - 1/7)
but the code actually evaluates this
PI = 4(1 - 1/3 + 1/5 - 1/7 + 1/9 - 1/11 + 1/13)
Decide if you want to input the number of terms (change text but the loop stays the same) or the value of the maximum denominator (change loop, possible change text to to make it clear what is being input). -
You have put it outside the loop, it only ever executes once for each function call, with the current loop it will always end up equal to n.
-
- *pi_value -= (4/((n*2)-1));
You have used the variable n, this is the number of terms to use, not the current term. You need tobase the calculation on the variable i which is the one that changes. But note a straight swop will not work because the initial value of i is 0. You have (correctly) used the formula for the xth term 4 / ((x*2)-1), so the first term is 4 / ((1*2)-1), but your control variable value does not start at 1 ir starts at 0, you need to add 1 to it 4 / (((i+1)*2)-1), a little algibra will so that this is equal to 4 / ((i*2)+1) -
- *pi_value -= (4/((i*2)+1));
*pi_value is a floating point type but i (or n) are int and 4, 2 and 1 are integer constants.. The calculation is done in integer arithmatic and then converted to a double. In integer arithmatic all decimal places are dropped, the first term evaluates to 4/1=4 the second to 4/3=1 and all further terms evaluate to 0 giving a result of 3. You need to force the compiler to use floating point arithmatic.
You can either cast the controlling variable to double - *pi_value -= (4/(((double)i*2)+1));
Using floating point constants instead of integer constants - *pi_value -= (4./((i*2.)+1.));
Like I said there is 1 more error, see if you can find it (hint try 2 calculations in a row).
And finally 1 more point of style - printf("%17d: %0.81f with %d iterations\n", n, pi_value, iterations);
A double only has a precision of 15 decimal places, asking it for 81 is wishful thinking, also if you don't want a field width just don't specify one, no need to set it to 0 so this line would be better as - printf("%17d: %.15f with %d iterations\n", n, pi_value, iterations);
You can test this, set the 15 to a 16, the last digit will always be 0
Sign in to post your reply or Sign up for a free account.
Similar topics
by: Sven Dzepina |
last post by:
Hello people =)
Has somebody a nice script, which can solve equations ?
It would be super, if someone has an idea where I can get such a script /
code in php.
Thanks.
Gretting!
|
by: Russell Blau |
last post by:
This is not really a Python question, but it does relate to a Python program
I'm working on, so this seems like as good a place as any to ask for
suggestions ...
I'm working on a GUI application...
|
by: Brian Kazian |
last post by:
Here's my problem, and hopefully someone can help me figure out if there is
a good way to do this.
I am writing a program that allows the user to enter an equation in a text
field using...
|
by: Stud Muffin |
last post by:
Hey
Basically, I'm trying to take objects created in microsoft word using
equation editor (for creating clean looking math/physics equations)
and putting them into some sort of webpage format....
|
by: w33nie |
last post by:
My table is pretty well complete, but I would prefer it if the value for Points could be turned into a mathematical equation,
and this equation would use the data from the other fields in the table...
|
by: Trev17 |
last post by:
Hello, I am new to C++ and i have tried for several hours to make a program my teacher has given me as a lab. Here is the Lab question:
the roots of the quadratic equation ax^2 + bx + c = 0, a...
|
by: Constantine AI |
last post by:
Hi i am having a little problem with an equation function that was created from all your help previously. The function works fine itself but with a small glitch within it.
Here is the function...
|
by: phoenix1990 |
last post by:
so i have an entry frame where i want to input an equation, and i need to turn the string into an actual equation in terms of x. so that i can plot it on a canvas.
i already know how to make the...
|
by: prashantdixit |
last post by:
Hi,
I am trying to generate Linear Trendline Equation for a graph using VBA in Excel 2007.
I am able to do it. However It always generate trendline equation in "General" Format.
And i want to...
|
by: Charles Arthur |
last post by:
How do i turn on java script on a villaon, callus and itel keypad mobile phone
|
by: emmanuelkatto |
last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud.
Please let me know.
Thanks!
Emmanuel
|
by: nemocccc |
last post by:
hello, everyone, I want to develop a software for my android phone for daily needs, any suggestions?
|
by: Hystou |
last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can...
|
by: Oralloy |
last post by:
Hello folks,
I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>".
The problem is that using the GNU compilers,...
|
by: jinu1996 |
last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven...
|
by: tracyyun |
last post by:
Dear forum friends,
With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each...
|
by: agi2029 |
last post by:
Let's talk about the concept of autonomous AI software engineers and no-code agents. These AIs are designed to manage the entire lifecycle of a software development project—planning, coding, testing,...
|
by: isladogs |
last post by:
The next Access Europe User Group meeting will be on Wednesday 1 May 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM).
In this session, we are pleased to welcome a new...
| |