rejecting an non numberic input in C

[rwise5]

I was given the following code

char line[MAXLINE];
int error, n;

do {
printf("Input a positive integer: ");
fgets(line, MAXLINE, stdin);
error = sscanf(line, "%d", &n) != 1 || n <= 0;
if (error)
printf("\nERROR: Do it again.\n");
} while (error);


The preceding code works well, but if you input a letter vice a number say for example 22e instead of 223, it should should reject 22e.

I have tried assert, but am not sure that is the correct way to go.

I have even tried int isalpha(int c);

but the way I used it only checked the first character in the string.

Please if anyone could suggest what type of programming to use it would be helpful.
Thank you in advance.

[ltgbau]

scan input as string then check if exists any non-numeric character
if exists then reject, otherwise accept

[rwise5]

scan input as string then check if exists any non-numeric character
if exists then reject, otherwise accept

What do I scan a string with to determine if it is acceptable or not?

[Banfa]

The function

int isdigit(int c);

will return non-zero if the character passed to it is a digit otherwise it returns 0

Loop down your string and check each character of the string individually.

[rwise5]

The function

int isdigit(int c);

will return non-zero if the character passed to it is a digit otherwise it returns 0

Loop down your string and check each character of the string individually.

Thank you I will try what you suggested, I am hoping that I can get it to work without throwing my computer through a wall.
Thank you again.

[rwise5]

Here is what I am thinking about trying....

char line[MAXLINE];
int error, n;

do {
printf("Input a positive integer: ");
fgets(line, MAXLINE, stdin);
error = sscanf(line, "%d", &n) != 1 || n <= 0;
if (error)
printf("\nERROR: Do it again.\n");
for (i = 0; *n != '\0'; n++)}
if (isdigit(*n))
error;}
} while (error);

Does this look like I am thinking correctly.
Thank you.

[Banfa]

OK here are my comments

do {
  printf("Input a positive integer: ");
  fgets(line, MAXLINE, stdin);
 
 /* all the scanf family of functions are best avoided if possible
   they just cause problems */
  error = sscanf(line, "%d", &n) != 1 || n <= 0; [b]
 
  if (error)
    printf("\nERROR: Do it again.\n");
 
 /* you are attempting to use an int (n) as a pointer this will not work
   you need to call isdigit on the characters of the string (line) */
  for (i = 0; *n != '\0'; n++)}
 /* Statmement makes no sense because error; does nothing (but is compilable)
   In this kind of test you need to assume it passes at the start and set 
   an error flag if it fails but your if statement tests for the success condition */
    if (isdigit(*n)){
    error;}
} while (error);
 

You are along the right lines but not quite there yet. You will need a variable of type char * to point at line in order to call isdigit with. Once you have done this rather than call sscanf I would call atoi.

Of course now I think about it during daytime instead of the middle of the night I wouldn't bother with sscanf, isdigit and a loop I would just use strtol which will convert the string to an integer and test for errors at the same time.

[rwise5]

OK here are my comments

do {
  printf("Input a positive integer: ");
  fgets(line, MAXLINE, stdin);
 
 /* all the scanf family of functions are best avoided if possible
   they just cause problems */
  error = sscanf(line, "%d", &n) != 1 || n <= 0; [b]
 
  if (error)
    printf("\nERROR: Do it again.\n");
 
 /* you are attempting to use an int (n) as a pointer this will not work
   you need to call isdigit on the characters of the string (line) */
  for (i = 0; *n != '\0'; n++)}
 /* Statmement makes no sense because error; does nothing (but is compilable)
   In this kind of test you need to assume it passes at the start and set 
   an error flag if it fails but your if statement tests for the success condition */
    if (isdigit(*n)){
    error;}
} while (error);
 

You are along the right lines but not quite there yet. You will need a variable of type char * to point at line in order to call isdigit with. Once you have done this rather than call sscanf I would call atoi.

Of course now I think about it during daytime instead of the middle of the night I wouldn't bother with sscanf, isdigit and a loop I would just use strtol which will convert the string to an integer and test for errors at the same time.

I have researched strtol function and I see no way to check to see if the string is digital or alpha.

I have been thinking maybe I need to be using pointers. ??

do {
printf("Input a positive integer: ");
fgets(line, MAXLINE, stdin);

for (p = line; *p != '\0'; ++p){
if (!isalpha(*p))
error;}
if (error)
printf("\nERROR: Do it again.\n");
} while (error);


I need to work out the Ivalue s and such, tell me what you think.
Thank you.

[Banfa]

I have researched strtol function and I see no way to check to see if the string is digital or alpha.

Use strtol to convert the string to an integer, the character that EndPtr ends up pointing to should be the string terminator '\0'.

If it isn't then there is an error

Alternitively if it isn't but the rest of the string is white space then there is not an error

char *pEnd;
long l;
char test[] = "1234";
 
l = strtol(test, &pEnd, 10);
 
if (*pEnd != '\0')
{
  // error
}
 

[rwise5]

Use strtol to convert the string to an integer, the character that EndPtr ends up pointing to should be the string terminator '\0'.

If it isn't then there is an error

Alternitively if it isn't but the rest of the string is white space then there is not an error

char *pEnd;
long l;
char test[] = "1234";
 
l = strtol(test, &pEnd, 10);
 
if (*pEnd != '\0')
{
  // error
}
 

I couldn't get your suggestion to work. I went back to the pointer function and I figure out what was wrong with the I value.

char *p = line; // This was what I had to get correct or I was stuck

do {
printf("Input a positive integer: ");
fgets(line, MAXLINE, stdin);

for (p = line; *p != '\0'; ++p){
if (!isalpha(*p))
error;}
if (error)
printf("\nERROR: Do it again.\n");
} while (error);

I would like to thank everyone who help me think this out.
Thanks.