473,320 Members | 1,863 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,320 software developers and data experts.

Help in OOP

Hi guys

I am not good OOP programmer ,trying to implement my already working
code in OOP.

I have somthing like this class.

class Datalogger{
public:
UINT Port;
BOOL bReady ;

Datalogger (UINT x ,bool y);
~Datalogger ();

bool LOpen ();
bool LStatus ();

};
Everything is OK till "bool LStatus ();"

bool LStatus ()
{
...... Here I have bunch of stuff;
but I get problem here

Waitforevent( Port , INFINTE , &bReady)
if(bReady)
{
.......
.....some stuff ;
.......

}
}
Where "Waitforevent" is fucntion came with driver of my I/O board .I
did not make this function.
it gives
bReady= true on events.

My question is that "CAN I USE member variable like this"
I means Can I use address of member variable to some function.

May 19 '06 #1
13 1387
vsrajput wrote:
I am not good OOP programmer ,trying to implement my already working
code in OOP.
If that's just a learning thing that's cool. Don't do that on the job
because you shouldn't spend too much time changing code that already works.
I have somthing like this class.

class Datalogger{
public:
UINT Port;
BOOL bReady ;
Does anything assign bReady?

What did the following code look like before you OOP-ed it?
Waitforevent( Port , INFINTE , &bReady)
if(bReady) Where "Waitforevent" is fucntion came with driver of my I/O board .I
did not make this function.
it gives
bReady= true on events.
Try adding this to the constructor:

Datalogger::Datalogger(UINT x ,bool y): bReady(false) {}
My question is that "CAN I USE member variable like this"
I means Can I use address of member variable to some function.


Yes, because the variable lives longer than the call to Waitforevent().
However, your variable might now contain garbage, and Waitforevent() might
read bReady's value and expect true or false.

--
Phlip
http://c2.com/cgi/wiki?ZeekLand <-- NOT a blog!!!
May 19 '06 #2
vs******@gmail.com wrote:
I have somthing like this class.

class Datalogger{
public:
UINT Port;
BOOL bReady ;

Datalogger (UINT x ,bool y);
~Datalogger ();

bool LOpen ();
bool LStatus ();

};
Everything is OK till "bool LStatus ();"

bool LStatus ()
{
..... Here I have bunch of stuff;
but I get problem here

Waitforevent( Port , INFINTE , &bReady)
if(bReady)
{
......
....some stuff ;
......

}
}
Where "Waitforevent" is fucntion came with driver of my I/O board .I
did not make this function.
it gives
bReady= true on events.

My question is that "CAN I USE member variable like this"
I means Can I use address of member variable to some function.


Sure. What's the problem you're encountering?

V
--
Please remove capital 'A's when replying by e-mail
I do not respond to top-posted replies, please don't ask
May 19 '06 #3
vs******@gmail.com wrote:
Hi guys

I am not good OOP programmer ,trying to implement my already working
code in OOP.

I have somthing like this class.

class Datalogger{
public:
UINT Port;
BOOL bReady ;

Datalogger (UINT x ,bool y);
~Datalogger ();

bool LOpen ();
bool LStatus ();

};
Everything is OK till "bool LStatus ();"

bool LStatus ()
{
..... Here I have bunch of stuff;
but I get problem here

Waitforevent( Port , INFINTE , &bReady)
if(bReady)
{
......
....some stuff ;
......

}
}
Where "Waitforevent" is fucntion came with driver of my I/O board .I
did not make this function.
it gives
bReady= true on events.

My question is that "CAN I USE member variable like this"
I means Can I use address of member variable to some function.


Yes you can...

....but in this case why? From what you have written, it looks like it
might be better if bReady was a local variable of LStatus(). Unless you
need to use the value in bReady somewhere else...

Dave

May 19 '06 #4
Hi guys ,

Thanks for your reply

Actually I want to use bReady in both member functions LStatus and
LOpen.

Thats why I didnt define bReady as local variable in LStatus.

But I solved my problem from ur suggestion.
What I did is follow.

bool LStatus ()
{
bool bbReady ; // defined one local variable
bbReady = bReady

Waitforevent( Port , INFINTE , &bbReady)
if(bbReady)
{
.......
.....some stuff ;
.......

}
}
Now everything is fine.
But I didnt understand why is this happing ,why cant I directly use
class member variable inside LStatus.
and If I make another copy of that variable inside LStatus ,then its
fine ??
Can anyone explain to me ??

May 19 '06 #5
vs******@gmail.com wrote:
Actually I want to use bReady in both member functions LStatus and
LOpen.

Thats why I didnt define bReady as local variable in LStatus.

But I solved my problem from ur suggestion.
What I did is follow.

bool LStatus ()
{
bool bbReady ; // defined one local variable
bbReady = bReady
There is no need in a separate assignment. Initialise!

bool bbReady = bReady;

Waitforevent( Port , INFINTE , &bbReady)
if(bbReady)
{
......
....some stuff ;
......

}
}
Now everything is fine.
But I didnt understand why is this happing ,why cant I directly use
class member variable inside LStatus.
You can. Who said you couldn't?
and If I make another copy of that variable inside LStatus ,then its
fine ??
What's the difference now? Did you have any problem before?
Can anyone explain to me ??


Explain what?

V
--
Please remove capital 'A's when replying by e-mail
I do not respond to top-posted replies, please don't ask
May 19 '06 #6
Yeah I understand i didnt need to do it in two statement. I can
initialise with declaration.

now my question is that i have a class .
class Datalogger{
public:
UINT Port;
BOOL bReady ;
Datalogger (UINT x ,bool y);
~Datalogger ();
bool LOpen ();
bool LStatus ();
};

Datalogger::Datalogger(UINT x ,bool y){
Port = x;
bReady=y;}

Datalogger::LOpen(){

.....
.....
// it is also using bReady and Port and doing other stuff
....
}

Datalogger::LStatus()
{
//it is also using bReady and Port in following manner.
Waitforevent( Port , INFINTE , &bReady) // waitforevent is a function
come with I/O driver
// It waits
for event and on event it makes bReady=true;
if(bReady)
{
.......
.....some stuff ;
.......
}
}

But if I am using bReady in this manner ,it gives in run time error and
program crashes.

May 19 '06 #7
Yeah I understand i didnt need to do it in two statement. I can
initialise with declaration.

now my question is that i have a class .
class Datalogger{
public:
UINT Port;
BOOL bReady ;
Datalogger (UINT x ,bool y);
~Datalogger ();
bool LOpen ();
bool LStatus ();
};

Datalogger::Datalogger(UINT x ,bool y){
Port = x;
bReady=y;}

Datalogger::LOpen(){

.....
.....
// it is also using bReady and Port and doing other stuff
....
}

Datalogger::LStatus()
{
//it is also using bReady and Port in following manner.
Waitforevent( Port , INFINTE , &bReady) // waitforevent is a function
come with I/O driver
// It waits
for event and on event it makes bReady=true;
if(bReady)
{
.......
.....some stuff ;
.......
}
}

But if I am using bReady in this manner ,it gives in run time error and
program crashes.

May 19 '06 #8

vs******@gmail.com wrote:
Hi guys ,

Thanks for your reply

Actually I want to use bReady in both member functions LStatus and
LOpen.

Ok, that's fine. Then you don't need the local variable.
But I didnt understand why is this happing ,why cant I directly use
class member variable inside LStatus.


You can. There is no problem there.

Dave.

May 19 '06 #9
vsrajput wrote:
Thanks for your reply
Does bReady contain garbage or did you make sure it's assigned correctly?
Actually I want to use bReady in both member functions LStatus and
LOpen.
Does it convey a value between those two functions?

Never re-use a variable for a separate purpose, and never "prematurely
optimize". Making the variable a member won't make it faster or anything.
Just make it local.
bool LStatus ()
{
bool bbReady ; // defined one local variable
bbReady = bReady
You are missing a ;. This suggests you are not copying and pasting code into
your editor. Copying will be more accurate.
Waitforevent( Port , INFINTE , &bbReady) Now everything is fine.
But I didnt understand why is this happing ,why cant I directly use
class member variable inside LStatus.
You can. Something else is going on. Does Waitforevent() store the address
of its argument so something can use it later, after the Waitforevent()
returns?
and If I make another copy of that variable inside LStatus ,then its
fine ??
Can anyone explain to me ??


Not with the current information. You probably still have undefined
behavior. That means anything could happen, including the program appears to
work correctly.

Specifically, using the & could lead to memory corruption. However, some
corruption doesn't crash a program immediately.

Write a unit test that stresses your class, and Waitforevent(), and if you
are still corrupting memory, calling the unit test many times may reveal the
corruption. However, it may reveal as a crash far from the source of your
bug.

--
Phlip
http://c2.com/cgi/wiki?ZeekLand <-- NOT a blog!!!
May 19 '06 #10
vs******@gmail.com wrote:
Yeah I understand i didnt need to do it in two statement. I can
initialise with declaration.
Please use quoting when replying. It is useful [for others] to
see what you're replying to.
now my question is that i have a class .
class Datalogger{
public:
UINT Port;
BOOL bReady ;
Why are those data members public, BTW?
Datalogger (UINT x ,bool y);
~Datalogger ();
bool LOpen ();
bool LStatus ();
};

Datalogger::Datalogger(UINT x ,bool y){
Port = x;
bReady=y;}
Prefer initialisation over assignment. See FAQ about that.

Datalogger::LOpen(){
bool Datalogger::LOpen(){

....
....
// it is also using bReady and Port and doing other stuff
...
}

Datalogger::LStatus()
bool Datalogger::LStatus()
{
//it is also using bReady and Port in following manner.
Waitforevent( Port , INFINTE , &bReady) // waitforevent is a function
come with I/O driver
// It waits
for event and on event it makes bReady=true;
OK.
if(bReady)
{
......
....some stuff ;
......
}
}

But if I am using bReady in this manner ,it gives in run time error
and program crashes.


Are you sure you're calling it for a valid object? What's the "this"
value in that function? How do you call this function?

V
--
Please remove capital 'A's when replying by e-mail
I do not respond to top-posted replies, please don't ask
May 19 '06 #11
vsrajput wrote:
Yeah I understand i didnt need to do it in two statement. I can
initialise with declaration.
Please include the replied-to text. Google makes this possible with
Reply->Preview->Edit. (Without that sequence, Google optimizes your post for
their viewer program, which not everyone uses.)
Datalogger::Datalogger(UINT x ,bool y){
Port = x;
bReady=y;}


Okay. Post the code that calls Datalogger.

--
Phlip
http://c2.com/cgi/wiki?ZeekLand <-- NOT a blog!!!

May 19 '06 #12
vs******@gmail.com wrote:
Yeah I understand i didnt need to do it in two statement. I can
initialise with declaration.

now my question is that i have a class .
class Datalogger{
public:
UINT Port;
BOOL bReady ;
Datalogger (UINT x ,bool y);
~Datalogger ();
bool LOpen ();
bool LStatus ();
};

Datalogger::Datalogger(UINT x ,bool y){
Port = x;
bReady=y;}


Horrible names, these are. Change 'x' and 'y' to something more meaningful.
May 19 '06 #13
vs******@gmail.com wrote:
Hi guys

I am not good OOP programmer ,trying to implement my already working
code in OOP.

I have somthing like this class.

class Datalogger{
public:
UINT Port;
unsigned int Port;
BOOL bReady ;
bool bReady;

Datalogger (UINT x ,bool y);
Datalogger (unsigned int x, bool y);
~Datalogger ();

bool LOpen ();
bool LStatus ();

};
Everything is OK till "bool LStatus ();"

bool LStatus ()
{
..... Here I have bunch of stuff;
but I get problem here

Waitforevent( Port , INFINTE , &bReady)
if(bReady)
{
......
....some stuff ;
......

}
}
Where "Waitforevent" is fucntion came with driver of my I/O board .I
did not make this function.
it gives
bReady= true on events.

My question is that "CAN I USE member variable like this"
I means Can I use address of member variable to some function.


Do you initialize bReady in the constructor initialization list?

May 19 '06 #14

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

21
by: Dave | last post by:
After following Microsofts admonition to reformat my system before doing a final compilation of my app I got many warnings/errors upon compiling an rtf file created in word. I used the Help...
9
by: Tom | last post by:
A question for gui application programmers. . . I 've got some GUI programs, written in Python/wxPython, and I've got a help button and a help menu item. Also, I've got a compiled file made with...
6
by: wukexin | last post by:
Help me, good men. I find mang books that introduce bit "mang header files",they talk too bit,in fact it is my too fool, I don't learn it, I have do a test program, but I have no correct doing...
3
by: Colin J. Williams | last post by:
Python advertises some basic service: C:\Python24>python Python 2.4.1 (#65, Mar 30 2005, 09:13:57) on win32 Type "help", "copyright", "credits" or "license" for more information. >>> With...
7
by: Corepaul | last post by:
Missing Help Files When I enter "recordset" as the keyword and search the Visual Basic Help index, I get many topics of interest in the resulting list. But there isn't any information available...
5
by: Steve | last post by:
I have written a help file (chm) for a DLL and referenced it using Help.ShowHelp My expectation is that a developer using my DLL would be able to access this help file during his development time...
8
by: Mark | last post by:
I have loaded Visual Studio .net on my home computer and my laptop, but my home computer has an abbreviated help screen not 2% of the help on my laptop. All the settings look the same on both...
10
by: JonathanOrlev | last post by:
Hello everybody, I wrote this comment in another message of mine, but decided to post it again as a standalone message. I think that Microsoft's Office 2003 help system is horrible, probably...
1
by: trunxnirvana007 | last post by:
'UPGRADE_WARNING: Array has a new behavior. Click for more: 'ms-help://MS.VSCC.v80/dv_commoner/local/redirect.htm?keyword="9B7D5ADD-D8FE-4819-A36C-6DEDAF088CC7"' 'UPGRADE_WARNING: Couldn't resolve...
0
by: hitencontractor | last post by:
I am working on .NET Version 2003 making an SDI application that calls MS Excel 2003. I added a menu item called "MyApp Help" in the end of the menu bar to show Help-> About. The application...
0
by: DolphinDB | last post by:
The formulas of 101 quantitative trading alphas used by WorldQuant were presented in the paper 101 Formulaic Alphas. However, some formulas are complex, leading to challenges in calculation. Take...
0
by: DolphinDB | last post by:
Tired of spending countless mintues downsampling your data? Look no further! In this article, you’ll learn how to efficiently downsample 6.48 billion high-frequency records to 61 million...
0
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 6 Mar 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, we are pleased to welcome back...
1
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 6 Mar 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, we are pleased to welcome back...
0
by: Vimpel783 | last post by:
Hello! Guys, I found this code on the Internet, but I need to modify it a little. It works well, the problem is this: Data is sent from only one cell, in this case B5, but it is necessary that data...
0
by: jfyes | last post by:
As a hardware engineer, after seeing that CEIWEI recently released a new tool for Modbus RTU Over TCP/UDP filtering and monitoring, I actively went to its official website to take a look. It turned...
0
by: ArrayDB | last post by:
The error message I've encountered is; ERROR:root:Error generating model response: exception: access violation writing 0x0000000000005140, which seems to be indicative of an access violation...
0
by: CloudSolutions | last post by:
Introduction: For many beginners and individual users, requiring a credit card and email registration may pose a barrier when starting to use cloud servers. However, some cloud server providers now...
0
by: Defcon1945 | last post by:
I'm trying to learn Python using Pycharm but import shutil doesn't work

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.