473,320 Members | 2,000 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,320 software developers and data experts.

Segmentation Fault.

I am executing this program but, getting error Segmentation Fault.

Can any one point out the error in this?

#include<iostream>

using namespace std;

typedef struct __Node
{
int data ;
struct __Node *left, *right ;
} NODE ;
NODE *ROOT = NULL ;

void Insert ( NODE *root, NODE *nNode )
{
if ( root )
{
//////////////
}
else
{
*root = nNode ;
}
}

void Insert ( int data )
{
NODE *tmp = new NODE ;
tmp -> left = tmp -> right = NULL ;
tmp -> data = data ;
Insert ( ROOT, tmp ) ;
}

int main ()
{
Insert ( 10 ) ;
cout << ROOT -> data << endl ;
return 0 ;
}

Thanks in advance.
Prasad

May 4 '06 #1
3 1740
"Prasad" <pr*************@yahoo.co.in> wrote in message
news:11**********************@i40g2000cwc.googlegr oups.com...
:I am executing this program but, getting error Segmentation Fault.
:
: Can any one point out the error in this?
:
: #include<iostream>
:
: using namespace std;
:
: typedef struct __Node

BTW: Identifiers starting by two unserscores (or an underscore and
an uppercase letter) are reserved for use by the implementation.
Don't use them, or your code will not be standards compliant.

: {
: int data ;
: struct __Node *left, *right ;
: } NODE ;
All-uppercase are typically used only for preprocessors definitions
(althouth it is not illegal to do otherwise).

: NODE *ROOT = NULL ;

You are never allocating this root node, therefore dereferencing
a null pointer.
Why not declare an actual variable instead of a pointer:
Node root;
Use &root when you need a pointer to the root.

Ivan
--
http://ivan.vecerina.com/contact/?subject=NG_POST <- email contact form
Brainbench MVP for C++ <> http://www.brainbench.com
May 4 '06 #2

Prasad wrote:
I am executing this program but, getting error Segmentation Fault.

Can any one point out the error in this?

#include<iostream>

using namespace std;

typedef struct __Node
{
int data ;
struct __Node *left, *right ;
} NODE ;
NODE *ROOT = NULL ;

void Insert ( NODE *root, NODE *nNode )
{
if ( root )
{
//////////////
}
else
{
*root = nNode ;
}
}

void Insert ( int data )
{
NODE *tmp = new NODE ;
tmp -> left = tmp -> right = NULL ;
tmp -> data = data ;
Insert ( ROOT, tmp ) ;
}

int main ()
{
Insert ( 10 ) ;
cout << ROOT -> data << endl ;
return 0 ;
}

Thanks in advance.
Prasad


I dont which version of gcc you are using.
But g++ complains error on,
*root = nNode;

Here you are trying to fill object pointed to by root with nNode
pointer.
Probably what you wanted is

root = nNode.

Regards
Sunil

May 4 '06 #3
> else
{
*root = nNode ;
}
*root = nNode ;
You mean root->left or right = nNode ;

int main ()
{
Insert ( 10 ) ;
cout << ROOT -> data << endl ;
return 0 ;
}


ROOT->data is garbage

May 4 '06 #4

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

2
by: sivignon | last post by:
Hi, I'm writing a php script which deals with 3 ORACLE databases. This script is launch by a script shell on an linux machine like this : /../php/bin/php ./MySript.php (PHP 4.3.3) My script...
3
by: diyanat | last post by:
i am writing a cgi script in C using the CGIC library, the script fails to run, i am using apache on linux error report from apache : internal server error Premature end of script headers:...
16
by: laberth | last post by:
I've got a segmentation fault on a calloc and I don'tunderstand why? Here is what I use : typedef struct noeud { int val; struct noeud *fgauche; struct noeud *fdroit; } *arbre; //for those...
3
by: Zheng Da | last post by:
Program received signal SIGSEGV, Segmentation fault. 0x40093343 in _int_malloc () from /lib/tls/libc.so.6 (gdb) bt #0 0x40093343 in _int_malloc () from /lib/tls/libc.so.6 #1 0x40094c54 in malloc...
5
by: Fra-it | last post by:
Hi everybody, I'm trying to make the following code running properly, but I can't get rid of the "SEGMENTATION FAULT" error message when executing. Reading some messages posted earlier, I...
18
by: Digital Puer | last post by:
Hi, I'm coming over from Java to C++, so please bear with me. In C++, is there a way for me to use exceptions to catch segmentation faults (e.g. when I access a location off the end of an array)?...
27
by: Paminu | last post by:
I have a wierd problem. In my main function I print "test" as the first thing. But if I run the call to node_alloc AFTER the printf call I get a segmentation fault and test is not printed! ...
7
by: pycraze | last post by:
I would like to ask a question. How do one handle the exception due to Segmentation fault due to Python ? Our bit operations and arithmetic manipulations are written in C and to some of our...
3
by: madunix | last post by:
My Server is suffering bad lag (High Utlization) I am running on that server Oracle10g with apache_1.3.35/ php-4.4.2 Web visitors retrieve data from the web by php calls through oci cobnnection...
6
by: DanielJohnson | last post by:
int main() { printf("\n Hello World"); main; return 0; } This program terminate just after one loop while the second program goes on infinitely untill segmentation fault (core dumped) on...
0
by: ryjfgjl | last post by:
ExcelToDatabase: batch import excel into database automatically...
0
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 6 Mar 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, we are pleased to welcome back...
0
by: Vimpel783 | last post by:
Hello! Guys, I found this code on the Internet, but I need to modify it a little. It works well, the problem is this: Data is sent from only one cell, in this case B5, but it is necessary that data...
0
by: jfyes | last post by:
As a hardware engineer, after seeing that CEIWEI recently released a new tool for Modbus RTU Over TCP/UDP filtering and monitoring, I actively went to its official website to take a look. It turned...
1
by: PapaRatzi | last post by:
Hello, I am teaching myself MS Access forms design and Visual Basic. I've created a table to capture a list of Top 30 singles and forms to capture new entries. The final step is a form (unbound)...
0
by: Defcon1945 | last post by:
I'm trying to learn Python using Pycharm but import shutil doesn't work
1
by: Shællîpôpï 09 | last post by:
If u are using a keypad phone, how do u turn on JavaScript, to access features like WhatsApp, Facebook, Instagram....
0
by: af34tf | last post by:
Hi Guys, I have a domain whose name is BytesLimited.com, and I want to sell it. Does anyone know about platforms that allow me to list my domain in auction for free. Thank you
0
by: Faith0G | last post by:
I am starting a new it consulting business and it's been a while since I setup a new website. Is wordpress still the best web based software for hosting a 5 page website? The webpages will be...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.