473,396 Members | 1,975 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,396 software developers and data experts.

Static initialization order fiasco with smart pointers

I've a class C with a smart pointer (I use boost::shared_ptr) which is
initialized in the constructor:

class C {
boost::shared_ptr<D> d;
public:
C() : d(new d()) { }
};

When the program starts class C is instantiated quite a lot. As all the
instances of C use the same empty instance of D I want them to share the
instance:

class C {
boost::shared_ptr<D> d;
static boost::shared_ptr<D> one;
public:
C() : d(one) { }
};

boost::shared_ptr<D> C::one(new d());

That would work if I wasn't using the quick_allocator for boost::shared_ptr
(a memory manager which is used when BOOST_SP_USE_QUICK_ALLOCATOR is
defined). Now as it turns out this memory manager uses static variables.

According to the FAQ we initialize the static member now in a method:

class C {
boost::shared_ptr<D> d;
static boost::shared_ptr<D> one;
public:
C() : d(one) { }
static Init() { one.reset(new d()); }
};

boost::shared_ptr<D> C::one;

Now everything works until the program ends. If the static variables in the
memory manager of boost::shared_ptr are destroyed first the destructor of
the static smart pointer in class C will make a call to a non-existing
memory manager.

The only solution I see is freeing the static smart pointer when the last
instance of class C is destroyed (then noone needs the instance of D in the
smart pointer anymore). The destructor uses the counter of the smart pointer
to check when it should be freed:

class C {
boost::shared_ptr<D> d;
static boost::shared_ptr<D> one;
public:
C() : d(one) { }
static Init() { one.reset(new d()); }
~C() { if (one.unique()) one.reset(); }
};

boost::shared_ptr<D> C::one;

This is however no general solution (eg. if you destroy all instances of C
and then create a new one in the middle of the program the smart pointer is
empty). Is there a better idea how to handle this?

Boris
Apr 13 '06 #1
5 7784
Boris wrote:
[...] This is however no general solution (eg. if you destroy all
instances
of C and then create a new one in the middle of the program the smart
pointer is empty). Is there a better idea how to handle this?


Alright, about three seconds after clicking on Send I suddenly understood
that the smart pointer must be created dynamically:

class C {
boost::shared_ptr<D> d;
static boost::shared_ptr<D> *one;
public:
C() : d(*one) { }
static Init() { one = new boost::shared_ptr<D>(new d()); }
};

boost::shared_ptr<D> *C::one;

Sometimes it helps to send a question just to find the answer yourself. :)

Boris
Apr 13 '06 #2
Boris wrote:
Boris wrote:
[...] This is however no general solution (eg. if you destroy all
instances
of C and then create a new one in the middle of the program the smart
pointer is empty). Is there a better idea how to handle this?
Alright, about three seconds after clicking on Send I suddenly
understood that the smart pointer must be created dynamically:

class C {
boost::shared_ptr<D> d;
static boost::shared_ptr<D> *one;
public:
C() : d(*one) { }
static Init() { one = new boost::shared_ptr<D>(new d()); }


static *WHAT* Init()? Did you mean to say

static void Init()

???
};

boost::shared_ptr<D> *C::one;
This is initialised to a null pointer (since it's "static"). Is that
really what you wanted? As soon as I try creating an instance of 'C',
I get undefined behaviour because a null pointer is dereferenced...
Sometimes it helps to send a question just to find the answer
yourself. :)


No doubt. Did you actually find the answer?

V
--
Please remove capital 'A's when replying by e-mail
I do not respond to top-posted replies, please don't ask
Apr 13 '06 #3
Victor Bazarov wrote:
[...] static *WHAT* Init()? Did you mean to say

static void Init()

???


Sorry, I forgot the return type.
boost::shared_ptr<D> *C::one;


This is initialised to a null pointer (since it's "static"). Is that
really what you wanted? As soon as I try creating an instance of 'C',
I get undefined behaviour because a null pointer is dereferenced...


Read my original message again and then the FAQ. Here's the direct link:
http://www.parashift.com/c++-faq-lit...html#faq-10.14
Sometimes it helps to send a question just to find the answer
yourself. :)


No doubt. Did you actually find the answer?


Guess for what Init() is used for you corrected above?

Boris
Apr 13 '06 #4
Boris wrote:
Victor Bazarov wrote:
[...] static *WHAT* Init()? Did you mean to say

static void Init()

???


Sorry, I forgot the return type.
boost::shared_ptr<D> *C::one;


This is initialised to a null pointer (since it's "static"). Is that
really what you wanted? As soon as I try creating an instance of
'C', I get undefined behaviour because a null pointer is
dereferenced...


Read my original message again and then the FAQ. Here's the direct
link: http://www.parashift.com/c++-faq-lit...html#faq-10.14
Sometimes it helps to send a question just to find the answer
yourself. :)


No doubt. Did you actually find the answer?


Guess for what Init() is used for you corrected above?


I don't see it called anywhere.

V
--
Please remove capital As from my address when replying by mail
Apr 14 '06 #5

Boris wrote:
Boris wrote:
[...] This is however no general solution (eg. if you destroy all
instances
of C and then create a new one in the middle of the program the smart
pointer is empty). Is there a better idea how to handle this?


Alright, about three seconds after clicking on Send I suddenly understood
that the smart pointer must be created dynamically:

class C {
boost::shared_ptr<D> d;
static boost::shared_ptr<D> *one;
public:
C() : d(*one) { }
static Init() { one = new boost::shared_ptr<D>(new d()); }
};

boost::shared_ptr<D> *C::one;

Sometimes it helps to send a question just to find the answer yourself. :)

Boris


Try the following code:

#include <iostream>
#include <boost/shared_ptr.hpp>

struct D {
int x;
D():x(3){}
};

class C {
boost::shared_ptr<D> d;
public:
C(): d(Init()) {}
static boost::shared_ptr<D> Init(){
static boost::shared_ptr<D> *one;
if(!one)
one = new boost::shared_ptr<D>(new D());
return *one;
}
void print(){
std::cout << "D::x = " << d->x << std::endl;
}
};

int main(void){

C c;
c.print();
}

Apr 19 '06 #6

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

1
by: Qin Chen | last post by:
I will present very long code, hope someone will read it all, and teach me something like tom_usenet. This question comes to me when i read <<Think in C++>> 2nd, chapter 10 , name control,...
4
by: Bret Pehrson | last post by:
I just stumbled across the following problem: //.h class Masses { static double mass1; static double mass2; static double mass3; };
4
by: ma740988 | last post by:
Referencing source snippet below, the actual contruction of the foo objects is done in a class. In that regard, I chose methods, class1_construct and class2_construct for demonstration purposes....
14
by: Jeroen | last post by:
Hi all, I've got a question about writing a library. Let me characterize that library by the following: * there is a class A which is available to the user * there is a class B that is used...
1
by: Sandro Bosio | last post by:
Hello everybody, my first message on this forum. I tried to solve my issue by reading other similar posts, but I didn't succeed. And forgive me if this mail is so long. I'm trying to achieve the...
10
by: n.torrey.pines | last post by:
Are global variables (and const's) guaranteed to be initialized before static class members (and methods) ? const int x = 19907; int get_x() { return x; } // another compilation unit: ...
6
by: r.z. | last post by:
They should be initialized before any instance is created. I have no idea in which file, in which place should I put their initialization code to be sure they are initialize only once, before any...
3
by: Steve Folly | last post by:
Hi, I had a problem in my code recently which turned out to be the 'the "static initialization order fiasco"' problem (<http://www.parashift.com/c++-faq-lite/ctors.html#faq-10.12>) The FAQ...
20
by: JohnQ | last post by:
The way I understand the startup of a C++ program is: A.) The stuff that happens before the entry point. B.) The stuff that happens between the entry point and the calling of main(). C.)...
0
by: Charles Arthur | last post by:
How do i turn on java script on a villaon, callus and itel keypad mobile phone
0
by: emmanuelkatto | last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud. Please let me know. Thanks! Emmanuel
0
BarryA
by: BarryA | last post by:
What are the essential steps and strategies outlined in the Data Structures and Algorithms (DSA) roadmap for aspiring data scientists? How can individuals effectively utilize this roadmap to progress...
1
by: Sonnysonu | last post by:
This is the data of csv file 1 2 3 1 2 3 1 2 3 1 2 3 2 3 2 3 3 the lengths should be different i have to store the data by column-wise with in the specific length. suppose the i have to...
0
by: Hystou | last post by:
There are some requirements for setting up RAID: 1. The motherboard and BIOS support RAID configuration. 2. The motherboard has 2 or more available SATA protocol SSD/HDD slots (including MSATA, M.2...
0
marktang
by: marktang | last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However,...
0
by: Hystou | last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can...
0
jinu1996
by: jinu1996 | last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven...
0
tracyyun
by: tracyyun | last post by:
Dear forum friends, With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.