Header problems

[gamehack]

Hi all,

Let me describe the problem. I've a header file util.h which contains
the following:
#ifndef UTIL_H_
#define UTIL_H_

const char DEF_TITLE[] = "My Title";

int num_chars(int num);
char* get_default_title(void);

#endif /* UTIL_H_ */

When I include the header from two or more files in complains that
DEF_TITLE is defined more than once: "multiple definition of
`DEF_TITLE`" is printed for both files which use DEF_TITLE. I cannot
understand why this happens since I've put the header guards. Platform
is MinGW 3.4.2 & Win XP Pro.

Regards

[Banfa]

The header guards protect you from including the same header more than once into a single c file.

It does not stop the header being included into multiple C files otherwise only 1 file would be able to access the definitions in any header file.

The reason you have multiple definitions is that you have put a data definition in the header file, header files should only contain declarations (of data or functions), the data should be defined in a C file else where.

const char DEF_TITLE[] = "My Title";

should be

extern const char DEF_TITLE[] = "My Title";

you should put

const char DEF_TITLE[] = "My Title";

in 1 of your c files.

[osmium]

"gamehack" writes:

Let me describe the problem. I've a header file util.h which contains
the following:
#ifndef UTIL_H_
#define UTIL_H_

const char DEF_TITLE[] = "My Title";
Header guards do not protect against multiple definitions. Each program
segment that includes this header gets exactly one definition for DEF_TITLE.
There should only be *type* definitions or variable *declarations* in a
header.

Change it to external (q.v.) which will demote it to a declaration. Put a
definition in one of the files where it makes sense.

int num_chars(int num);

char* get_default_title(void);

#endif /* UTIL_H_ */

When I include the header from two or more files in complains that
DEF_TITLE is defined more than once: "multiple definition of
`DEF_TITLE`" is printed for both files which use DEF_TITLE. I cannot
understand why this happens since I've put the header guards. Platform
is MinGW 3.4.2 & Win XP Pro.

Regards

[Michael Mair]

gamehack schrieb:

Hi all,

Let me describe the problem. I've a header file util.h which contains
the following:
#ifndef UTIL_H_
#define UTIL_H_

const char DEF_TITLE[] = "My Title";
DEF_TITLE is a file scope identifier with external linkage.
It must not be used more than once as such in the whole
programme. So, if you #include "util.h" in more than one
translation unit, this thing breaks.
int num_chars(int num);
char* get_default_title(void);

#endif /* UTIL_H_ */

When I include the header from two or more files in complains that
DEF_TITLE is defined more than once: "multiple definition of
`DEF_TITLE`" is printed for both files which use DEF_TITLE. I cannot
understand why this happens since I've put the header guards.

Header guards protect against
-- a.h --
#include "b.h"
---------
-- b.h --
#include "a.h"
---------
and multiple definitions of types.

Consider

-- util.h --
#ifndef UTIL_H_
#define UTIL_H_

extern const char *DEF_TITLE;

int num_chars(int num);
char* get_default_title(void);

#endif /* UTIL_H_ */
------------
-- util.c --
#include "util.h"

const char *DEF_TITLE = "My Title";

.....

------------

Cheers
Michael
--
E-Mail: Mine is an /at/ gmx /dot/ de address.

[Pedro Graca]

gamehack wrote:

Let me describe the problem. I've a header file util.h which contains
the following:
#ifndef UTIL_H_
#define UTIL_H_

const char DEF_TITLE[] = "My Title";
Why not

#define DEF_TITLE "My Title" /* no semicolon */
int num_chars(int num);
char* get_default_title(void);

#endif /* UTIL_H_ */

And then use it in your program as a constant string

/* ... */
char title1[] = DEF_TITLE;
char *title2 = NULL;
/* ... including allocating space for title2 ... */
strcpy(title2, DEF_TITLE);
/* ... */
printf("Title: %s\n", title2 ? title2 : DEF_TITLE);
/* ... */

--
If you're posting through Google read <http://cfaj.freeshell.org/google>

[Michael Mair]

Pedro Graca schrieb:

gamehack wrote:

Let me describe the problem. I've a header file util.h which contains
the following:
#ifndef UTIL_H_
#define UTIL_H_

const char DEF_TITLE[] = "My Title";

Why not

#define DEF_TITLE "My Title" /* no semicolon */

int num_chars(int num);
char* get_default_title(void);

#endif /* UTIL_H_ */

And then use it in your program as a constant string

/* ... */
char title1[] = DEF_TITLE;
char *title2 = NULL;
/* ... including allocating space for title2 ... */
strcpy(title2, DEF_TITLE);
/* ... */
printf("Title: %s\n", title2 ? title2 : DEF_TITLE);
/* ... */

This
- does not protect you against inadvertently trying
to modify DEF_TITLE
- potentially wastes storage if "My Title" is stored
multiple times (e.g. once per translation unit, once
per function, once per use...)

String literals should be used with care.

Cheers
Michael
--
E-Mail: Mine is an /at/ gmx /dot/ de address.

[Dave Thompson]

On Wed, 15 Feb 2006 10:24:38 -0800, "osmium" <r1********@comcast.net>
wrote:

"gamehack" writes:

Let me describe the problem. I've a header file util.h which contains
the following:
#ifndef UTIL_H_
#define UTIL_H_

const char DEF_TITLE[] = "My Title";
Header guards do not protect against multiple definitions. Each program
segment that includes this header gets exactly one definition for DEF_TITLE.

More specifically, each 'translation unit' = source file + includes.
There should only be *type* definitions or variable *declarations* in a
header.

Change it to external (q.v.) which will demote it to a declaration. Put a
definition in one of the files where it makes sense.

Just adding 'extern' (not 'external', and not replacing anything
already there) to a declaration with an initializer doesn't help; it's
still a definition. You need to declare with extern and no
initializer, and then (as you say) define in one t.u.

It may be a problem (or not) that in that scheme the declaration
extern const char DEF_TITLE [] ;
has unknown bound/size, whereas with the initializer it has a known
size from the initial value even though not explicitly written. If
this matters you can duplicate the value in each t.u. as
static const char DEF_TITLE [] = "Value";
(It is even possible, and certainly permitted though not required,
that the implementation might be clever enough to merge these.)
- David.Thompson1 at worldnet.att.net