Hello,
I noticed that when I dynamically create an array of chars, the
resulting size of the allocated memory block is larger by about 15
bytes than what I specified. Here is example code:
char *createTextBuffer(char *buffer, int length)
{
buffer = new char[length];
if (buffer == NULL) {
return NULL;
}
length = strlen(buffer); // Current buffer shows larger size.
return buffer;
}
The above program causes a crash when destroying the allocated memory
via delete. I suspect the crash problem originates at the time of
allocation (i.e., possible memory corruption at time of allocation).
I am using MS Developer Studio 6.0 (SP 6) on AMD Athlon. I get the same
results on a Pentium 4. Any suggestions or comments on what I am doing
in the code is much appreciated.
TIA
Alabi 10 4330
AlabiChin napisał: Hello, I noticed that when I dynamically create an array of chars, the resulting size of the allocated memory block is larger by about 15 bytes than what I specified. Here is example code: char *createTextBuffer(char *buffer, int length) { buffer = new char[length]; if (buffer == NULL) { return NULL;
// new does not return NULL on error, it throws
// so this check is meaningless
} length = strlen(buffer); // Current buffer shows larger size. return buffer; } The above program causes a crash when destroying the allocated memory via delete.
That's because you should destroy it using 'delete[]',
not 'delete'.
I suspect the crash problem originates at the time of allocation (i.e., possible memory corruption at time of allocation).
I don't think so. I am using MS Developer Studio 6.0 (SP 6) on AMD Athlon. I get the same results on a Pentium 4. Any suggestions or comments on what I am doing in the code is much appreciated.
Notice that you don't clear the allocated buffer, therefore
it contains garbage. The function strlen() looks for the
first occurrence of the '\0' terminator, which luckily
falls 'about 15 bytes' after the end of your buffer.
HTH,
- J.
AlabiChin wrote: Hello,
I noticed that when I dynamically create an array of chars, the resulting size of the allocated memory block is larger by about 15 bytes than what I specified. Here is example code:
char *createTextBuffer(char *buffer, int length) { buffer = new char[length];
if (buffer == NULL) {
This check is unnecessary. new either returns a valid pointer or (if no
memory is available) throws an exception. It never returns a null pointer.
return NULL; } length = strlen(buffer); // Current buffer shows larger size. return buffer; }
strlen expects a C style string, i.e. a null terminated character array. You
gave it uninitialized memory, which means the behavior is undefined.
The above program causes a crash when destroying the allocated memory via delete. I suspect the crash problem originates at the time of allocation (i.e., possible memory corruption at time of allocation).
No, it originates at the time you used strlen on it. Probably, strlen went
past the end of the array to find the null character.
AlabiChin wrote: Hello,
I noticed that when I dynamically create an array of chars, the resulting size of the allocated memory block is larger by about 15 bytes than what I specified. Here is example code:
char *createTextBuffer(char *buffer, int length) { buffer = new char[length];
if (buffer == NULL) { return NULL; } length = strlen(buffer); // Current buffer shows larger size. return buffer; }
The above program causes a crash when destroying the allocated memory via delete. I suspect the crash problem originates at the time of allocation (i.e., possible memory corruption at time of allocation).
I am using MS Developer Studio 6.0 (SP 6) on AMD Athlon. I get the same results on a Pentium 4. Any suggestions or comments on what I am doing in the code is much appreciated.
TIA Alabi
You have an uninitialized buffer. Calling strlen with such a buffer is
likely to cause a crash right then and there. strlen does not return
the length of the buffer, it returns the length of a nul-terminated
string that has been stored in the buffer. But you do not have such a
string in the buffer.
--
Scott McPhillips [VC++ MVP]
AlabiChin wrote: I noticed that when I dynamically create an array of chars, the resulting size of the allocated memory block is larger by about 15 bytes than what I specified.
whilst "new" can be expected to allocate a few more bytes than
requested
(housekeeping) 15 bytes sounds like a lot.
Here is example code:
char *createTextBuffer(char *buffer, int length) { buffer = new char[length];
if (buffer == NULL) { return NULL; } length = strlen(buffer); // Current buffer shows larger size.
you can't do strlen on a newly allocated chunk of memory. How do you
know
"new" returns a nul terminated string?
return buffer; }
The above program causes a crash when destroying the allocated memory via delete.
what does your delete look like?
I suspect the crash problem originates at the time of allocation (i.e., possible memory corruption at time of allocation).
I suspect there's something else wrong with your program. Standard
libraries
can have bugs, but always suspect your own (newly written) code first
I am using MS Developer Studio 6.0 (SP 6) on AMD Athlon. I get the same results on a Pentium 4. Any suggestions or comments on what I am doing in the code is much appreciated.
--
Nick Keighley
AlabiChin wrote: Hello,
I noticed that when I dynamically create an array of chars, the resulting size of the allocated memory block is larger by about 15 bytes than what I specified. Here is example code:
char *createTextBuffer(char *buffer, int length) { buffer = new char[length];
if (buffer == NULL) { return NULL; } length = strlen(buffer); // Current buffer shows larger size. return buffer; }
strlen is a "C" library function which returns the length of a "null
terminated string". In other words, in the current case, it will count
the number of characters from start of buffer till it finds a null
character. Since char is a basic data type, buffer remains
uninitialized, and thus contains a junk. It is incorrect to relie on
strlen. The above program causes a crash when destroying the allocated memory via delete.
This is because usage of new[] must be matched via delete[], not
delete.
"AlabiChin" <al**********@yahoo.com> wrote in message
news:11**********************@g47g2000cwa.googlegr oups.com... Hello,
I noticed that when I dynamically create an array of chars, the resulting size of the allocated memory block is larger by about 15 bytes than what I specified. Here is example code:
char *createTextBuffer(char *buffer, int length) { buffer = new char[length];
if (buffer == NULL) { return NULL; } length = strlen(buffer); // Current buffer shows larger size.
strlen looks for the first null character to determine the end of the
string. Since you have not initialized the array, the array contains random
information, and your length will be some arbitary number.
To see this add this line just before your length =
buffer[0] = '\0';
Now your length will be 0 because it will find the null in the first
position.
When you delete this array you use delete[]
Hmm, I studied documentation in VS 2003.NET which I consider not too
out-of-date and found out that new returns 0/NULL. If you want exception
handling you need to use set_new_handler function.
From what time new throws exception? What type of exception is it?
Viktor Prehnal wrote: Hmm, I studied documentation in VS 2003.NET which I consider not too out-of-date and found out that new returns 0/NULL. If you want exception handling you need to use set_new_handler function.
new throws an exception when it fails
From what time new throws exception? What type of exception is it?
std::bad_alloc
--
Nick Keighley
Viktor Prehnal wrote: Hmm, I studied documentation in VS 2003.NET which I consider not too out-of-date and found out that new returns 0/NULL. If you want exception handling you need to use set_new_handler function. From what time new throws exception?
In Standard C++ (which is existing since 1998), this has always been the
case.
What type of exception is it?
std::bad_alloc
AlabiChin wrote: I noticed that when I dynamically create an array of chars
Why would you want to do that?
the resulting size of the allocated memory block is larger by about 15 bytes than what I specified.
Why would you care?
Here is example code:
char *createTextBuffer(char *buffer, int length) { buffer = new char[length];
if (buffer == NULL) { return NULL; } length = strlen(buffer); // Current buffer shows larger size. return buffer; }
Yuck!
Here's my version of your code:
{ // Begin block; stuff declared in here dies at end.
// Make a buffer to hold some text:
std::string TextBuffer = "This is some text.";
// Find the length of the text in the buffer, which is
// NOT the same thing as the memory used by the buffer:
int Length = TextBuffer.size();
// (do stuff with TextBuffer and Size)
} // End block; TextBuffer and Size are deallocated here.
In my version, allocation and deallocation are always done
for you automatically. There is no "memory allocation
problem". If you absolutely need a C string version of
TextBuffer (say, to pass to some C std lib function), then
use the .c_str() member function of TextBuffer:
int CSize = strlen(TextBuffer.c_str());
I think you'll find that Size and CSize are then both
equal to 18 (the length of "This is some text.").
The above program causes a crash.
Of course. For one thing, it's full of errors, as others
here have pointed out. But more importantly, it's C, not
C++. A zero-terminated array of char is a very antiquated
and crude way of handling strings. C++ std::string is much
better. It's easier, safer, and much more versatile, with
loads of cool member functions such as "size" and "find"
and "substr". Time to upgrade your approach, I think.
--
Cheers!
Robbie Hatley
Tustin, CA, USA
email: lonewolfintj at pacbell dot net
web: home dot pacbell dot net slant earnur slant This thread has been closed and replies have been disabled. Please start a new discussion. Similar topics
by: Franklin Lee |
last post by:
Hi All,
I use new to allocate some memory,even I doesn't use delete to release them.
When my Application exit, OS will release them.
Am I right?
If I'm right, how about Thread especally on...
|
by: PaulR |
last post by:
Hi,
We have a Server running SLES 8 and 3GB memory, with 1 DB2 instance and
2 active Databases.
General info...
DB2level = "DB2 v8.1.0.72", "s040914", "MI00086", and FixPak "7"
uname -a =...
|
by: berthelot samuel |
last post by:
Hi,
I'm trying to develop an application for modeling 3D objects from
Bezier patches, but I have a memory allocation problem. Here are my
structures:
typedef struct _vector3 {
union
{
struct...
|
by: Dan Nilsen |
last post by:
Hi!
I'm writing a small piece of software that basically runs on an
embedded system with a Power-PC cpu. This runs on a stripped down
version of Linux - Busybox.
As I'm writing a piece of...
|
by: Florin |
last post by:
Hi all,
I have a problem related to memory grow on a server application
which is basically stateless (I have some static info loaded). The
client accesses this server using remoting and it has...
|
by: ballpointpenthief |
last post by:
If I have malloc()'ed a pointer and want to read from it as if it were
an array, I need to know that I won't be reading past the last index.
If this is a pointer to a pointer, a common technique...
|
by: Johan Tibell |
last post by:
I've written a piece of code that uses sockets a lot (I know that
sockets aren't portable C, this is not a question about sockets per
se). Much of my code ended up looking like this:
if...
|
by: Peterwkc |
last post by:
Hello all expert, i have two program which make me desperate bu after i have noticed the forum, my future is become brightness back.
By the way, my problem is like this i the first program was...
|
by: jacob navia |
last post by:
Suppose that you have a module that always allocates
memory without ever releasing it because the guy that
wrote it was lazy, as lazy as me.
Now, you want to reuse it in a loop. What do you do?...
|
by: Steven Powers |
last post by:
Imagine the following setup
class Parent
{
virtual void doStuff();
}
class Child : public Parent
{
virtual void doStuff();
}
|
by: Charles Arthur |
last post by:
How do i turn on java script on a villaon, callus and itel keypad mobile phone
|
by: emmanuelkatto |
last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud.
Please let me know.
Thanks!
Emmanuel
|
by: BarryA |
last post by:
What are the essential steps and strategies outlined in the Data Structures and Algorithms (DSA) roadmap for aspiring data scientists? How can individuals effectively utilize this roadmap to progress...
|
by: Sonnysonu |
last post by:
This is the data of csv file
1 2 3
1 2 3
1 2 3
1 2 3
2 3
2 3
3
the lengths should be different i have to store the data by column-wise with in the specific length.
suppose the i have to...
|
by: Hystou |
last post by:
There are some requirements for setting up RAID:
1. The motherboard and BIOS support RAID configuration.
2. The motherboard has 2 or more available SATA protocol SSD/HDD slots (including MSATA, M.2...
|
by: Hystou |
last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can...
|
by: Oralloy |
last post by:
Hello folks,
I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>".
The problem is that using the GNU compilers,...
|
by: Hystou |
last post by:
Overview:
Windows 11 and 10 have less user interface control over operating system update behaviour than previous versions of Windows. In Windows 11 and 10, there is no way to turn off the Windows...
|
by: tracyyun |
last post by:
Dear forum friends,
With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each...
| |