473,385 Members | 1,311 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,385 software developers and data experts.

counting lines in text file

hi im having trouble counting lines in a text file, i have the
following code

int node1, node2, i;
char name[2];
float value;

ifstream fin;
fin.open(OpenDialog1->FileName.c_str());
i=1;
// while (!fin.eof())
for(;;)
{
fin>>name>>node1>>node2>>value;

switch(i){
case 1:
Label1->Caption = value;
break;
case 2:
Label2->Caption = value;
break;
case 3:
Label3->Caption = value;
break;
case 4:
Label4->Caption = value;
break;
case 5:
Label5->Caption = value;
break;
}
i++;
if (fin.eof()) break;
}

im using i to increment each time the loop goes round thus counting the
no. of lines. however the line ' fin>>name>>node1>>node2>>value;' keeps
setting i to 0 so it never counts it. How do i fix this, or is there
another way to do this?

thx

Dec 14 '05 #1
5 7641
On 13 Dec 2005 17:23:21 -0800 in comp.lang.c++, an********@gmail.com
wrote,
int node1, node2, i;
int i = 0;
// while (!fin.eof())
for(;;)
{

fin>>name>>node1>>node2>>value;
Avoid looping on !eof(). Make that
while (fin>>name>>node1>>node2>>value) { ...
however the line ' fin>>name>>node1>>node2>>value;' keeps setting i to 0


I don't think so. However, i appears to be uninitialized.

Dec 14 '05 #2
an********@gmail.com wrote:

char name[2];
[snip]

im using i to increment each time the loop goes round thus counting the
no. of lines. however the line ' fin>>name>>node1>>node2>>value;' keeps
setting i to 0 so it never counts it. How do i fix this, or is there
another way to do this?


What is stored in 'name'?

Note that name has only room for a size-2 string.
That is: one lettter plus the terminating '\0'

Other then that:
Your use of eof is wrong, but that does not explain the
magical change of 'i'.

--
Karl Heinz Buchegger
kb******@gascad.at
Dec 14 '05 #3

"Karl Heinz Buchegger" <kb******@gascad.at> wrote in message
news:43***************@gascad.at...
an********@gmail.com wrote:

char name[2];


[snip]

im using i to increment each time the loop goes round thus counting the
no. of lines. however the line ' fin>>name>>node1>>node2>>value;' keeps
setting i to 0 so it never counts it. How do i fix this, or is there
another way to do this?


What is stored in 'name'?

Note that name has only room for a size-2 string.
That is: one lettter plus the terminating '\0'

Other then that:
Your use of eof is wrong, but that does not explain the
magical change of 'i'.


IMHO that magical change of i could only be achieved by aliasing or
completely broken optimization of the compiler. However, from the code
posted I doubt that very much. I'm not sure what the overall objective of
the OP is, but if it is only counting lines I'd suggest the following code,
which does not care about the format and contents at all:

int CountLines( std::ifstream& In )
{
return static_cast<int>( std::count( std::istreambuf_iterator<char>( In),
std::istreambuf_iterator<char>(), '\n' ) );
}

Cheers
Chris
Dec 14 '05 #4
Chris Theis wrote:

"Karl Heinz Buchegger" <kb******@gascad.at> wrote in message
news:43***************@gascad.at...
an********@gmail.com wrote:

char name[2];


[snip]

im using i to increment each time the loop goes round thus counting the
no. of lines. however the line ' fin>>name>>node1>>node2>>value;' keeps
setting i to 0 so it never counts it. How do i fix this, or is there
another way to do this?


What is stored in 'name'?

Note that name has only room for a size-2 string.
That is: one lettter plus the terminating '\0'

Other then that:
Your use of eof is wrong, but that does not explain the
magical change of 'i'.


IMHO that magical change of i could only be achieved by aliasing or
completely broken optimization of the compiler.


Well. My personal guess is, that his file format looks like this

AB 1 2 2.0
CD 3 4 5.0

since the first column in his file contains 2 characters and
the variable receiving that string is defined as

char name[2];

the input operation is overflowing the array. And since
i is immediatly defined before that array, the overflow
happens such that the terminating '\0' is 'resetting' i in
each input operation. For this the compiler might have
arranged things on the stack such that i has a higher
address on the CPU stack but is immediatly following
name in memory. A lot of compilers would do it that way.

But this is just my personal guess and of course is
completely implementation dependent. Nevertheless I
think it is a good theory and to verify it, the exact
file format would be needed.

--
Karl Heinz Buchegger
kb******@gascad.at
Dec 14 '05 #5

"Karl Heinz Buchegger" <kb******@gascad.at> wrote in message
news:43***************@gascad.at...
[SNIP]
But this is just my personal guess and of course is
completely implementation dependent. Nevertheless I
think it is a good theory and to verify it, the exact
file format would be needed.


Yes, that could easily be. I recently saw an implementation that internally
padded an extra byte for character arrays in order to be on the safe side
for such behavior. But as you said, this is completely implementation
dependent.

Chris
Dec 14 '05 #6

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

7
by: Sam Lowry | last post by:
Greetings. I am trying to do something which should elementary for Perl, but I have only been able to find bits and pieces on it. When I put the bits together they do not work. Maybe I am going...
19
by: Alex Vinokur | last post by:
Is there any tool to count C-program lines except comments? Thanks, ===================================== Alex Vinokur mailto:alexvn@connect.to http://mathforum.org/library/view/10978.html...
5
by: Anders K. Jacobsen [DK] | last post by:
Hi We have a rather large asp.net project with serveral utility projects (written in C#). Is there at tool out there which can give an estimate of the total amount of code lines all projects...
1
by: j | last post by:
Hi, I've been trying to do line/character counts on documents that are being uploaded. As well as the "counting" I also have to remove certain sections from the file. So, firstly I was working...
4
by: Peter | last post by:
Currently I'm using the method below, is there someting more efficient?: Imports System.IO Public Class CountLine Public Shared Function CountLines(ByVal FileName As String) As Integer Dim fs...
7
by: Mark..... | last post by:
Hi, Can someone tell me the easiest way to count the number of lines in a text file? I can write a loop to do this but it seems cumbersome.... there must be an easier way?? Thanks in...
7
by: peraklo | last post by:
Hello, there is another problem i am facing. i have a text file which is about 15000 lines big. i have to cut the last 27 lines from that file and create a new text file that contans those 27...
7
by: tiredMike | last post by:
Hi, I want to count lines in a text file in the format below: 255.000000,148.000000,0.000000,0.000000 255.000000,229.000000,0.000000,0.000000 255.000000,215.000000,0.000000,0.000000 ...
6
by: tolkien | last post by:
Hi,i have this problem.I'm reading strings from a text file and i want to know in which line of the file i am. What i did is this: char string; while(!feof(text_file)){...
1
by: CloudSolutions | last post by:
Introduction: For many beginners and individual users, requiring a credit card and email registration may pose a barrier when starting to use cloud servers. However, some cloud server providers now...
0
by: Faith0G | last post by:
I am starting a new it consulting business and it's been a while since I setup a new website. Is wordpress still the best web based software for hosting a 5 page website? The webpages will be...
0
isladogs
by: isladogs | last post by:
The next Access Europe User Group meeting will be on Wednesday 3 Apr 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM). In this session, we are pleased to welcome former...
0
by: ryjfgjl | last post by:
In our work, we often need to import Excel data into databases (such as MySQL, SQL Server, Oracle) for data analysis and processing. Usually, we use database tools like Navicat or the Excel import...
0
by: aa123db | last post by:
Variable and constants Use var or let for variables and const fror constants. Var foo ='bar'; Let foo ='bar';const baz ='bar'; Functions function $name$ ($parameters$) { } ...
0
by: ryjfgjl | last post by:
If we have dozens or hundreds of excel to import into the database, if we use the excel import function provided by database editors such as navicat, it will be extremely tedious and time-consuming...
0
BarryA
by: BarryA | last post by:
What are the essential steps and strategies outlined in the Data Structures and Algorithms (DSA) roadmap for aspiring data scientists? How can individuals effectively utilize this roadmap to progress...
1
by: nemocccc | last post by:
hello, everyone, I want to develop a software for my android phone for daily needs, any suggestions?
1
by: Sonnysonu | last post by:
This is the data of csv file 1 2 3 1 2 3 1 2 3 1 2 3 2 3 2 3 3 the lengths should be different i have to store the data by column-wise with in the specific length. suppose the i have to...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.