Sign error in K&R 1

[Old Wolf]

I noticed the following today (I always see something new when
I look at K&R ..) , which doesn't seem to be on any errata
lists I can find.

In section 6.6 a hashing function is defined:

.. hash(s)
.. char *s;
.. {
.. int hashval;
..
.. for (hashval = 0; *s != '\0'; )
.. hashval += *s++;
.. return(hashval % HASHSIZE)
.. }

and later it is used: hashtab[hash(s)].

My observation is that s may contain chars with negative
values, making 'hashval' possibly negative. So the return
value could be negative too (p. 188 says "On all machines
covered by this manual, the remainder [of / or %] has the
same sign as the dividend").

So it causes undefined behaviour when hashtab is looked
up with a negative index.

Did this example make it into K&R2 ?

[CBFalconer]

Old Wolf wrote:

I noticed the following today (I always see something new when
I look at K&R ..) , which doesn't seem to be on any errata
lists I can find.

In section 6.6 a hashing function is defined:

. hash(s)
. char *s;
. {
. int hashval;
.
. for (hashval = 0; *s != '\0'; )
. hashval += *s++;
. return(hashval % HASHSIZE)
. }

and later it is used: hashtab[hash(s)].

My observation is that s may contain chars with negative
values, making 'hashval' possibly negative. So the return
value could be negative too (p. 188 says "On all machines
covered by this manual, the remainder [of / or %] has the
same sign as the dividend").

So it causes undefined behaviour when hashtab is looked
up with a negative index.

Did this example make it into K&R2 ?

It got corrected and improved.

--
"If you want to post a followup via groups.google.com, don't use
the broken "Reply" link at the bottom of the article. Click on
"show options" at the top of the article, then click on the
"Reply" at the bottom of the article headers." - Keith Thompson

[Ishtiyaq]

h
"Old Wolf" <ol*****@inspire.net.nz> wrote in message
news:11**********************@z14g2000cwz.googlegr oups.com...

I noticed the following today (I always see something new when
I look at K&R ..) , which doesn't seem to be on any errata
lists I can find.

In section 6.6 a hashing function is defined:

. hash(s)
. char *s;
. {
. int hashval;
.
. for (hashval = 0; *s != '\0'; )
. hashval += *s++;
. return(hashval % HASHSIZE)
. }

and later it is used: hashtab[hash(s)].

My observation is that s may contain chars with negative
values, making 'hashval' possibly negative. So the return
value could be negative too (p. 188 says "On all machines
covered by this manual, the remainder [of / or %] has the
same sign as the dividend").

So it causes undefined behaviour when hashtab is looked
up with a negative index.

Did this example make it into K&R2 ?