473,320 Members | 1,950 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,320 software developers and data experts.

function pointer casting

hello all.

i am trying to get rid of some warnings and do "the right thing".
although in this particular case, i am not sure what the right thing
is.

the code:

typedef struct
{
void *ctx;
void (*init)(void *);
void (*update)(void *, const void *, unsigned long);
void (*final)(unsigned char *, void *);
int mdlen;
char *name;
} digest_t;

MD2_CTX md2ctx;
MD4_CTX md4ctx;
MD5_CTX md5ctx;
SHA_CTX shactx;
RIPEMD160_CTX rmdctx;

digest_t dig[] =
{
{ &md2ctx, MD2_Init, MD2_Update, MD2_Final,
MD2_DIGEST_LENGTH, "MD2" },
{ &md4ctx, MD4_Init, MD4_Update, MD4_Final,
MD4_DIGEST_LENGTH, "MD4" },
{ &md5ctx, MD5_Init, MD5_Update, MD5_Final,
MD5_DIGEST_LENGTH, "MD5" },
{ &shactx, SHA_Init, SHA_Update, SHA_Final,
SHA_DIGEST_LENGTH, "SHA" },
{ &shactx, SHA1_Init, SHA1_Update, SHA1_Final,
SHA_DIGEST_LENGTH, "SHA1" },
{ &rmdctx, RIPEMD160_Init, RIPEMD160_Update, RIPEMD160_Final,
RIPEMD160_DIGEST_LENGTH, "RIPEMD160" }
};

this code will yield a "warning: initialization from incompatible
pointer type", on every Init, Update, and Final function in dig[].
these functions are all in the format:

void MD5_Init(MD5_CTX *c);
void MD5_Update(MD5_CTX *c, const void *data, unsigned long len);
void MD5_Final(unsigned char *md, MD5_CTX *c);

with different types for the context. short of writing a wrapper
function for each of these (or one smart wrapper function for them
all), is there a safe solution to fix these assignments? while i'm at
it, please post other corrections are you see fit to call them.

thanks,
joe
Nov 14 '05 #1
3 2951
On 30 Apr 2004 21:17:25 -0700, jo*******@hotmail.com (joe bruin)
wrote:
hello all.

i am trying to get rid of some warnings and do "the right thing".
although in this particular case, i am not sure what the right thing
is.

the code:

typedef struct
{
void *ctx;
void (*init)(void *);
Here you say the second member of the struct is a function pointer
whose argument is void*.
void (*update)(void *, const void *, unsigned long);
void (*final)(unsigned char *, void *);
int mdlen;
char *name;
} digest_t;

MD2_CTX md2ctx;
MD4_CTX md4ctx;
MD5_CTX md5ctx;
SHA_CTX shactx;
RIPEMD160_CTX rmdctx;

digest_t dig[] =
{
{ &md2ctx, MD2_Init, MD2_Update, MD2_Final,
MD2_DIGEST_LENGTH, "MD2" },
{ &md4ctx, MD4_Init, MD4_Update, MD4_Final,
MD4_DIGEST_LENGTH, "MD4" },
{ &md5ctx, MD5_Init, MD5_Update, MD5_Final,
MD5_DIGEST_LENGTH, "MD5" },
Here you initialize an instance of the struct and the second member is
initialized to the address of MD5_Init.
{ &shactx, SHA_Init, SHA_Update, SHA_Final,
SHA_DIGEST_LENGTH, "SHA" },
{ &shactx, SHA1_Init, SHA1_Update, SHA1_Final,
SHA_DIGEST_LENGTH, "SHA1" },
{ &rmdctx, RIPEMD160_Init, RIPEMD160_Update, RIPEMD160_Final,
RIPEMD160_DIGEST_LENGTH, "RIPEMD160" }
};

this code will yield a "warning: initialization from incompatible
pointer type", on every Init, Update, and Final function in dig[].
these functions are all in the format:

void MD5_Init(MD5_CTX *c);
But the function MD5_Init actually takes a pointer to MD5_CTX which
apparently is not the same as pointer to void.

When calling a function that expects a void*, you can pass any kind of
object pointer you want because the types are compatible for the
implied assignment of the argument to the parameter. Consider that
the following is legal because the implied conversion is allowed
void *x;
MD5_CTX y;
x = &y;

But a function taking a void* is not the same type as a function
taking a MD5_CTX*. More importantly, they are not compatible for the
implied assignment. Consider that the following is not legal because
the implied conversion is not allowed (you could cast but that is a
different story)
void (*func)(void*);
void MD5_Init(MD5_CTX *c);
func = MD5_INIT;

If you can't do it with an assignment, you can't do it with
initialization (excluding the obvious exception of initializing a char
array with a string which cannot be done with assignment).
void MD5_Update(MD5_CTX *c, const void *data, unsigned long len);
void MD5_Final(unsigned char *md, MD5_CTX *c);

with different types for the context. short of writing a wrapper
function for each of these (or one smart wrapper function for them
all), is there a safe solution to fix these assignments? while i'm at
it, please post other corrections are you see fit to call them.

Why not declare and define the functions to match the struct members
(take void* as arguments) and inside each function convert the void*
parameter to the correct pointer type. Something like
void MD5_Init(void *x){
MD5_CTX *c = x;
and the rest of your function body can remain unchanged.
<<Remove the del for email>>
Nov 14 '05 #2
On 30 Apr 2004 21:17:25 -0700, jo*******@hotmail.com (joe bruin)
wrote:
hello all.

i am trying to get rid of some warnings and do "the right thing".
although in this particular case, i am not sure what the right thing
is.

the code:

typedef struct
{
void *ctx;
void (*init)(void *);
Here you say the second member of the struct is a function pointer
whose argument is void*.
void (*update)(void *, const void *, unsigned long);
void (*final)(unsigned char *, void *);
int mdlen;
char *name;
} digest_t;

MD2_CTX md2ctx;
MD4_CTX md4ctx;
MD5_CTX md5ctx;
SHA_CTX shactx;
RIPEMD160_CTX rmdctx;

digest_t dig[] =
{
{ &md2ctx, MD2_Init, MD2_Update, MD2_Final,
MD2_DIGEST_LENGTH, "MD2" },
{ &md4ctx, MD4_Init, MD4_Update, MD4_Final,
MD4_DIGEST_LENGTH, "MD4" },
{ &md5ctx, MD5_Init, MD5_Update, MD5_Final,
MD5_DIGEST_LENGTH, "MD5" },
Here you initialize an instance of the struct and the second member is
initialized to the address of MD5_Init.
{ &shactx, SHA_Init, SHA_Update, SHA_Final,
SHA_DIGEST_LENGTH, "SHA" },
{ &shactx, SHA1_Init, SHA1_Update, SHA1_Final,
SHA_DIGEST_LENGTH, "SHA1" },
{ &rmdctx, RIPEMD160_Init, RIPEMD160_Update, RIPEMD160_Final,
RIPEMD160_DIGEST_LENGTH, "RIPEMD160" }
};

this code will yield a "warning: initialization from incompatible
pointer type", on every Init, Update, and Final function in dig[].
these functions are all in the format:

void MD5_Init(MD5_CTX *c);
But the function MD5_Init actually takes a pointer to MD5_CTX which
apparently is not the same as pointer to void.

When calling a function that expects a void*, you can pass any kind of
object pointer you want because the types are compatible for the
implied assignment of the argument to the parameter. Consider that
the following is legal because the implied conversion is allowed
void *x;
MD5_CTX y;
x = &y;

But a function taking a void* is not the same type as a function
taking a MD5_CTX*. More importantly, they are not compatible for the
implied assignment. Consider that the following is not legal because
the implied conversion is not allowed (you could cast but that is a
different story)
void (*func)(void*);
void MD5_Init(MD5_CTX *c);
func = MD5_INIT;

If you can't do it with an assignment, you can't do it with
initialization (excluding the obvious exception of initializing a char
array with a string which cannot be done with assignment).
void MD5_Update(MD5_CTX *c, const void *data, unsigned long len);
void MD5_Final(unsigned char *md, MD5_CTX *c);

with different types for the context. short of writing a wrapper
function for each of these (or one smart wrapper function for them
all), is there a safe solution to fix these assignments? while i'm at
it, please post other corrections are you see fit to call them.

Why not declare and define the functions to match the struct members
(take void* as arguments) and inside each function convert the void*
parameter to the correct pointer type. Something like
void MD5_Init(void *x){
MD5_CTX *c = x;
and the rest of your function body can remain unchanged.
<<Remove the del for email>>
Nov 14 '05 #3

In article <c6**********@216.39.135.16>, Barry Schwarz <sc******@deloz.net> writes:

Why not declare and define the functions to match the struct members
(take void* as arguments) and inside each function convert the void*
parameter to the correct pointer type. Something like
void MD5_Init(void *x){
MD5_CTX *c = x;
and the rest of your function body can remain unchanged.


There's at least one good reason not to do this: if the functions are
ever called directly, rather than through a digest_t variable,
they've lost type safety on the first parameter. It's easy to
imagine a cut-and-paste mistake that would pass an MD2_CTX* where an
MD4_CTX* was expected, for example.

In this particular case, it may be that the functions are only ever
invoked through the structure members, and so type safety on the
first parameter is moot; the structure has to lie about the type of
the first parameter in order to accomodate all the digest functions.

However, in general I'd consider this a case where I'd prefer to keep
the functions declared strictly and cast them when initializing
members of the array - if I did something like this at all. That's
assuming I knew that the implementation used interchangeable function
pointer representations for void (*)(void *) and void (*)(MD2_CTX *),
and so forth.

Alternatively, define wrappers for each of the three functions for
each of the digest types, which take a void* for the first parameter
and call the properly-declared, "public" version of the function.
That requires defining a bunch of wrappers, but you eliminate the
casts and maintain type safety if the functions are called directly.

Yet another - even safer - alternative is to create a wrapper type
for the various context types. The wrapper is a struct with an enum
identifying the context type and a union of the context types. All
the digest functions are changed to take a pointer to this new
wrapper structure and verify that the context is of the correct type.
That gives you a single function pointer type for digest_t and
run-time type safety, so that calls through digest_t variables are
type-checked.

--
Michael Wojcik mi************@microfocus.com

The way things were, were the way things were, and they stayed that way
because they had always been that way. -- Jon Osborne
Nov 14 '05 #4

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

3
by: ken | last post by:
I am getting this error from a gcc compile and I was wondering whether this was 100% valid. This seems a little extreme to me the c++ cast operators appear to only work on objects which defeats...
10
by: Dirk Vanhaute | last post by:
I have only small knowledge of c++, but I would like to compile the example in http://support.microsoft.com/kb/q246772/ HOWTO: Retrieve and Set the Default Printer in Windows I included "#include...
10
by: Barbrawl McBribe | last post by:
Is is possible to use typedefs to cast function pointers? I think I saw this in the WINGs src; grep for '(hashFunc)'. So far, trying to use a typedef to cast function pointers so that a return...
8
by: Mantorok Redgormor | last post by:
I have ran into a problem where I have a struct that has a member which contains a pointer to function and is initialized to a function in the initializer list. With my array of structs of this...
41
by: Alexei A. Frounze | last post by:
Seems like, to make sure that a pointer doesn't point to an object/function, NULL (or simply 0) is good enough for both kind of pointers, data pointers and function pointers as per 6.3.2.3: 3 An...
4
by: msolem | last post by:
I have some code where there are a set of functions that return pointers to each other. I'm having a bit of a hard time figuring out the correct type to use to do that. The code below works but...
3
by: Beta What | last post by:
Hello, I have a question about casting a function pointer. Say I want to make a generic module (say some ADT implementation) that requires a function pointer from the 'actual/other modules'...
5
by: WittyGuy | last post by:
How to typecast a "function pointer" to "const void*" type in C++ way? int MyFunction (double money); // Function prototype const void* arg = (const void*)MyFunction; // type casting...
20
by: MikeC | last post by:
Folks, I've been playing with C programs for 25 years (not professionally - self-taught), and although I've used function pointers before, I've never got my head around them enough to be able to...
7
by: ghulands | last post by:
I am having trouble implementing some function pointer stuff in c++ An object can register itself for many events void addEventListener(CFObject *target, CFEventHandler callback, uint8_t...
0
by: ryjfgjl | last post by:
ExcelToDatabase: batch import excel into database automatically...
0
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 6 Mar 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, we are pleased to welcome back...
1
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 6 Mar 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, we are pleased to welcome back...
0
by: Vimpel783 | last post by:
Hello! Guys, I found this code on the Internet, but I need to modify it a little. It works well, the problem is this: Data is sent from only one cell, in this case B5, but it is necessary that data...
0
by: jfyes | last post by:
As a hardware engineer, after seeing that CEIWEI recently released a new tool for Modbus RTU Over TCP/UDP filtering and monitoring, I actively went to its official website to take a look. It turned...
0
by: ArrayDB | last post by:
The error message I've encountered is; ERROR:root:Error generating model response: exception: access violation writing 0x0000000000005140, which seems to be indicative of an access violation...
1
by: PapaRatzi | last post by:
Hello, I am teaching myself MS Access forms design and Visual Basic. I've created a table to capture a list of Top 30 singles and forms to capture new entries. The final step is a form (unbound)...
0
by: Defcon1945 | last post by:
I'm trying to learn Python using Pycharm but import shutil doesn't work
0
by: af34tf | last post by:
Hi Guys, I have a domain whose name is BytesLimited.com, and I want to sell it. Does anyone know about platforms that allow me to list my domain in auction for free. Thank you

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.