473,221 Members | 1,736 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,221 software developers and data experts.

Linked List Problem(changing insertion pointer)

Hi All,

Here I have a linked list each containing a char and is double linked.
Then I have a pointer to an item in that list which is the current
insertion point.

In this funtion, the user hits the right
and left keys to move this insertion point (cursor)

Here is the problem:

But its not stable, the insertion point seems to skip an item
back, here and there. It could be the API Im using for the keyboard
input but Im not sure.

Thanks in advance for any help.
John

//a char structure, making a text string list
struct Word{
char *c;
struct Word *next,*back;
};
typedef struct Word Word;

Word *wrd;// a linked list of Word structures
Word *insert;// pointer to the current insertion point of *wrd

wrd = (allocate a list of Word structures)
insert = (pointer to an insertion point in the text in the *wrd list)

DoKey(insert,RIGHT_KEY);

/* etc */

void DoKey(struct Word *char_insert, int key){
switch(key){
case RIGHT_KEY:
if(char_insert->next!=NULL)
char_insert=char_insert->next;/* this is not fool proof,
any help? */
break;
case LEFT_KEY:
if(char_insert->back!=NULL)
char_insert=char_insert->back;/* this is not fool proof,
any help? */
break;
}
}
--
comp.lang.c.moderated - moderation address: cl**@plethora.net
Nov 14 '05 #1
5 6010
[Followups set to comp.lang.c - nothing personal, Seebs!]

John N. wrote:
Hi All,

Here I have a linked list each containing a char and is double linked.
Your code says char *, not char.
Then I have a pointer to an item in that list which is the current
insertion point. <...> But its not stable, the insertion point seems to skip an item
back, here and there. It could be the API Im using for the keyboard
input but Im not sure.
It's your misunderstanding of pointers, I'm afraid.
//a char structure, making a text string list
If you have a C99 compiler, // is legal comment syntax. Do you?
struct Word{
char *c;
struct Word *next,*back;
};
typedef struct Word Word;

Word *wrd;// a linked list of Word structures
Word *insert;// pointer to the current insertion point of *wrd

wrd = (allocate a list of Word structures)
This ain't gonna compile.
insert = (pointer to an insertion point in the text in the *wrd list)
Nor is this. Please remember, when posting code here, that by definition you
do not know where the problem is. So it's not a good idea to chop out
random chunks of it when asking for help.
DoKey(insert,RIGHT_KEY);

/* etc */

void DoKey(struct Word *char_insert, int key){
switch(key){
case RIGHT_KEY:
if(char_insert->next!=NULL)
char_insert=char_insert->next;/* this is not fool proof,
any help? */


C is pass-by-value.

void DoKey(struct Word **char_insert, int key)
{
switch(key)
{
case RIGHT_KEY:
if((*char_insert)->next != NULL)
{
*char_insert = (*char_insert)->next;
}
break;

case LEFT_KEY:
if((*char_insert)->back != NULL)
{
*char_insert = (*char_insert)->back;
}
break;
default:
/* unhandled key event */
break;
}
}

--
Richard Heathfield : bi****@eton.powernet.co.uk
"Usenet is a strange place." - Dennis M Ritchie, 29 July 1999.
C FAQ: http://www.eskimo.com/~scs/C-faq/top.html
K&R answers, C books, etc: http://users.powernet.co.uk/eton
--
comp.lang.c.moderated - moderation address: cl**@plethora.net
Nov 14 '05 #2
John N. wrote:
Here I have a linked list each containing a char and is double linked.
Then I have a pointer to an item in that list which is the current
insertion point.

In this function, the user hits the right
and left keys to move this insertion point (cursor)

Here is the problem:

But its not stable, the insertion point seems to skip an item
back, here and there. It could be the API Im using for the keyboard
input but Im not sure.
No, it isn't likely to be that.
Thanks in advance for any help.
John

//a char structure, making a text string list
struct Word{
char *c;
struct Word *next,*back;
};
typedef struct Word Word;

Word *wrd;// a linked list of Word structures
Word *insert;// pointer to the current insertion point of *wrd

wrd = (allocate a list of Word structures)
And how is this data structure initialized? Zero pointers, or
pointers to itself (a circular list)? Or are you allocating and
initializing a whole bunch of Word structures, and putting them into a
valid linked list?
insert = (pointer to an insertion point in the text in the *wrd list)
So, presumably this is a contraction for 'insert = wrd;'? If not, you
need to show the initialization, since without the initialization, it
is hard to tell what the heck you might be doing.
DoKey(insert,RIGHT_KEY);
You've not shown where the character is coming from. I know you said
the keyboard, but which variable contains the value? Or is the
'RIGHT_KEY' -- presumably a macro since it is in upper case -- the
value purportedly to be inserted?
/* etc */

void DoKey(struct Word *char_insert, int key){
switch(key){
case RIGHT_KEY:
if(char_insert->next!=NULL)
char_insert=char_insert->next;/* this is not fool proof,
any help? */
break;
With a doubly-linked list, when you insert a new node, you allocate
the new node and populate the data portion (c) with the data for the
node. Then, assuming that the new node is inserted after the
insertion point, you ensure that the next pointer of the new node
points to the node that the insertion point points to as the next
node, that the back pointer of the next node points to the new node,
that the back pointer of the new node points to where the back pointer
of the insertion pointer points, and the next pointer of the back node
points to the new node. You might or might not also adjust the
insertion point. The sequence is similar but different if the new
node goes before the insertion point.

You've not shown very much of any of this material. You don't
allocate new nodes and you don't fix up the pre-existing nodes.
case LEFT_KEY:
if(char_insert->back!=NULL)
char_insert=char_insert->back;/* this is not fool proof,
any help? */
break;
}
}


Any more help? Draw a diagram! Draw a lot of diagrams! And make
sure all your pointers are initialized.

Finally, a member 'char *c' is misleading (but not, I hasten to
emphasize, wrong). In general, a variable c is a single character,
not a pointer to a character. There are various possible names that
would be happier choices - s or p are primary options, and there are a
myriad others. From the code you show, it is impossible to deduce
whether you store pointers to null-terminated strings or pointers to
single characters in it - you don't show it being used at all, in fact.

Given your problem description, you might be better off using c as a
simple char - though a doubly linked list of single characters is an
incredibly heavy-weight structure (typically occupying 12 bytes per
character).

Another reading of your problem might be that you are wondering why
the value of 'insert' in the calling code is not modified by the code
in DoKey -- and the answer is because you don't pass insert as a
pointer to a Word pointer. This only applies if you are already sure
you've built your doubly-linked list correctly, which is (as far as
anyone can see) debatable.

--
Jonathan Leffler #include <disclaimer.h>
Email: jl******@earthlink.net, jl******@us.ibm.com
Guardian of DBD::Informix v2003.04 -- http://dbi.perl.org/
--
comp.lang.c.moderated - moderation address: cl**@plethora.net
Nov 14 '05 #3
"John N." <st*******@yahoo.com> wrote in

struct Word{
char *c;
struct Word *next,*back;
};
typedef struct Word Word;

Run the following function

void integrity_test(Word *head)
{
Word *prev = NULL:
printf("Start\n");
while(head)
{
printf("%s\n", head->c);
prev = head;
head = head->next;
}
printf("End\n");
while(prev)
{
printf("%s\n", prev->c);
prev = prev->back;
}
}

This should expose problems with the linked list structure.
--
comp.lang.c.moderated - moderation address: cl**@plethora.net
Nov 14 '05 #4
On 28 Dec 2003 06:39:31 GMT, st*******@yahoo.com (John N.) wrote:
Hi All,

Here I have a linked list each containing a char and is double linked.
Then I have a pointer to an item in that list which is the current
insertion point.

In this funtion, the user hits the right
and left keys to move this insertion point (cursor)

Here is the problem:

But its not stable, the insertion point seems to skip an item
back, here and there. It could be the API Im using for the keyboard
input but Im not sure.

Thanks in advance for any help.
John

//a char structure, making a text string list
struct Word{
char *c;
struct Word *next,*back;
};
typedef struct Word Word;

Word *wrd;// a linked list of Word structures
Word *insert;// pointer to the current insertion point of *wrd

wrd = (allocate a list of Word structures)
insert = (pointer to an insertion point in the text in the *wrd list)

DoKey(insert,RIGHT_KEY);

/* etc */

void DoKey(struct Word *char_insert, int key){
switch(key){
case RIGHT_KEY:
if(char_insert->next!=NULL)
char_insert=char_insert->next;/* this is not fool proof,
any help? */
break;
case LEFT_KEY:
if(char_insert->back!=NULL)
char_insert=char_insert->back;/* this is not fool proof,
any help? */
break;
}
}


The real question is why do you think it worked at all. The
char_insert variable inside your function is not the same variable you
defined near the top of your code.

Your function performs all of its assignments to a local variable
(actually a parameter which, since C passes by value, is a copy of the
argument and not the argument itself). When the function exits, all
local variables (other than static) are destroyed. The result of your
function's assignments are never communicated back to the calling
function.
<<Remove the del for email>>
--
comp.lang.c.moderated - moderation address: cl**@plethora.net
Nov 14 '05 #5
> >//a char structure, making a text string list
struct Word{
char *c;
struct Word *next,*back;
};
typedef struct Word Word;

Word *wrd;// a linked list of Word structures
Word *insert;// pointer to the current insertion point of *wrd

wrd = (allocate a list of Word structures)
insert = (pointer to an insertion point in the text in the *wrd list)

DoKey(insert,RIGHT_KEY);

/* etc */

void DoKey(struct Word *char_insert, int key){
switch(key){
case RIGHT_KEY:
if(char_insert->next!=NULL)
char_insert=char_insert->next;/* this is not fool proof,
any help? */
break;
case LEFT_KEY:
if(char_insert->back!=NULL)
char_insert=char_insert->back;/* this is not fool proof,
any help? */
break;
}
}


The real question is why do you think it worked at all. The
char_insert variable inside your function is not the same variable you
defined near the top of your code.

Your function performs all of its assignments to a local variable
(actually a parameter which, since C passes by value, is a copy of the
argument and not the argument itself). When the function exits, all
local variables (other than static) are destroyed. The result of your
function's assignments are never communicated back to the calling
function.


Hi All, Thanks for the quick responses.

I posted a shorter example of my code. The problem turned out to be
my switch/case statement that handled key input (not posted here) and
the insertion pointer was being misshandled.
--
comp.lang.c.moderated - moderation address: cl**@plethora.net
Nov 14 '05 #6

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

7
by: OMouse | last post by:
Hi, I just switched to using STL for my linked lists and obviously I need a way to insert. I have all the necessary includes (list & algorithm) and the other functions that I've used (erase & find)...
6
by: Randy Bush | last post by:
i am trying to insert into a singly linked list hold = self.next self.next = DaClass(value) self.next.next = hold but i suspect (from print statement insertions) that the result is not as i...
3
by: Tom Timmermann | last post by:
In the process of building a link list, I noticed that successive calls to malloc() return a pointer address that keeps getting larger. Can I always count on this behavior and so do pointer...
7
by: Doug Stell | last post by:
I am having a problem with the corruption of a list. It occurs only the first time that I call a function and never happens on subsequent calls. Any suggestions would be appreciated. I call the...
3
by: Suyash Upadhyay | last post by:
Hello All, I am a beginner of C Programming, I am working on linked list now-a-days, i have successfully created a linked list and displayed, but when i tried to insert an element in mid of linked...
4
by: eight02645999 | last post by:
hi i have a list (after reading from a file), say data = I wanted to insert a word after every 'a', and before every 'd'. so i use enumerate this list: for num,item in enumerate(data): if...
0
by: Chuckk Hubbard | last post by:
I solved this problem. I still don't understand why, but it seems Python was appending a reference to the first element at the end of the list, rather than copying the data. I used something...
1
by: Chuckk Hubbard | last post by:
Hello. This program is clunky, I know; I'm not a programmer, but I need to use this program, so I'm writing it. The problem: I have a cursor following the mouse that shows frequency ratios of...
8
by: mike_solomon | last post by:
I have a button <input type="submit" name="Delete" value="Delete"> This code can not be changed I want to use Javascript to change the type I tried:
1
isladogs
by: isladogs | last post by:
The next online meeting of the Access Europe User Group will be on Wednesday 6 Dec 2023 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, Mike...
0
by: VivesProcSPL | last post by:
Obviously, one of the original purposes of SQL is to make data query processing easy. The language uses many English-like terms and syntax in an effort to make it easy to learn, particularly for...
0
by: jianzs | last post by:
Introduction Cloud-native applications are conventionally identified as those designed and nurtured on cloud infrastructure. Such applications, rooted in cloud technologies, skillfully benefit from...
0
by: abbasky | last post by:
### Vandf component communication method one: data sharing ​ Vandf components can achieve data exchange through data sharing, state sharing, events, and other methods. Vandf's data exchange method...
0
by: fareedcanada | last post by:
Hello I am trying to split number on their count. suppose i have 121314151617 (12cnt) then number should be split like 12,13,14,15,16,17 and if 11314151617 (11cnt) then should be split like...
0
by: stefan129 | last post by:
Hey forum members, I'm exploring options for SSL certificates for multiple domains. Has anyone had experience with multi-domain SSL certificates? Any recommendations on reliable providers or specific...
0
Git
by: egorbl4 | last post by:
Скачал я git, хотел начать настройку, а там вылезло вот это Что это? Что мне с этим делать? ...
1
by: davi5007 | last post by:
Hi, Basically, I am trying to automate a field named TraceabilityNo into a web page from an access form. I've got the serial held in the variable strSearchString. How can I get this into the...
0
by: MeoLessi9 | last post by:
I have VirtualBox installed on Windows 11 and now I would like to install Kali on a virtual machine. However, on the official website, I see two options: "Installer images" and "Virtual machines"....

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.