#include <stdio.h>
#include <unistd.h>
#include <string.h>
#include <stdlib.h>
#define MAX 256
#define CMD_MAX 10
char *valid_cmds = " ls ps df ";
int main (void) {
char line_input[MAX], the_cmd[CMD_MAX];
char *new_args[CMD_MAX], *cp;
int i;
while(1) {
printf ("cmd> ");
if (gets(line_input ) != NULL) {
cp = line_input;
i = 0;
if ((new_args[i] =strtok(cp, " " )) != NULL) {
sprintf(the_cmd, "%s ", new_args[i]);
if((strstr(valid_cmds,the_cmd) - valid_cmds) % 4 == 1) {
do {
++i;
cp = NULL;
new_args[i] = strtok(cp, " ");
} while (i < CMD_MAX -1 && new_args[i] != NULL);
new_args[i] =NULL;
switch (fork( )) {
case 0:
execvp(new_args[0], new_args);
perror("exec failure");
exit(1);
case -1:
perror("fork failure");
break;
default:
;
}
} else
printf("huh?\n");
}
}
}
}
the code above is taken from a unix system programming book, i compile
the code in red hat 9 and error message came out. can someone tell me
how to make the code work any help will be appreciated.
make -k shell
cc shell.c -o shell
/tmp/ccOmPIMu.o(.text+0x2f): In function `main':
: the `gets' function is dangerous and should not be used.
14  7646 
<jo****@yahoo.com> wrote in message
news:e9**************************@posting.google.c om... Re: problem with gets
'gets()' *is* the problem. Don't use it.
There is no way to use it safely.
Use 'fgets()' instead.
#include <stdio.h>
#include <unistd.h>
#include <string.h>
#include <stdlib.h>
#define MAX 256
#define CMD_MAX 10
char *valid_cmds = " ls ps df ";
int main (void) {
char line_input[MAX], the_cmd[CMD_MAX];
char *new_args[CMD_MAX], *cp;
int i;
while(1) {
printf ("cmd> ");
if (gets(line_input ) != NULL) {
cp = line_input;
i = 0;
if ((new_args[i] =strtok(cp, " " )) != NULL) {
sprintf(the_cmd, "%s ", new_args[i]);
if((strstr(valid_cmds,the_cmd) - valid_cmds) % 4 == 1) {
do {
++i;
cp = NULL;
new_args[i] = strtok(cp, " ");
} while (i < CMD_MAX -1 && new_args[i] != NULL);
new_args[i] =NULL;
switch (fork( )) {
case 0:
execvp(new_args[0], new_args);
perror("exec failure");
exit(1);
case -1:
perror("fork failure");
break;
default:
;
}
} else
printf("huh?\n");
}
}
}
}
the code above is taken from a unix system programming book, i compile
the code in red hat 9 and error message came out. can someone tell me
how to make the code work any help will be appreciated.
I don't think that's an 'error' message, but a 'warning'
message. Did the compiler refuse to translate your code?
make -k shell
cc shell.c -o shell
/tmp/ccOmPIMu.o(.text+0x2f): In function `main':
: the `gets' function is dangerous and should not be used.
This is an accurate assessment. Use 'fgets()' instead.
-Mike
<jo****@yahoo.com> wrote in message
: the `gets' function is dangerous and should not be used.
Just replacing gets() with fgets() swaps undefined behaviour for incorrect
behaviour, which will shut up the compiler (since it doesn't know the
purpose of the program) but will help no-one.
You need a strategy that will warn the user if the line entered is too
long - presumably if its over 256 characters in length in must be garbage -
and discard it.
all though you should not use the gets function you can still run the program
i get the same message when i use the gets function.
I use it just to see what happens I use suse 8.2
Malcolm wrote: <jo****@yahoo.com> wrote in message
: the `gets' function is dangerous and should not be used.
Just replacing gets() with fgets() swaps undefined behaviour for incorrect
behaviour, which will shut up the compiler (since it doesn't know the
purpose of the program) but will help no-one.
You need a strategy that will warn the user if the line entered is too
long - presumably if its over 256 characters in length in must be garbage -
and discard it.
Simply using ggets retains the simplicity of gets, removes the
trailing \n, but requires the user to realize that the returned
line must be eventually freed. Available at:
<http://cbfalconer.home.att.net/download/>
--
Chuck F (cb********@yahoo.com) (cb********@worldnet.att.net)
Available for consulting/temporary embedded and systems.
<http://cbfalconer.home.att.net> USE worldnet address!
In article <bi**********@chessie.cirr.com>, at***@nospam.cyberspace.org
says... CBFalconer <cb********@yahoo.com> broke the eternal silence and spoke thus:
Simply using ggets retains the simplicity of gets, removes the
trailing \n, but requires the user to realize that the returned
line must be eventually freed. Available at:
What is ggets?
Why didn't you just follow the link and find out??? at***@nospam.cyberspace.org wrote: CBFalconer <cb********@yahoo.com> wrote:
Simply using ggets retains the simplicity of gets, removes the
trailing \n, but requires the user to realize that the returned
line must be eventually freed. Available at:
What is ggets?
You stripped the link. Download it and see. It is not large. It
is a safe alternative to gets.
--
Chuck F (cb********@yahoo.com) (cb********@worldnet.att.net)
Available for consulting/temporary embedded and systems.
<http://cbfalconer.home.att.net> USE worldnet address!
"Malcolm" <ma*****@55bank.freeserve.co.uk> wrote in message news:<bi**********@newsg3.svr.pol.co.uk>... <jo****@yahoo.com> wrote in message
: the `gets' function is dangerous and should not be used.
Just replacing gets() with fgets() swaps undefined behaviour for incorrect
behaviour, which will shut up the compiler (since it doesn't know the
purpose of the program) but will help no-one.
You need a strategy that will warn the user if the line entered is too
long - presumably if its over 256 characters in length in must be garbage -
and discard it.
i have try to use fgets and can't make it work, can some one help me with this?
thanks in advance
<jo****@yahoo.com> wrote in message
news:e9**************************@posting.google.c om... "Malcolm" <ma*****@55bank.freeserve.co.uk> wrote in message
news:<bi**********@newsg3.svr.pol.co.uk>... <jo****@yahoo.com> wrote in message
: the `gets' function is dangerous and should not be used.
Just replacing gets() with fgets() swaps undefined behaviour for
incorrect behaviour, which will shut up the compiler (since it doesn't know the
purpose of the program) but will help no-one.
You need a strategy that will warn the user if the line entered is too
long - presumably if its over 256 characters in length in must be
garbage - and discard it.
i have try to use fgets and can't make it work, can some one help me with
this?
Sure, many people, including myself, are willing and able
to help you with it. As soon as you show us the code you
need help with. When you post it, remember to ask specific
questions.
-Mike
Mike Wahler wrote: <jo****@yahoo.com> wrote in message
.... snip ...
i have try to use fgets and can't make it work, can some one
help me with this?
Sure, many people, including myself, are willing and able
to help you with it. As soon as you show us the code you
need help with. When you post it, remember to ask specific
questions.
He did, and we did.
--
Chuck F (cb********@yahoo.com) (cb********@worldnet.att.net)
Available for consulting/temporary embedded and systems.
<http://cbfalconer.home.att.net> USE worldnet address! jo****@yahoo.com (jo****@yahoo.com) wrote in message news:<e9**************************@posting.google. com>... "Malcolm" <ma*****@55bank.freeserve.co.uk> wrote in message news:<bi**********@newsg3.svr.pol.co.uk>... <jo****@yahoo.com> wrote in message
: the `gets' function is dangerous and should not be used.
Just replacing gets() with fgets() swaps undefined behaviour for incorrect
behaviour, which will shut up the compiler (since it doesn't know the
purpose of the program) but will help no-one.
You need a strategy that will warn the user if the line entered is too
long - presumably if its over 256 characters in length in must be garbage -
and discard it.
i have try to use fgets and can't make it work, can some one help me with this?
thanks in advance
sure. what seems to be the problem ?
goose,
"Mike Wahler" <mk******@mkwahler.net> wrote in message news:<ao****************@newsread3.news.pas.earthl ink.net>... Sure, many people, including myself, are willing and able
to help you with it. As soon as you show us the code you
need help with. When you post it, remember to ask specific
questions.
sorry for not making it clear at the first time, the code below should
have executed the ls or ps or df if user enter then, other command
will return huh?.
the problem is that when is run the program all command entered will
return huh?.
#include <stdio.h>
#include <unistd.h>
#include <string.h>
#include <stdlib.h>
#define MAX 256
#define CMD_MAX 10
char *valid_cmds = "ls ps df";
int main (void) {
char line_input[MAX], *l;
char the_cmd[CMD_MAX];
char *new_args[CMD_MAX], *cp;
int i;
while(1) {
printf ("cmd> ");
fgets(line_input, sizeof line_input, stdin);
if((l=strchr(line_input, '\n')) != NULL)
*l='\0';
if (l != NULL) {
cp = l;
i = 0;
if ((new_args[i] =strtok(cp, " " )) != NULL) {
sprintf(the_cmd, "%s ", new_args[i]);
if((strstr(valid_cmds,the_cmd) - valid_cmds) % 4 == 1) {
do {
++i;
cp = NULL;
new_args[i] = strtok(cp, " ");
} while (i < CMD_MAX -1 && new_args[i] != NULL);
new_args[i] =NULL;
switch (fork( )) {
case 0:
execvp(new_args[0], new_args);
perror("exec failure");
exit(1);
case -1:
perror("fork failure");
break;
default:
;
}
} else
printf("huh?\n");
}
}
}
} jo****@yahoo.com (jo****@yahoo.com) wrote in message news:<e9**************************@posting.google. com>... #include <stdio.h>
#include <unistd.h>
#include <string.h>
#include <stdlib.h>
#define MAX 256
#define CMD_MAX 10
char *valid_cmds = " ls ps df ";
int main (void) {
char line_input[MAX], the_cmd[CMD_MAX];
char *new_args[CMD_MAX], *cp;
int i;
while(1) {
printf ("cmd> ");
if (gets(line_input ) != NULL) {
Replace the call to gets() with the following:
if (fgets (line_input, sizeof line_input, stdin) != NULL)
{
if (strchr (line_input, '\n'))
*strchr (line_input, '\n') = 0;
else
{
printf ("Command line too long\n");
while (!strchr (line_input, '\n'))
fgets (line_input, sizeof line_input, stdin);
exit(1);
}
Reason: if someone enters a command line longer than MAX, gets() will
write those extra characters to memory following the line_input
buffer, which may cause a crash or weird behavior (worms typically
exploit buffer overruns to propagate). fgets() will cap the number of
characters written to line_input to MAX - 1. Unlike gets(), fgets()
stores the trailing '\n' character to the buffer if there is room, so
we need to check for it using strchr() (be sure to #include
<string.h>). If it's in the buffer, set it to 0 (string terminator).
If not, the line was too long to store in the buffer, so we reject it
and print an error message. The code that consumes the remaining
input isn't strictly necessary if we're just going to exit anyway, but
it's a good practice to clean out the input buffer anyway.
cp = line_input;
i = 0;
if ((new_args[i] =strtok(cp, " " )) != NULL) {
sprintf(the_cmd, "%s ", new_args[i]);
if((strstr(valid_cmds,the_cmd) - valid_cmds) % 4 == 1) {
do {
++i;
cp = NULL;
new_args[i] = strtok(cp, " ");
} while (i < CMD_MAX -1 && new_args[i] != NULL);
new_args[i] =NULL;
switch (fork( )) {
case 0:
execvp(new_args[0], new_args);
perror("exec failure");
exit(1);
case -1:
perror("fork failure");
break;
default:
;
}
} else
printf("huh?\n");
}
}
}
}
the code above is taken from a unix system programming book,
Frankly, that worries me. Using gets() has been *known* to introduce
a point of failure in C code for quite a while now (remember the
Morris worm in 1988?), and it's *still* being presented as a
reasonable practice in system programming books. I can't believe any
book written after 1990 would still use it.
gets() is evil.
i compile
the code in red hat 9 and error message came out. can someone tell me
how to make the code work any help will be appreciated.
make -k shell
cc shell.c -o shell
/tmp/ccOmPIMu.o(.text+0x2f): In function `main':
: the `gets' function is dangerous and should not be used.
the code below will execute ls but not the other two function, what is
wrong with the code?
#include <stdio.h>
#include <unistd.h>
#include <string.h>
#include <stdlib.h>
#define MAX 256
#define CMD_MAX 10
char *valid_cmds = "ls ps df";
int main (void) {
char line_input[MAX], *l;
char the_cmd[CMD_MAX];
char *new_args[CMD_MAX], *cp;
int i;
while(1) {
printf ("cmd> ");
fgets(line_input, sizeof line_input, stdin);
if((l=strchr(line_input, '\n')) != NULL)
*l='\0';
if (l != NULL) {
cp = l;
i = 0;
if ((new_args[i] =strtok(cp, " " )) != NULL) {
sprintf(the_cmd, "%s ", new_args[i]);
if((strstr(valid_cmds,the_cmd) - valid_cmds) % 4 == 1) {
do {
++i;
cp = NULL;
new_args[i] = strtok(cp, " ");
} while (i < CMD_MAX -1 && new_args[i] != NULL);
new_args[i] =NULL;
switch (fork( )) {
case 0:
execvp(new_args[0], new_args);
perror("exec failure");
exit(1);
case -1:
perror("fork failure");
break;
default:
;
}
} else
printf("huh?\n");
}
}
}
}
i have changed some part of the program but it only work for "ls". why
"ps" and "df" does not work?
#include <stdio.h>
#include <unistd.h>
#include <string.h>
#include <stdlib.h>
#define MAX 256
#define CMD_MAX 10
char *valid_cmds = " ls ps df ";
int main (void) {
char line_input[MAX], the_cmd[CMD_MAX];
char *new_args[CMD_MAX], *cp;
int i;
while(1) {
printf ("cmd> ");
fflush(stdout);
if (gets(line_input ) != NULL) {
cp = line_input;
i = 0;
if ((new_args[i] =strtok(cp, " " )) != NULL) {
sprintf(the_cmd, "%s ", new_args[i]);
if((strstr(valid_cmds,the_cmd) - valid_cmds) % 4 == 1) {
do {
++i;
cp = NULL;
new_args[i] = strtok(cp, " ");
} while (i < CMD_MAX -1 && new_args[i] != NULL);
new_args[i] =NULL;
switch (fork( )) {
case 0:
execvp(new_args[0], new_args);
perror("exec failure");
exit(1);
case -1:
perror("fork failure");
break;
default:
;
}
} else
printf("huh?\n");
}
}
}
return 0;
}
This thread has been closed and replies have been disabled. Please start a new discussion. Similar topics
by: hiisikukko |
last post by:
I have created project management software with Java and MySql and i
works fine.
This applet gets and writes information directly to MySql database.
Problem is that those sqlClauses below(update...
|
by: vinayak |
last post by:
Hi
I am displaying data in Datagrid in ASP.NET with
Edit/Update functionality for each row. On the same page I
have 2 Button controls which submits the request to
server. These button controls...
|
by: Multithreading problem in vb.net |
last post by:
Greetings,
I am new to multithreading and I am trying to implement it in my app.
This application is distributed application which needs to refresh
every say 5 secs to show some activities in...
|
by: Gaijinco |
last post by:
Hi! I was coding something which had some lines like these:
int main(){
int n;
scanf("%d",&n);
fflush(stdin);
int* ans = new int;
int idx=0;
|
by: Nacho |
last post by:
Hello people
I have the following problem
I have a private area in my site.
The user enters the username and password, then clicks "enter" and the
session is created and also a session...
|
by: Zulander |
last post by:
Hi,
have a problem with comparing text in my function for some reason my
code get hang at fgets.
i am uploading this code in an IC, but i have isolated the problem to
fgets(SettingInfo);
could...
|
by: Mahesh Devjibhai Dhola |
last post by:
Hi,
Scenario:
The webservice was developed on windows 2000 Pro and deployed previously on windows XP pro for testing. We have tested for many days. The client for that service was 30+ and...
|
by: Vasu |
last post by:
Hi! Can anybody there help me in analysis of the following code, which
is a structure of customer's details, asks user to fill in the no. of
customers and then their details. When I put in no. of...
|
by: =?Utf-8?B?dGhlamFja29mYWxs?= |
last post by:
I have a few global variables and a function that gets called multiple times
to complete a single transaction and uses the variables. The function gets
different notifications. When the function...
|
by: Faith0G |
last post by:
I am starting a new it consulting business and it's been a while since I setup a new website. Is wordpress still the best web based software for hosting a 5 page website? The webpages will be...
|
by: isladogs |
last post by:
The next Access Europe User Group meeting will be on Wednesday 3 Apr 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM).
In this session, we are pleased to welcome former...
|
by: taylorcarr |
last post by:
A Canon printer is a smart device known for being advanced, efficient, and reliable. It is designed for home, office, and hybrid workspace use and can also be used for a variety of purposes. However,...
|
by: Charles Arthur |
last post by:
How do i turn on java script on a villaon, callus and itel keypad mobile phone
|
by: aa123db |
last post by:
Variable and constants
Use var or let for variables and const fror constants.
Var foo ='bar';
Let foo ='bar';const baz ='bar';
Functions
function $name$ ($parameters$) {
}
...
|
by: ryjfgjl |
last post by:
In our work, we often receive Excel tables with data in the same format. If we want to analyze these data, it can be difficult to analyze them because the data is spread across multiple Excel files...
|
by: emmanuelkatto |
last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud.
Please let me know.
Thanks!
Emmanuel
|
by: BarryA |
last post by:
What are the essential steps and strategies outlined in the Data Structures and Algorithms (DSA) roadmap for aspiring data scientists? How can individuals effectively utilize this roadmap to progress...
|
by: Hystou |
last post by:
There are some requirements for setting up RAID:
1. The motherboard and BIOS support RAID configuration.
2. The motherboard has 2 or more available SATA protocol SSD/HDD slots (including MSATA, M.2...
| |
