473,320 Members | 1,957 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,320 software developers and data experts.

Forward declaration & incomplete template type

Consider a first version:

--- drawable.hpp ---
#include "gcdata.hpp"
struct drawable {
...
virtual int internal_new_GC(gcdata * gcd) = 0 ;
} ;

--- gcdata.hpp ---
#include "device.hpp"
struc gcdata {
...
device * d ;
} ;

--- device.hpp ---
#include "drawable.hpp"
struct device : public drawable {
...
}

Obviously, this doesn't compile, because the "include stack",
at the point where ``struct device : public drawable'' is
reached, looks like
...drawable.hpp
.... gcdata.hpp [drawable.hpp line 2]
..... device.hpp [gcdata.hpp] line 2]
which means that. at the point where the ``struct device'' is
reached [device.hpp line 3], the struct drawable has not been
defined yet.

The fix is to rewrite gcdata with a forward declaration:
--- gcdata.hpp ---
// do NOT #include "device.hpp"
struct device ;
struc gcdata {
...
device * d ;
} ;

So far, so good.

Now, I'm not using direct pointers, but "smart" pointers

--- drawable.hpp ---
#include "gcdata.hpp"
struct drawable {
...
virtual int internal_new_GC(GCData gcd) = 0 ;
} ;
typedef envelope<drawable> Drawable ;

--- gcdata.hpp ---
#include "device.hpp"
struc gcdata {
...
Device d ;
} ;
typedef envelope<gcdata> GCData ;

--- device.hpp ---
#include "drawable.hpp"
struct device : public drawable {
...
}
typedef envelope<device> Device ;

And now I'm stuck, because the envelope template (which
is extremely close to boost::shared_ptr/bost_instrusive_ptr)
has this requirement that T must be a complete type, not a forward
declaration.

Hence, the "fix"

--- gcdata.hpp ---
// do NOT #include "device.hpp"
struct device ;
typedef envelope<device> Device ;
struc gcdata {
...
Device d ;
} ;

does NOT compile ...

Apart from tinkering with envelope<T> so that it doesn't
require a complete type (which may or may not be possible),
anyone sees a way out of this conundrum?

[BTW: this is a port of Java code: I can change the design
in only very minor ways, so the requirement that device
inherits from drawable that uses gcdata that needs device
has to stay]

Many Thanks
--
JFB


Jul 23 '05 #1
2 2370
verec wrote:
[... forward-declaration doesn't work when instantiating templates...]
Apart from tinkering with envelope<T> so that it doesn't
require a complete type (which may or may not be possible),
anyone sees a way out of this conundrum?
Nope. You're truly stuck. Let's put your code in one module:
---------------------------------------------------------------
template<class A> class TA {}; // your 'envelope'

struct Data; // forward-declare it...

struct Base { // OK, let's try to define it
void foo(TA<Data>); // OOPS! not allowed
};

struct Derived : Base { }; // OK, need it here

class Data {
TA<Base> tb; // OK, Base and Derived are defined
};
---------------------------------------------------------------
Oh, wait, maybe we could rearrange it a bit...
---------------------------------------------------------------
template<class A> class TA {}; // your 'envelope'

struct Base; // forward-declare it...

class Data {
TA<Base> tb; // OOPS! Can't do that
};

struct Base { // OK, let's try to define it
void foo(TA<Data>); // OK, Data is defined
};

struct Derived : Base { }; // OK
---------------------------------------------------------------

No matter how you move things around, you're faced with something
that would require an instantiation of a template from a type that
hasn't been defined yet.

You will need to go back to a pointer or a reference in one of
those classes. That means redesign.

Are you sure that you need to pass an "envelope" to the function
of your 'drawable' class?
[..]


V
Jul 23 '05 #2
On 2005-06-25 14:32:24 +0100, "Victor Bazarov" <v.********@comAcast.net> said:
verec wrote:
[... forward-declaration doesn't work when instantiating templates...]
Apart from tinkering with envelope<T> so that it doesn't
require a complete type (which may or may not be possible),
anyone sees a way out of this conundrum?
[...] No matter how you move things around, you're faced with something
that would require an instantiation of a template from a type that
hasn't been defined yet.
First, thank you Victor, for taking the time to understand the issue.
Are you sure that you need to pass an "envelope" to the function
of your 'drawable' class?


Well ... yes. The choices I seem to be left with are:

1. redesign the code so as to eliminate circular dependencies.
2. use raw pointers in at least parts of the code
3. rework envelope

1. is next to impossible. I'm porting, not redesigning a whole
system from scratch. That would completely change the nature
of the project. Given that the port itself, without redesign,
is already a huge task, choosing this path would mean the
project death. I simly do not have the 6 years ahead of me
to complete it :(

2. If #3 fails, I will very reluctantly pursue this path.

3. Seems the least bad compromise. I tried:

--- gcdata.hpp ---
template <typename T> struct Test {
T * body ;
Test(T * q = 0) : body(q) {}
} ;

struct device ;
// typedef envelope<device> Device ;
typedef Test<device> TDevice ;
struct gcdata {
// Device dev ;
TDevice tdev ;
} ;

typedef envelope<gcdata> GCData ;

And this does compile, probably because the Test<T> template only
deals with T * and never with T's. But I fear that the conversion
of envelope<T> might not be as simple ...

Many thanks for your time
--
JFB

Jul 23 '05 #3

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

11
by: Alexander Grigoriev | last post by:
Not quite new version of GCC that I have to use, craps with the following code: enum E; enum E { e }; That is, it doesn't accept forward declaration of enum. C++ standard text doesn't...
2
by: jobseeker | last post by:
From: jobseeker95479@yahoo.com (jobseeker) Newsgroups: comp.lang.c++.moderated Subject: template and forward declaration NNTP-Posting-Host: 131.233.150.22 I have defined a class that contains a...
6
by: Markus Dehmann | last post by:
I have a circular dependency between two classes. The FAQ hint about a forward declaration does not help in my case ( How can I create two classes that both know about each other?) Error:...
11
by: Milind | last post by:
Hi, I was trying to implement a composition relation, somthing of the following type: class A { public: class B {
23
by: mark.moore | last post by:
I know this has been asked before, but I just can't find the answer in the sea of hits... How do you forward declare a class that is *not* paramaterized, but is based on a template class? ...
7
by: Noah Roberts | last post by:
I have something like the following: template<ENUM X, int I = 0> class Generic { .... }; typedef Generic<Val1> v1_type; typedef Generic<Val2> v2_type;
11
by: Martin Eisenberg | last post by:
Hi Antoine, just redirecting you... Antoine Trux wrote: > Hi, > > Is the following code legal: > > ------> code starts here <------ > #include <stddef.h>
6
by: Hunk | last post by:
Hi I have a question on usage of forward declarations of templates. While searching through this group , people suggested using forward declarations and typedefs for templates as // in...
8
by: Mohammad Omer Nasir | last post by:
Hi, i made a structure in header file "commonstructs.h" is: typedef struct A { int i; A( ) {
0
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 6 Mar 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, we are pleased to welcome back...
1
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 6 Mar 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, we are pleased to welcome back...
0
by: Vimpel783 | last post by:
Hello! Guys, I found this code on the Internet, but I need to modify it a little. It works well, the problem is this: Data is sent from only one cell, in this case B5, but it is necessary that data...
1
by: PapaRatzi | last post by:
Hello, I am teaching myself MS Access forms design and Visual Basic. I've created a table to capture a list of Top 30 singles and forms to capture new entries. The final step is a form (unbound)...
1
by: CloudSolutions | last post by:
Introduction: For many beginners and individual users, requiring a credit card and email registration may pose a barrier when starting to use cloud servers. However, some cloud server providers now...
1
by: Defcon1945 | last post by:
I'm trying to learn Python using Pycharm but import shutil doesn't work
1
by: Shællîpôpï 09 | last post by:
If u are using a keypad phone, how do u turn on JavaScript, to access features like WhatsApp, Facebook, Instagram....
0
by: af34tf | last post by:
Hi Guys, I have a domain whose name is BytesLimited.com, and I want to sell it. Does anyone know about platforms that allow me to list my domain in auction for free. Thank you
0
isladogs
by: isladogs | last post by:
The next Access Europe User Group meeting will be on Wednesday 3 Apr 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM). In this session, we are pleased to welcome former...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.