473,402 Members | 2,055 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,402 software developers and data experts.

STL set and its iterator.

Hi, gurus

Is it safe to do this in function?
'return &(*iterator)';
And iterator is std::set<something>::iterator

Regards,

Jul 23 '05 #1
7 4469

"Prawit Chaivong" <pr******@gmail.com> wrote in message
news:11**********************@g47g2000cwa.googlegr oups.com...
Hi, gurus

Is it safe to do this in function?
'return &(*iterator)';
And iterator is std::set<something>::iterator


You've got a char literal '...' and its not being assigned to anything. If
you remove the single-quotes in the statement above:

return &(*iterator);

Then no-one can answer your question since its unknown whether the address
of the derefenced object (or pointer) is local to the function.

Jul 23 '05 #2


Peter Julian wrote:
"Prawit Chaivong" <pr******@gmail.com> wrote in message
news:11**********************@g47g2000cwa.googlegr oups.com...
Hi, gurus

Is it safe to do this in function?
'return &(*iterator)';
And iterator is std::set<something>::iterator


You've got a char literal '...' and its not being assigned to anything. If
you remove the single-quotes in the statement above:

return &(*iterator);

Then no-one can answer your question since its unknown whether the address
of the derefenced object (or pointer) is local to the function.


OK, It was my fault.
This is an example.

------------------------------------
std::set<MyClass> g_set;

void getBegin(MyClass **s)
{
std::set<MyClass>::iterator itr;
itr = g_set.begin();
*s = &(*itr); // is '*itr' temporary?
}
-------------------------------------

Jul 23 '05 #3
"Prawit Chaivong" <pr******@gmail.com> wrote in
news:11**********************@z14g2000cwz.googlegr oups.com:


Peter Julian wrote:
"Prawit Chaivong" <pr******@gmail.com> wrote in message
news:11**********************@g47g2000cwa.googlegr oups.com...
> Hi, gurus
>
> Is it safe to do this in function?
> 'return &(*iterator)';
> And iterator is std::set<something>::iterator


You've got a char literal '...' and its not being assigned to
anything. If you remove the single-quotes in the statement above:

return &(*iterator);

Then no-one can answer your question since its unknown whether the
address of the derefenced object (or pointer) is local to the
function.


OK, It was my fault.
This is an example.

------------------------------------
std::set<MyClass> g_set;

void getBegin(MyClass **s)
{
std::set<MyClass>::iterator itr;
itr = g_set.begin();
*s = &(*itr); // is '*itr' temporary?
}
-------------------------------------


IIRC: by definition *itr is a reference to the instance of the object in
the set. You then take the address of it. This pointer should be valid
until that element in the set is destroyed.
Jul 23 '05 #4
And if g_set is empty... ???

;-)

That's the fundamental problem with interfaces that return
pointers/references... What do you do when you have nothing to point or
refer to?

Jul 23 '05 #5

"Prawit Chaivong" <pr******@gmail.com> wrote in message
news:11**********************@z14g2000cwz.googlegr oups.com...


Peter Julian wrote:
"Prawit Chaivong" <pr******@gmail.com> wrote in message
news:11**********************@g47g2000cwa.googlegr oups.com...

<snip>
This is an example.

------------------------------------
std::set<MyClass> g_set;

void getBegin(MyClass **s)
{
std::set<MyClass>::iterator itr;
itr = g_set.begin();
*s = &(*itr); // is '*itr' temporary?
}
-------------------------------------


You are way too short on information and your knowledge on references, set
containers + iterators is rather lacking. This is making helping you very,
very difficult.

An iterator's type should always be type defined, since each STL container
supports predefined iterator types. The question you are asking refers to
*itr and whether its a temporary. When written correctly, and by using a
reference to the std::set container as a parameter to the function, *itr
returns the object thats first in the set's order of elements.

MyClass getBegin(set<MyClass>& ref_set)
{
typedef std::set<MyClass>::iterator SITER;
SITER it = ref_set.begin();
return *it;
}

A std::set container relys on a predicate
(http://en.wikipedia.org/wiki/Predicate).
When you insert an object into such a container, that container needs to
compare the insertable element to the elements already in the set. The
following will fail unless you supply an appropriate less_than operator
function to compare MyClass-type objects.

MyClass a;
MyClass b;
MyClass smallest = a < b ? a : b; // returns the lesser of the 2

By default, the std::set uses less<> to insert elements in the ordered
container. This means your MyClass class needs to have access to an
operator< for the std::set container to be able to order the elements when
inserting. Usually, the operator< is not a member of the class:

bool operator<(const MyClass& left, const MyClass& right)
{
....
}

In the case you wish to compare MyClass's private members to each other, you
need to make that operator a friend of the class.

#include <iostream>
#include <set>

class MyClass
{
int m_n;
public:
MyClass(int n) : m_n(n) { }
~MyClass() { }
int getN() { return m_n; }
// friendify op< to allow access to private members
friend bool operator<(const MyClass& left, const MyClass& right);
};

// global operator< to compare MyClass-type objects
bool operator<(const MyClass& left, const MyClass& right)
{
return left.m_n < right.m_n;
}

MyClass getBegin(std::set<MyClass>& ref_set)
{
typedef std::set<MyClass>::iterator SITER;
SITER it = ref_set.begin();
return *it;
}

int main()
{
std::set<MyClass> myset;
for (size_t i = 1; i < 10; ++i)
{
myset.insert(i); // automatically ordered
}

// using a non-member function:
MyClass first = getBegin(myset);

std::cout << "[using getBegin()]\tfirst element's value in set = ";
std::cout << first.getN();

// alternative to using a non-member function
typedef std::set<MyClass>::iterator SITER;
SITER it = myset.begin();

std::cout << "\n[using iterator]\tfirst element's value in set = ";
std::cout << (*it).getN();

return 0;
}

/* output:

[using getBegin()] first element in set = 1
[using iterator] first element in set = 1

*/
Jul 23 '05 #6

"Prawit Chaivong" <pr******@gmail.com> skrev i en meddelelse
news:11**********************@z14g2000cwz.googlegr oups.com...


Peter Julian wrote:
"Prawit Chaivong" <pr******@gmail.com> wrote in message
news:11**********************@g47g2000cwa.googlegr oups.com...
> Hi, gurus
>
> Is it safe to do this in function?
> 'return &(*iterator)';
> And iterator is std::set<something>::iterator


You've got a char literal '...' and its not being assigned to anything.
If
you remove the single-quotes in the statement above:

return &(*iterator);

Then no-one can answer your question since its unknown whether the
address
of the derefenced object (or pointer) is local to the function.


OK, It was my fault.
This is an example.

------------------------------------
std::set<MyClass> g_set;

void getBegin(MyClass **s)
{
std::set<MyClass>::iterator itr;
itr = g_set.begin();
*s = &(*itr); // is '*itr' temporary?
}
-------------------------------------

Apart from what others have mentioned, you seem to forget that *iter returns
a MyClass const&, not a MyClass&

/Peter
Jul 23 '05 #7

"Peter Koch Larsen" <pk*****@mailme.dk> wrote in message
news:1d********************@news000.worldonline.dk ...

"Prawit Chaivong" <pr******@gmail.com> skrev i en meddelelse
news:11**********************@z14g2000cwz.googlegr oups.com...


Peter Julian wrote:
"Prawit Chaivong" <pr******@gmail.com> wrote in message
news:11**********************@g47g2000cwa.googlegr oups.com...
> Hi, gurus
>
> Is it safe to do this in function?
> 'return &(*iterator)';
> And iterator is std::set<something>::iterator

You've got a char literal '...' and its not being assigned to anything.
If
you remove the single-quotes in the statement above:

return &(*iterator);

Then no-one can answer your question since its unknown whether the
address
of the derefenced object (or pointer) is local to the function.
OK, It was my fault.
This is an example.

------------------------------------
std::set<MyClass> g_set;

void getBegin(MyClass **s)
{
std::set<MyClass>::iterator itr;
itr = g_set.begin();
*s = &(*itr); // is '*itr' temporary?
}
-------------------------------------

Apart from what others have mentioned, you seem to forget that *iter

returns a MyClass const&, not a MyClass&


Thats a good point since modifying the referred_to_object could potentially
break that container's sequence.

Jul 23 '05 #8

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

38
by: Grant Edwards | last post by:
In an interview at http://acmqueue.com/modules.php?name=Content&pa=showpage&pid=273 Alan Kay said something I really liked, and I think it applies equally well to Python as well as the languages...
26
by: Michael Klatt | last post by:
I am trying to write an iterator for a std::set that allows the iterator target to be modified. Here is some relvant code: template <class Set> // Set is an instance of std::set<> class...
0
by: nick | last post by:
Hi, I need to manage a "layered" collection of objects, where each layer grows independently, e.g, o--+--+--+--+--+ 1st layer | o 2nd layer (empty) | o--+--+--+ 3rd...
14
by: shawnk | last post by:
I searched the net to see if other developers have been looking for a writable iterator in C#. I found much discussion and thus this post. Currently (C# 2) you can not pass ref and out arguments...
0
by: mailforpr | last post by:
Hi. Let me introduce an iterator to you, the so-called "Abstract Iterator" I developed the other day. I actually have no idea if there's another "Abstract Iterator" out there, as I have never...
21
by: T.A. | last post by:
I understand why it is not safe to inherit from STL containers, but I have found (in SGI STL documentation) that for example bidirectional_iterator class can be used to create your own iterator...
16
by: mailforpr | last post by:
How do I do that? The thing is, the only information I have about the iterator is the iterator itself. No container it is belonging to or anything. Like template<Iteratorvoid...
27
by: Steven D'Aprano | last post by:
I thought that an iterator was any object that follows the iterator protocol, that is, it has a next() method and an __iter__() method. But I'm having problems writing a class that acts as an...
4
by: mkborregaard | last post by:
Hi, I have the weirdest problem, and I can not see what is going wrong. I have made a 2d container class, and am implementing an iterator for that class. However, the ++ operator is behaving very...
2
by: Terry Reedy | last post by:
Luis Zarrabeitia wrote: Interesting observation. Iterators are intended for 'iterate through once and discard' usages. To zip a long sequence with several short sequences, either use...
0
by: Charles Arthur | last post by:
How do i turn on java script on a villaon, callus and itel keypad mobile phone
0
by: emmanuelkatto | last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud. Please let me know. Thanks! Emmanuel
1
by: nemocccc | last post by:
hello, everyone, I want to develop a software for my android phone for daily needs, any suggestions?
0
by: Hystou | last post by:
There are some requirements for setting up RAID: 1. The motherboard and BIOS support RAID configuration. 2. The motherboard has 2 or more available SATA protocol SSD/HDD slots (including MSATA, M.2...
0
by: Hystou | last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can...
0
Oralloy
by: Oralloy | last post by:
Hello folks, I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>". The problem is that using the GNU compilers,...
0
jinu1996
by: jinu1996 | last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven...
0
agi2029
by: agi2029 | last post by:
Let's talk about the concept of autonomous AI software engineers and no-code agents. These AIs are designed to manage the entire lifecycle of a software development project—planning, coding, testing,...
0
isladogs
by: isladogs | last post by:
The next Access Europe User Group meeting will be on Wednesday 1 May 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM). In this session, we are pleased to welcome a new...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.