Hallo,
i wonder how it is going to be of this code below regarding of the
return of temporary object.
Prototypes:
===========
bool Activation(TCHAR *c);
std::basic_string<TCHAR> GetFile();
Func Call:
==========
Activation((TCHAR *) myObj.GetFile().c_str());
Summary of the Question:
========================
It works fine under EVC4 & MSVC6. However, I dont know if it is
portable to g++
or other compiler.
- Is there any answer to the lifetime of temporary object for
all compilers? Does it also work fine under other compilers?
- In cosidering of effiency of the code. Is there any better solution
to just create a temporary obj like this ?
TCHAR* temp = myObj.GetFile().c_str();
Activation(temp);
- What is the lifetime of the return value from myObj.GetFile().c_str()
before Activation(..) is called?
Thank you very much for any suggestion.
regards,
pattreeya
[ See http://www.gotw.ca/resources/clcm.htm for info about ]
[ comp.lang.c++.moderated. First time posters: Do this! ] 8 2923
pt wrote: i wonder how it is going to be of this code below regarding of the return of temporary object.
Prototypes: ===========
bool Activation(TCHAR *c); std::basic_string<TCHAR> GetFile();
Func Call: ==========
Activation((TCHAR *) myObj.GetFile().c_str());
This is a VERY BAD IDEA(tm). "c_str()" returns a pointer to a _const_
TCHAR, casting away constness like this is utterly dangerous.
Summary of the Question: ======================== It works fine under EVC4 & MSVC6.
"Works" is a very subjective statement, isn't it?
However, I dont know if it is portable to g++ or other compiler.
It looks portable to me, but since I don't know what 'Activation' does
to the pointer passed to it, there is no way to tell if there are any
ill effects (like undefined behaviour).
- Is there any answer to the lifetime of temporary object for all compilers? Does it also work fine under other compilers?
A temporary is destroyed as the last step of evaluating the full
expression during evaluation of which the temporary was created. In
your case, since 'GetFile' returns an object, and that function call
is a sub-expression of an expression used to initialise the argument
of the 'Activation' function call, the temporary should survive until
'Activation' returns.
Compilers are many, some of them implement the Standard requirements
closer to the ideal than others. The lifetime of a temporary is one
of the issues that most compilers implement correctly, AFAICT.
- In cosidering of effiency of the code. Is there any better solution to just create a temporary obj like this ?
TCHAR* temp = myObj.GetFile().c_str();
That should not compile. 'c_str()' returns 'TCHAR const*' and you are
not allowed to convert it to 'TCHAR*' without a const_cast. And I urge
you not to, anyway.
Activation(temp);
No, this is definitely NOT going to work. 'temp' is a dangling pointer.
The temporary returned by 'GetFile' will be disposed of at the end of
initialising 'temp', which will *immediately* make it invalid.
- What is the lifetime of the return value from myObj.GetFile().c_str() before Activation(..) is called?
'c_str()' does not create a separate temporary to speak of. It does
however, create a pointer to the data in the other temporary, the
'basic_string<TCHAR>' object. How it does that is implemenation-
defined. The pointer remains valid until the next call to a non-const
member function for the same object (destructor is included).
V
Victor Bazarov wrote: pt wrote: i wonder how it is going to be of this code below regarding of the return of temporary object.
[snip] V
Ok, I give up.
What is a "TCHAR"?
Is code using "TCHAR" platform-portable?
Larry
Larry I Smith wrote: Victor Bazarov wrote:
pt wrote:
i wonder how it is going to be of this code below regarding of the return of temporary object.
[snip]
V
Ok, I give up.
What is a "TCHAR"?
Is code using "TCHAR" platform-portable?
Larry
It is a preprocessor macro defined in the Win32 API headers (i.e.,
non-standard, non-portable) that evalutes to either char or wchar
depending on whether UNICODE is defined. Nearly all of the Win32 API
functions that take strings as parameters are actually preprocessor
macros that evaluate to a FunctionNameA or FunctionNameW version, which
take char or wchar parameters, respectively.
Larry I Smith wrote: Victor Bazarov wrote: pt wrote: i wonder how it is going to be of this code below regarding of the return of temporary object. [snip]
V
Ok, I give up.
What is a "TCHAR"?
It matters not to the question at hand.
Is code using "TCHAR" platform-portable?
As much as you want to make it. I presume somewhere in the OP's code
there is a line like
typedef wchar_t TCHAR;
or
typedef char TCHAR;
depending on some other circumstances (macros/OS settings/whatever).
V
Victor Bazarov wrote: Larry I Smith wrote:Victor Bazarov wrote:pt wrote: i wonder how it is going to be of this code below regarding of the return of temporary object. [snip]
V
Ok, I give up.
What is a "TCHAR"?
It matters not to the question at hand.
Is code using "TCHAR" platform-portable?
As much as you want to make it. I presume somewhere in the OP's code there is a line like
typedef wchar_t TCHAR; or typedef char TCHAR;
depending on some other circumstances (macros/OS settings/whatever).
V
Ok, Alan answered it in his post - It's WIN32 API specific.
So, code using TCHAR is not portable.
Thanks Alan.
Regards,
Larry
Thanks a lot for all of the comments.
in the header file,typedef char TCHAR; so it should be portable ...
Well, regarding the temporary object, can we say that its lifetime of
return of GetFile() is existing until the end of call of
Activation(..), so to say at the end of statement?
Hi,
The return value of std::basic_string<TCHAR>::c_str() is valid until
you call non-constant member function of this object.
[ See http://www.gotw.ca/resources/clcm.htm for info about ]
[ comp.lang.c++.moderated. First time posters: Do this! ]
A temporary object lives till the end of whole expression.
Thus,
Activation( myObj.GetFile().c_str() );
is correct, while
char* temp = myObj.GetFile().c_str();
will be invalidated immediately after ';' and should not be used in
Activation(temp);
By the way,
If you have to cast to (TCHAR*) due to removing constness, please
verify that you don't modify the paramenter string in Activation(). If
no, you'd better declare it as
bool Activation(const TCHAR *c);
or (same as above)
bool Activation(LPCTSTR c);
Also note that, if TCHAR != char (being compiled for Unicode), c-style
casting from const char* -> const TCHAR* is meaningless and harmful.
You should use
either basic_string<TCHAR>
or convert types with special purpose macros - A2T (see http://msdn.microsoft.com/library/en...ion_Macros.asp
for details)
[ See http://www.gotw.ca/resources/clcm.htm for info about ]
[ comp.lang.c++.moderated. First time posters: Do this! ] This thread has been closed and replies have been disabled. Please start a new discussion. Similar topics
by: Jason Heyes |
last post by:
I am interested in the lifetime of a function argument in two cases. They
are:
1. void foo(Bar bar);
2. void foo(const Bar &bar);
In each case I call foo like so:
foo(Bar());
|
by: Gabor Drasny |
last post by:
Hi all,
Could anyone tell me if the following code is guaranteed to work or not?
#include <string>
#include <iostream>
int main()
{
const char* s = std::string("Hello World").c_str();
|
by: Bob Altman |
last post by:
Hi all,
I have a basic question regarding holding references to objects in unmanaged
C++. Suppose my unmanaged C++ class has a method that accepts a reference
to an object as an argument, and...
|
by: Frederick Gotham |
last post by:
There is a common misconception, (one which I myself also held at one point),
that a const reference can "extend the lifetime of a temporary". Examples
such as the following are given:
Snippet...
|
by: Klaas Vantournhout |
last post by:
Hi all,
I was wondering if it is possible if you can check in a function if one
of the arguments is temporary.
What I mean is the following. A is a class, foo is a function returning
a class...
|
by: nagashre |
last post by:
class A
{
public:
A():a(0), b(0){}
handleMyMsg( char* aa, char*bb);
private:
processMessage();
|
by: mario semo |
last post by:
Hello,
What does the C++ Norm says about the lifetime of compiler generated
temporary variables?
#include <stdio.h>
class BaseRef
{...
|
by: better_cs_now |
last post by:
Hello all,
class Foo {/* Details don't matter */};
class Bar {
public:
Bar(): m_Foo(/* Construct a Foo however it wants to be constructed
*/);
const Foo &GetFoo() const { return m_Foo; }...
|
by: Juha Nieminen |
last post by:
Let's assume we have a class like this:
//---------------------------------------------------------
#include <iostream>
class MyClass
{
public:
MyClass() { std::cout << "constructor\n"; }...
|
by: emmanuelkatto |
last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud.
Please let me know.
Thanks!
Emmanuel
|
by: BarryA |
last post by:
What are the essential steps and strategies outlined in the Data Structures and Algorithms (DSA) roadmap for aspiring data scientists? How can individuals effectively utilize this roadmap to progress...
|
by: nemocccc |
last post by:
hello, everyone, I want to develop a software for my android phone for daily needs, any suggestions?
|
by: marktang |
last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However,...
|
by: jinu1996 |
last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven...
|
by: Hystou |
last post by:
Overview:
Windows 11 and 10 have less user interface control over operating system update behaviour than previous versions of Windows. In Windows 11 and 10, there is no way to turn off the Windows...
|
by: tracyyun |
last post by:
Dear forum friends,
With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each...
|
by: agi2029 |
last post by:
Let's talk about the concept of autonomous AI software engineers and no-code agents. These AIs are designed to manage the entire lifecycle of a software development project—planning, coding, testing,...
|
by: isladogs |
last post by:
The next Access Europe User Group meeting will be on Wednesday 1 May 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM).
In this session, we are pleased to welcome a new...
| |