473,241 Members | 1,671 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,241 software developers and data experts.

If I change from std::vector to std::list my compiler becomes very displeased with me

Hello, consider this complete program (sorry, it's not minimal but I hope
it's readable at least):

#include <algorithm>
#include <iostream>
#include <vector>

class Row
{
public:
Row(int row)
:
m_row(row) {}

int get_row() const
{
return m_row;
}

private:
int m_row;
};

static void print_collection(const std::vector<Row>&);

bool less_wrt_row(const Row& lhs, const Row& rhs)
{
return lhs.get_row() < rhs.get_row();
}

int
main()
{
std::vector<Row> collection;

collection.push_back(Row(39));
collection.push_back(Row(3));
collection.push_back(Row(202));
collection.push_back(Row(1));

std::cout << "Before sorting:" << std::endl;

print_collection(collection);

std::sort(collection.begin(), collection.end(), less_wrt_row);

std::cout << "After sorting:" << std::endl;

print_collection(collection);

return 0;
}

static void
print_collection(const std::vector<Row>& collection)
{
std::vector<Row>::const_iterator itr = collection.begin();

while(itr != collection.end())
{
std::cout << itr->get_row() << std::endl;

++itr;
}
}

This program compiles and links and runs without noticable error. But if I
change the type of collection from std::vector to std::list, my compiles
becomes very displeased with me. The output is very long and quite
unreadable for a beginner like me. I assume std::list and std::vector are
not "compatible" with each other with regards to the sorting functions in
the standard library. But say I do have a std::list that I want sorted using
a binary predicate, how should I do it? Am I crazy wanting a std::list if I
want it to be sorted? What data structure should I use then?

Thanks for any replies
Jul 22 '05 #1
5 1744
>std::sort(collection.begin(), collection.end(), less_wrt_row);

Random access of list cannott be done, as we can do with vector. The
sort algorithm should access randomly inorder to sort which is not
possible with list.
One of the first error i got is

MurugesanSH@INP-Murgesansh /cygdrive/d/shanprog/ccprog
$ g++ -o list list.cc
/usr/include/c++/3.3.1/bits/stl_algo.h: In function `void
std::sort(_RandomAccessIter, _RandomAccessIter, _Compare) [with
_RandomAccessIter = std::_List_iterator<Row, Row&, Row*>, _Compare =
bool
(*)(const Row&, const Row&)]':
list.cc:44: instantiated from here
/usr/include/c++/3.3.1/bits/stl_algo.h:2209: error: no match for
'operator-' in
From which it can be seen that random access is not possible with list.

-Shan

Jul 22 '05 #2
"Eric Lilja" <er*************@yahoo.com> wrote in message
news:cr**********@news.island.liu.se
Hello, consider this complete program (sorry, it's not minimal but I
hope it's readable at least):

#include <algorithm>
#include <iostream>
#include <vector>

class Row
{
public:
Row(int row)
:
m_row(row) {}

int get_row() const
{
return m_row;
}

private:
int m_row;
};

static void print_collection(const std::vector<Row>&);

bool less_wrt_row(const Row& lhs, const Row& rhs)
{
return lhs.get_row() < rhs.get_row();
}

int
main()
{
std::vector<Row> collection;

collection.push_back(Row(39));
collection.push_back(Row(3));
collection.push_back(Row(202));
collection.push_back(Row(1));

std::cout << "Before sorting:" << std::endl;

print_collection(collection);

std::sort(collection.begin(), collection.end(), less_wrt_row);

std::cout << "After sorting:" << std::endl;

print_collection(collection);

return 0;
}

static void
print_collection(const std::vector<Row>& collection)
{
std::vector<Row>::const_iterator itr = collection.begin();

while(itr != collection.end())
{
std::cout << itr->get_row() << std::endl;

++itr;
}
}

This program compiles and links and runs without noticable error. But
if I change the type of collection from std::vector to std::list, my
compiles becomes very displeased with me. The output is very long and
quite unreadable for a beginner like me. I assume std::list and
std::vector are not "compatible" with each other with regards to the
sorting functions in the standard library. But say I do have a
std::list that I want sorted using a binary predicate, how should I
do it? Am I crazy wanting a std::list if I want it to be sorted? What
data structure should I use then?
Thanks for any replies


The std::sort function requires a random access iterator. Lists do not
permit random access. Accordingly, if you want to sort a list, you use the
sort member function for lists, i.e., you replace

std::sort(collection.begin(), collection.end(), less_wrt_row);

with

collection.sort(less_wrt_row);
--
John Carson
1. To reply to email address, remove donald
2. Don't reply to email address (post here instead)

Jul 22 '05 #3
>std::sort(collection.begin(), collection.end(), less_wrt_row);
with
collection.sort(less_wrt_row);


But comparison operator < ("less than") must be defined for the list
element type.

-Shan

Jul 22 '05 #4
"Shan" <sh*******@rediffmail.com> wrote in message
news:11**********************@z14g2000cwz.googlegr oups.com...
std::sort(collection.begin(), collection.end(), less_wrt_row);
with
collection.sort(less_wrt_row);


But comparison operator < ("less than") must be defined for the list
element type.

No.
As for std::sort, there are two overloads of std::list::sort :
one that uses the < operator, the other that takes a predicate
as a parameter (as in the above usage).

BTW: list's sort member function provides guaranteed O(lgN)
performance, and will not copy elements -- which makes it
more efficient than std::sort when collection items are
expensive to copy.
Happy 2005,
Ivan
--
http://ivan.vecerina.com/contact/?subject=NG_POST <- email contact form
Brainbench MVP for C++ <> http://www.brainbench.com
Jul 22 '05 #5
"Ivan Vecerina" <NO**********************************@vecerina.com > wrote in
message news:cr**********@news.hispeed.ch...
BTW: list's sort member function provides guaranteed O(lgN)
performance,

Of course I meant O(NlgN).
[ for std::sort worst case could be e.g. O(N2) ]
Jul 22 '05 #6

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

3
by: Mike Pemberton | last post by:
I'm sure there's a good explanation for this effect, but I get rather a strange output from this little test: #include <iostream> #include <list> int main() { std::list<int> int_list;
26
by: BCC | last post by:
Hi, A colleague has some code like this: class CMyObject { // Bunch of Member functions } class CMyObjectList: public std::vector<CMyObject> {
11
by: Steve | last post by:
Hi, I'm using a std::vector to store a list of user defined objects. The vector may have well over 1000 elements, and I'm suffering a performance hit. If I use push_back I get a much worse...
2
by: Morten Aune Lyrstad | last post by:
Hi! I haven't been using the standard template libraries much. I have a hard time trying to figure out just what is the practical difference between std::vector and std::list. Aren't both basically...
17
by: Michael Hopkins | last post by:
Hi all I want to create a std::vector that goes from 1 to n instead of 0 to n-1. The only change this will have is in loops and when the vector returns positions of elements etc. I am calling...
2
by: Priya Mishra | last post by:
Hi All It was very nice to intract with this group, While in my previous post, I was suggested to reffer the link, in order to learn C++, Well I was going thoruigh the link in which i had some...
7
by: TBass | last post by:
So I have a class: class Client { unsigned int ClientID; .... }; class MyListenSocket
3
by: Ray D. | last post by:
Hey all, I'm trying to pass a list into a function to edit it but when I compile using g++ I continue to get the following error: maintainNeighbors.cpp:104: error: invalid initialization of...
3
by: Carter | last post by:
I am currently writing some code where I have a list of objects with a maximum occupancy of 4. I have been employing std::vector for this but I was wondering how much overhead is involved. Is it...
2
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 7 Feb 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:30 (7.30PM). In this month's session, the creator of the excellent VBE...
0
by: fareedcanada | last post by:
Hello I am trying to split number on their count. suppose i have 121314151617 (12cnt) then number should be split like 12,13,14,15,16,17 and if 11314151617 (11cnt) then should be split like...
0
Git
by: egorbl4 | last post by:
Скачал я git, хотел начать настройку, а там вылезло вот это Что это? Что мне с этим делать? ...
1
by: davi5007 | last post by:
Hi, Basically, I am trying to automate a field named TraceabilityNo into a web page from an access form. I've got the serial held in the variable strSearchString. How can I get this into the...
0
by: MeoLessi9 | last post by:
I have VirtualBox installed on Windows 11 and now I would like to install Kali on a virtual machine. However, on the official website, I see two options: "Installer images" and "Virtual machines"....
0
by: DolphinDB | last post by:
The formulas of 101 quantitative trading alphas used by WorldQuant were presented in the paper 101 Formulaic Alphas. However, some formulas are complex, leading to challenges in calculation. Take...
0
by: DolphinDB | last post by:
Tired of spending countless mintues downsampling your data? Look no further! In this article, you’ll learn how to efficiently downsample 6.48 billion high-frequency records to 61 million...
0
by: Aftab Ahmad | last post by:
Hello Experts! I have written a code in MS Access for a cmd called "WhatsApp Message" to open WhatsApp using that very code but the problem is that it gives a popup message everytime I clicked on...
0
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 6 Mar 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, we are pleased to welcome back...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.