By using this site, you agree to our updated Privacy Policy and our Terms of Use. Manage your Cookies Settings.
440,016 Members | 2,262 Online
Bytes IT Community
+ Ask a Question
Need help? Post your question and get tips & solutions from a community of 440,016 IT Pros & Developers. It's quick & easy.

check my code please

P: n/a
Hi,
could someone please check my code? its asking the user to enter 3
letters, and check to see if these letters exist in the text file. i know
ive done something wrong. can someone fix my code please??

#include <fstream>
#include <string>
#include<iomanip>
#include <iostream>
#include<istream>
#include <cstdlib>
using namespace std;

int main()
{
char a, b, c;
ifstream myFile("data.txt");

cout << "Enter the pattern you are searching for: ";
cin.getline >> a & b & c;

cout << "Program will now search for: " << a << b << c << endl;

return 0;

}

Jul 22 '05 #1
Share this Question
Share on Google+
8 Replies


P: n/a

"kittykat" <f_******@nospam.hotmail.com> wrote in message
news:ad******************************@localhost.ta lkaboutprogramming.com...
Hi,
could someone please check my code? its asking the user to enter 3
letters, and check to see if these letters exist in the text file. i know
ive done something wrong. can someone fix my code please??

#include <fstream>
#include <string>
#include<iomanip>
#include <iostream>
#include<istream>
#include <cstdlib>
using namespace std;

int main()
{
char a, b, c;
ifstream myFile("data.txt");

cout << "Enter the pattern you are searching for: ";
cin.getline >> a & b & c;

What in the world does that do? Isn't the format for getline:
getline(cin,str); ?
cout << "Program will now search for: " << a << b << c << endl;

Aren't you supposed to DO the search here???
return 0;

}


Is this some kind of joke? Trying to trick someone into doing your work for
you? Surely you don't expect us to think you don't see there isn't even one
line of code that searches in the text file for a match! At least TRY to do
your own work first. This is not an effort, it's just silly.

-Howard


Jul 22 '05 #2

P: n/a
kittykat wrote:
Hi,
could someone please check my code? its asking the user to enter 3
letters, and check to see if these letters exist in the text file. i know
ive done something wrong. can someone fix my code please??

#include <fstream>
#include <string>
#include<iomanip>
#include <iostream>
#include<istream>
#include <cstdlib>
using namespace std;

int main()
{
char a, b, c;
ifstream myFile("data.txt");

cout << "Enter the pattern you are searching for: ";
cin.getline >> a & b & c;

cout << "Program will now search for: " << a << b << c << endl;

return 0;

}


have a look at this for some algorithms in pattern matching:

http://www.i.kyushu-u.ac.jp/~takeda/PM_DEMO/e.html

the naive algorithm should be easy enough to understand

greets

yoon
Jul 22 '05 #3

P: n/a
Thank you so much Yoon Soo!!! :)

Jul 22 '05 #4

P: n/a
Hi Howard,
this is my first week of trying anything in C++.

"Is this some kind of joke? Trying to trick someone into doing your work
for you?"

not a joke at all. i just wanted some help. my experience is very limited
and i am trying my best here.

"Isn't the format for getline: getline(cin,str);"

so in my case, would i write
getline(cin, a,b,c);
would that work?
Jul 22 '05 #5

P: n/a
kittykat wrote:
Could someone please check my code?
It's asking the user to enter 3 letters
and check to see if these letters exist in the text file.
I know [that] I've done something wrong.
Can someone fix my code please? expand kat.cc #include <fstream>
#include <string>
#include <iomanip>
#include <iostream>
#include <istream>
#include <cstdlib>
using namespace std;

int main(int argc, char* argv[]) {
char a, b, c;
ifstream myFile("data.txt");

std::cout << "Enter the pattern you are searching for: ";
std::cin >> a >> b >> c;

std::cout << "Program will now search for: "
<< a << b << c << std::endl;

return EXIT_SUCCESS;
}
g++ -Wall -ansi -pedantic -o kat kat.cc
./kat

Enter the pattern you are searching for: a b c
Program will now search for: abc

Now write some code to search "data.txt" and post it here.
Jul 22 '05 #6

P: n/a
kittykat wrote:

Hi Howard,
this is my first week of trying anything in C++.
If this is true (and I don't doubt it)
then the assignment is much to hard for you (as for
anybody else with just one week of experience).

"Is this some kind of joke? Trying to trick someone into doing your work
for you?"

not a joke at all. i just wanted some help. my experience is very limited
and i am trying my best here.

"Isn't the format for getline: getline(cin,str);"

so in my case, would i write
getline(cin, a,b,c);
would that work?
No.
Which books are you learning from?

Read 3 characters: When we are allowed to ignore error checking
for the moment, it is written:

char a, b, c;

cin >> a >> b >> c;
Your version cannot work. Mostly because as you say for yourself:
"Isn't the format for getline: getline(cin,str);"
getline takes 2 arguments. You try to feed it
getline(cin, a,b,c);


4 arguments. 2 - 4. That won't work. Also: getline expects
a *string* variable. You don't have one. You have 3 char
variables.
char - stores a single character
string - stores a sequence of characters.

--
Karl Heinz Buchegger
kb******@gascad.at
Jul 22 '05 #7

P: n/a

"kittykat" <f_******@nospam.hotmail.com> wrote in message
news:92******************************@localhost.ta lkaboutprogramming.com...
Hi Howard,
this is my first week of trying anything in C++.

"Is this some kind of joke? Trying to trick someone into doing your work
for you?"

not a joke at all. i just wanted some help. my experience is very limited
and i am trying my best here.


Ok, sorry if I was harsh. But we see a lot of students here simply asking
us to do their work for them. And your post only said "something is wrong",
when it looks pretty obvious to me that the main problem is that there's no
code there at all that does what you're saying the program should do (which
is to match up the pattern with the text in the file). See what I mean? If
the problem you were having was a compiler error on the call to getline,
then you need to tell us, so that we can concentrate on fixing that.

-Howard
Jul 22 '05 #8

P: n/a
thanx so much. I am currently working on this, and will post it as soon as
i have finished. I have taken some advice from my previous "Pattern
Matching" post, and have decided to break the problem down into tiny bits.
once i have something completed, i will post it and see what you think.

Thanx so much once again for everyones help. i really appreciate it!

Jul 22 '05 #9

This discussion thread is closed

Replies have been disabled for this discussion.