473,327 Members | 1,952 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,327 software developers and data experts.

set of T*; how to make T the key?

Hi,

I have a class that maintains a set of other objects. To save space, I'd
like to have a set of pointers to other objects, as multiple things can
reference/point to a unique object. The problem I've having though is that
I want the set to to use the object as the key, not the pointer. But it
gets trickier! I'm using a custom smart pointer instead of regular pointers
to allow poor-man's garbage collection.

My class kinda looks like

#include <set>
using namespace std;

class Foo
{
public:
typedef set<SmartPtr<Bar> > BarPtrSet;
typedef set<SmartPtr<Bar> >::iterator BPSiterator;

private:
BarPtrSet other_objects;

....
};
I tried a hack by making SmartPtr's less-than operator compare dereferenced
pointers rather than pointers, but that didn't really work and it causes
problems elsewhere in my code... and I am really hoping that I don't have to
just use set<Bar>.

My first thought is that I should modify the second template parameter of
set so that it is comparing something else, but I haven't found anything
that works yet... any thoughts out there?

thanks,
crichmon
Jul 22 '05 #1
8 1307
crichmon wrote:
Hi,

I have a class that maintains a set of other objects. To save space, I'd
like to have a set of pointers to other objects, as multiple things can
reference/point to a unique object. The problem I've having though is that
I want the set to to use the object as the key, not the pointer. But it
gets trickier! I'm using a custom smart pointer instead of regular pointers
to allow poor-man's garbage collection. Write a custom comparator *for the set*, not for SmartPtr<Bar>.
Remember the STL classes take a comparator, which usually defaults to
std::less<T>, but can be overridden.
My class kinda looks like

#include <set> #include <functional> using namespace std;
class BarPtrComp : public std::binary_function<
SmartPtr<Bar>, SmartPtr<Bar>, bool>
{
public:
bool operator()(const SmartPtr<Bar>& lhs,
const SmartPtr<Bar>& rhs) const
{
return *lhs < *rhs;
}
};

class Foo
{
public:
// typedef set<SmartPtr<Bar> > BarPtrSet;
// typedef set<SmartPtr<Bar> >::iterator BPSiterator; typedef set<SmartPtr<Bar>, BarPtrComp> BarPtrSet;
typedef BarPtrSet::iterator BPSiterator;


private:
BarPtrSet other_objects;

...
};
I tried a hack by making SmartPtr's less-than operator compare dereferenced
pointers rather than pointers, but that didn't really work and it causes
problems elsewhere in my code... Not necessary, see above.

and I am really hoping that I don't have to just use set<Bar>.

My first thought is that I should modify the second template parameter of
set so that it is comparing something else, but I haven't found anything
that works yet... any thoughts out there?

That's the correct solution. See above.
Jul 22 '05 #2
> class Foo
{
public:
typedef set<SmartPtr<Bar> > BarPtrSet;
typedef set<SmartPtr<Bar> >::iterator BPSiterator;

private:
BarPtrSet other_objects;

...
};


You can specify a key comparison predicate in the set template argument
list. As below:

// The predicate functor
struct lessBar
{
bool operator() (const SmartPtr<Bar>& pb1, const SmartPtr<Bar>& pb2)
const
{
return pb1->key < pb2->key; // Do the actual key comparison here
with whatever identifies you Bar instances
}
};

// Your Bar set type with the ordering predicate
typedef set< SmartPtr<Bar>, lessBar > BarPtrSet;

Hope this helps,

Thierry
Jul 22 '05 #3
"crichmon" <cr********@hotmail.com> wrote in message news:<RI****************@newsread3.news.atl.earthl ink.net>...
Hi,

I have a class that maintains a set of other objects. To save space, I'd
like to have a set of pointers to other objects, as multiple things can
reference/point to a unique object. The problem I've having though is that
I want the set to to use the object as the key, not the pointer. But it
gets trickier! I'm using a custom smart pointer instead of regular pointers
to allow poor-man's garbage collection.

My class kinda looks like

#include <set>
using namespace std;

class Foo
{
public:
typedef set<SmartPtr<Bar> > BarPtrSet;
typedef set<SmartPtr<Bar> >::iterator BPSiterator;

private:
BarPtrSet other_objects;

...
};
I tried a hack by making SmartPtr's less-than operator compare dereferenced
pointers rather than pointers, but that didn't really work and it causes
problems elsewhere in my code... and I am really hoping that I don't have to
just use set<Bar>.

My first thought is that I should modify the second template parameter of
set so that it is comparing something else, but I haven't found anything
that works yet... any thoughts out there?


Yes, you modify the second parameter.

This may work:

template < typename T >
bool PtrLess( const T* left, const T* right )
{
return *left < *right;
}

If it doesn't then try this:

template < typename T >
struct PtrLess
{
bool operator()( const T* left, const T* right ) const
{
return *left < *right;
}
};

You would then declare

std::set( T*, PtrLess<T> );

You will possibly find this problem has already been addressed by
boost. (I don't think it has been by STL yet though).
Jul 22 '05 #4
nmtop40 wrote:
This may work:

template < typename T >
bool PtrLess( const T* left, const T* right )
{
return *left < *right;
}

If it doesn't then try this:

template < typename T >
struct PtrLess
{
bool operator()( const T* left, const T* right ) const
{
return *left < *right;
}
};


I'd always prefer the second one, because it is potentially faster.

Jul 22 '05 #5

"nmtop40" <nm*****@yahoo.com> wrote:
"crichmon" <cr********@hotmail.com> wrote:
My first thought is that I should modify the
second template parameter of set so that it
is comparing something else, but I haven't
found anything that works yet... any thoughts
out there?
Yes, you modify the second parameter.

This may work:

template < typename T >
bool PtrLess( const T* left, const T* right )
{
return *left < *right;
}

If it doesn't then try this:

template < typename T >
struct PtrLess
{
bool operator()( const T* left, const T* right ) const
{
return *left < *right;
}
};

You would then declare

std::set( T*, PtrLess<T> );


do you mean

std::set< T*, PtrLess<T> > something;

?

Thanks to everyone who has helped!

You will possibly find this problem has already been
addressed by boost. (I don't think it has been by
STL yet though).


What is "boost"?

thnx,
crichmon
Jul 22 '05 #6
crichmon wrote:
What is "boost"?


A C++ library of mostly templates that has lots of functionality that is
missing in the standard library. It's likely that parts of boost will
go into the standard library in the next version of the C++ standard.

Jul 22 '05 #7
"red floyd" <no*****@here.dude> wrote:
crichmon wrote:

I have a class that maintains a set of other
objects. To save space, I'd like to have a set
of pointers to other objects, as multiple things
can reference/point to a unique object. The
problem I've having though is that I want the set
to to use the object as the key, not the pointer.
But it gets trickier! I'm using a custom smart
pointer instead of regular pointers to allow poor
man's garbage collection.


Write a custom comparator *for the set*, not for
SmartPtr<Bar>. Remember the STL classes take a
comparator, which usually defaults to std::less<T>,
but can be overridden.

#include <set>
#include <functional>
using namespace std;

class BarPtrComp : public std::binary_function<
SmartPtr<Bar>, SmartPtr<Bar>, bool>
{
public:
bool operator()(const SmartPtr<Bar>& lhs,
const SmartPtr<Bar>& rhs) const
{
return *lhs < *rhs;
}
};

...
typedef set<SmartPtr<Bar>, BarPtrComp> BarPtrSet;
typedef BarPtrSet::iterator BPSiterator;
...


This is what I ended up implementing:

/////////////
// SmartPtr.h
#include <functional>
using namespace std;

template<class C>
class SmartPtr
{
....
};

template<class C>
class SmartPtrComp: public binary_function<
SmartPtr<C>, SmartPtr<C>, bool>
{
public:
bool operator()( const SmartPtr<C>& lhs,
const SmartPtr<C>& rhs ) const
{
return ( (*lhs) < (*rhs) );
}
};
//////////////
// OtherFile.h
#include <set>
#include "SmartPtr.h"
#include "Bar.h"
using namespace std;
....
typedef set<SmartPtr<Bar>, SmartPtrComp<Bar> > BarPtrSet;
typedef BarPtrSet::iterator BPSiterator;
....
/////////////////

it works really well, thanks for the help!
crichmon
Jul 22 '05 #8
crichmon wrote:
[redacted]


Glad I could help. The wizards here have helped me quite a bit, glad I
could return the favor to someone else.
Jul 22 '05 #9

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

3
by: William C. White | last post by:
Does anyone know of a way to use PHP /w Authorize.net AIM without using cURL? Our website is hosted on a shared drive and the webhost company doesn't installed additional software (such as cURL)...
2
by: Albert Ahtenberg | last post by:
Hello, I don't know if it is only me but I was sure that header("Location:url") redirects the browser instantly to URL, or at least stops the execution of the code. But appearantely it continues...
3
by: James | last post by:
Hi, I have a form with 2 fields. 'A' 'B' The user completes one of the fields and the form is submitted. On the results page I want to run a query, but this will change subject to which...
0
by: Ollivier Robert | last post by:
Hello, I'm trying to link PHP with Oracle 9.2.0/OCI8 with gcc 3.2.3 on a Solaris9 system. The link succeeds but everytime I try to run php, I get a SEGV from inside the libcnltsh.so library. ...
1
by: Richard Galli | last post by:
I want viewers to compare state laws on a single subject. Imagine a three-column table with a drop-down box on the top. A viewer selects a state from the list, and that state's text fills the...
4
by: Albert Ahtenberg | last post by:
Hello, I have two questions. 1. When the user presses the back button and returns to a form he filled the form is reseted. How do I leave there the values he inserted? 2. When the...
1
by: inderjit S Gabrie | last post by:
Hi all Here is the scenerio ...is it possibly to do this... i am getting valid course dates output on to a web which i have designed ....all is okay so far , look at the following web url ...
2
by: Jack | last post by:
Hi All, What is the PHP equivilent of Oracle bind variables in a SQL statement, e.g. select x from y where z=:parameter Which in asp/jsp would be followed by some statements to bind a value...
3
by: Sandwick | last post by:
I am trying to change the size of a drawing so they are all 3x3. the script below is what i was trying to use to cut it in half ... I get errors. I can display the normal picture but not the...
0
by: ryjfgjl | last post by:
ExcelToDatabase: batch import excel into database automatically...
0
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 6 Mar 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, we are pleased to welcome back...
0
by: Vimpel783 | last post by:
Hello! Guys, I found this code on the Internet, but I need to modify it a little. It works well, the problem is this: Data is sent from only one cell, in this case B5, but it is necessary that data...
0
by: ArrayDB | last post by:
The error message I've encountered is; ERROR:root:Error generating model response: exception: access violation writing 0x0000000000005140, which seems to be indicative of an access violation...
1
by: PapaRatzi | last post by:
Hello, I am teaching myself MS Access forms design and Visual Basic. I've created a table to capture a list of Top 30 singles and forms to capture new entries. The final step is a form (unbound)...
1
by: Defcon1945 | last post by:
I'm trying to learn Python using Pycharm but import shutil doesn't work
0
by: af34tf | last post by:
Hi Guys, I have a domain whose name is BytesLimited.com, and I want to sell it. Does anyone know about platforms that allow me to list my domain in auction for free. Thank you
0
by: Faith0G | last post by:
I am starting a new it consulting business and it's been a while since I setup a new website. Is wordpress still the best web based software for hosting a 5 page website? The webpages will be...
0
isladogs
by: isladogs | last post by:
The next Access Europe User Group meeting will be on Wednesday 3 Apr 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM). In this session, we are pleased to welcome former...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.