473,394 Members | 1,843 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,394 software developers and data experts.

virtual destructor Vs virtual method

Hi all,

I have a simple question. If I have a ClassA as base class, and ClassB
derive from it. There is a virtual function foo() in ClassA, and in Class B,
I defined a function called foo() as well (w/ or w/o declaring it as virtual
doesn't matter since the virtual is inhered, right?). Both of them have a
virtual destructor.

Now, here is the part of the code:

ClassA::foo()
{
cout << "In class A"
}

ClassB::foo()
{
cout << "In class B"
}

ClassA::~ClassA()
{
cout << "destroying A"
}

ClassB::~ClassB()
{
cout << "destroying A"
}

When deleting objectB (from ClassB), both destructors are called. However,
when calling objectB's foo, only the classB's foo is called. Why is that?
Thanks for all your help.
Jul 22 '05 #1
7 1599

"Calvin Lai" <ca********@i010.com> wrote in message
news:PA********************@news04.bloor.is.net.ca ble.rogers.com...
Hi all,

I have a simple question. If I have a ClassA as base class, and ClassB
derive from it. There is a virtual function foo() in ClassA, and in Class B, I defined a function called foo() as well (w/ or w/o declaring it as virtual doesn't matter since the virtual is inhered, right?).
Correct.
Both of them have a
virtual destructor.

Now, here is the part of the code:

ClassA::foo()
{
cout << "In class A"
}

ClassB::foo()
{
cout << "In class B"
}

ClassA::~ClassA()
{
cout << "destroying A"
}

ClassB::~ClassB()
{
cout << "destroying A"
}

When deleting objectB (from ClassB), both destructors are called. However,
when calling objectB's foo, only the classB's foo is called. Why is that?


Because an object of type ClassB is actually composed of parts of both
ClassA and ClassB. Let's say in ClassA there were a file, and in ClassB
there was also a file. In an object of type ClassA, there will be 1 file.
In an object of type ClassB, there will be 2 files. When you delete an
object of ClassB, don't you want to make sure that both files are closed?
The closing of the file in ClassA should logically be closed in the
destructor for ClassA. On the other hand, functions aren't the same as
storage. Functions have to do with behavior, and if you want the behavior
of ClassB to be different from that of ClassA, then there's no reason to
call ClassA's function. You could though. In ClassB::foo(), you could make
a call to ClassA::foo(). Then it would work the same way as the destructor
calls.
Jul 22 '05 #2
Thanks Jeff. However, is this a logical reasoning of why this is happening
by design, or there is other behind the door arguments for it?

Calvin
"jeffc" <no****@nowhere.com> wrote in message
news:3f********@news1.prserv.net...

"Calvin Lai" <ca********@i010.com> wrote in message
news:PA********************@news04.bloor.is.net.ca ble.rogers.com...
Hi all,

I have a simple question. If I have a ClassA as base class, and ClassB
derive from it. There is a virtual function foo() in ClassA, and in Class
B,
I defined a function called foo() as well (w/ or w/o declaring it as virtual
doesn't matter since the virtual is inhered, right?).


Correct.
Both of them have a
virtual destructor.

Now, here is the part of the code:

ClassA::foo()
{
cout << "In class A"
}

ClassB::foo()
{
cout << "In class B"
}

ClassA::~ClassA()
{
cout << "destroying A"
}

ClassB::~ClassB()
{
cout << "destroying A"
}

When deleting objectB (from ClassB), both destructors are called.

However, when calling objectB's foo, only the classB's foo is called. Why is

that?
Because an object of type ClassB is actually composed of parts of both
ClassA and ClassB. Let's say in ClassA there were a file, and in ClassB
there was also a file. In an object of type ClassA, there will be 1 file.
In an object of type ClassB, there will be 2 files. When you delete an
object of ClassB, don't you want to make sure that both files are closed?
The closing of the file in ClassA should logically be closed in the
destructor for ClassA. On the other hand, functions aren't the same as
storage. Functions have to do with behavior, and if you want the behavior
of ClassB to be different from that of ClassA, then there's no reason to
call ClassA's function. You could though. In ClassB::foo(), you could make a call to ClassA::foo(). Then it would work the same way as the destructor calls.

Jul 22 '05 #3
"Calvin Lai" <ca********@i010.com> wrote in message
news:99********************@news04.bloor.is.net.ca ble.rogers.com...
Thanks Jeff. However, is this a logical reasoning of why this is happening
by design, or there is other behind the door arguments for it?


I'm not sure what you mean. A destructor isn't a normal function. It is
there to do necessary cleanup, so a derived class has no business preventing
its base class's destructor executing. Therefore, it executes automatically.
An ordinary member function, OTOH, is a different matter. A derived class is
there to alter or extend the behaviour of its base class, so it sometimes
is, and sometimes isn't, appropriate for a virtual function override to call
its base class version. For example, a virtual Clone function returns a new
copy of an object. Obviously, only one copy should be made and it should be
of the most derived class, so it would make no sense at all for any virtual
Clone function in a class hierarchy to call its base-class version.

Futhermore, even when a virtual function does call its base class version,
in some cases it should be called first, in others last, and in still others
somewhere in the middle of the derived class override. It all depends on
just how the derived class wants to modify/extend the base class's
behaviour.

For all these reasons, calling the base class version of an ordinary virtual
function from an override is left up to the programmer.

DW

Jul 22 '05 #4

"Calvin Lai" <ca********@i010.com> wrote in message
news:99********************@news04.bloor.is.net.ca ble.rogers.com...
Thanks Jeff. However, is this a logical reasoning of why this is happening
by design, or there is other behind the door arguments for it?


I don't understand your question. If you mean why was the language
originally designed this way, Bjarne Stroustrup wrote a book about that.
From an object-oriented design perspective though (which is unrelated to the
C++ language per se), it makes good sense to me.
Jul 22 '05 #5
"Calvin Lai" <ca********@i010.com> wrote in message
news:99********************@news04.bloor.is.net.ca ble.rogers.com...
Thanks Jeff. However, is this a logical reasoning of why this is happening
by design, or there is other behind the door arguments for it?

Calvin


It's by design. Perhaps the following (succint, yet dumb) code example will
help.

/////

#include <iostream>
#include <ostream>

class Base
{
public:
Base()
{
std::cout << "Base: " << foo() << std::endl;
}
virtual int foo() {return 3;}
virtual ~Base()
{
std::cout << "~Base: " << foo() << std::endl;
}
};

class Derived
{
int *x_;
public:
Derived() : x_ (new int (5))
{
std::cout << "Derived: " << foo() << std::endl;
}
int foo() {return *x_;}
~Derived()
{
std::cout << "~Derived: " << foo() << std::endl;
delete x_;
}
};

int main()
{
Derived d;
}

/////

creates output:
Base: 3
Derived: 5
~Derived: 5
~Base: 3
If Base could reach Derived::foo in its destructor, it would try to access
invalid memory. From a design point of view we get much better class
invariants* if we can assume a function will only be called on a constructed
object. Otherwise here we might need to (somehow) check in Derived::foo if
an actual Derived object exists or not - which seems kind of silly.
*: (Invariants are conditions that are always true for an object. An
invariant in Derived above is that x_ always points to a valid int, so we
never need to do the check x_ against NULL. Maintaining good invariants is
key to OO programming, and a motivating reason for data encapsulation.)

HTH
--
KCS
Jul 22 '05 #6
"Kevin Saff" <go********@kevin.saff.net> wrote in message
news:Hq********@news.boeing.com...
"Calvin Lai" <ca********@i010.com> wrote in message
news:99********************@news04.bloor.is.net.ca ble.rogers.com...
Thanks Jeff. However, is this a logical reasoning of why this is happening by design, or there is other behind the door arguments for it?

[SNIP]
If Base could reach Derived::foo in its destructor, it would try to access
invalid memory. From a design point of view we get much better class


I totally misunderstood the question. How embarrassing! Guess I'm done for
the day.

--
KCS
Jul 22 '05 #7
Thanks all for your comments. They are very helpful. I got it now.
"Calvin Lai" <ca********@i010.com> wrote in message
news:99********************@news04.bloor.is.net.ca ble.rogers.com...
Thanks Jeff. However, is this a logical reasoning of why this is happening
by design, or there is other behind the door arguments for it?

Calvin
"jeffc" <no****@nowhere.com> wrote in message
news:3f********@news1.prserv.net...

"Calvin Lai" <ca********@i010.com> wrote in message
news:PA********************@news04.bloor.is.net.ca ble.rogers.com...
Hi all,

I have a simple question. If I have a ClassA as base class, and ClassB
derive from it. There is a virtual function foo() in ClassA, and in Class
B,
I defined a function called foo() as well (w/ or w/o declaring it as

virtual
doesn't matter since the virtual is inhered, right?).


Correct.
Both of them have a
virtual destructor.

Now, here is the part of the code:

ClassA::foo()
{
cout << "In class A"
}

ClassB::foo()
{
cout << "In class B"
}

ClassA::~ClassA()
{
cout << "destroying A"
}

ClassB::~ClassB()
{
cout << "destroying A"
}

When deleting objectB (from ClassB), both destructors are called. However, when calling objectB's foo, only the classB's foo is called. Why is

that?

Because an object of type ClassB is actually composed of parts of both
ClassA and ClassB. Let's say in ClassA there were a file, and in ClassB
there was also a file. In an object of type ClassA, there will be 1

file. In an object of type ClassB, there will be 2 files. When you delete an
object of ClassB, don't you want to make sure that both files are closed? The closing of the file in ClassA should logically be closed in the
destructor for ClassA. On the other hand, functions aren't the same as
storage. Functions have to do with behavior, and if you want the behavior of ClassB to be different from that of ClassA, then there's no reason to
call ClassA's function. You could though. In ClassB::foo(), you could

make
a call to ClassA::foo(). Then it would work the same way as the

destructor
calls.


Jul 22 '05 #8

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

39
by: Ele | last post by:
Is it correct to say that Whenever a class has a virtual member function, define its destructor as "virtual"? Can a destructor as "pure virtual"? When is it needed to do so? For an interface,...
23
by: ctick | last post by:
A reason for declaring a "virtual destructor" for a Base class is to make sure the destructor of Derived class will be invoked when a pointer of Base type is used to delete an object of Derived. ...
23
by: Giancarlo Niccolai | last post by:
Hello all. I have peeked through the FAQ and all relevant links, and also through Stroustrup book, but I have not been able to find an answer, so I have to post here as a last resort. It...
11
by: santosh | last post by:
Hello, I was going through the Marshal Cline's C++ FAQ-Lite. I have a doubt regarding section 33.10. Here he is declaring a pure virtual destructor in the base class. And again defining...
37
by: WittyGuy | last post by:
Hi, I wonder the necessity of constructor and destructor in a Abstract Class? Is it really needed? ? Wg http://www.gotw.ca/resources/clcm.htm for info about ]
26
by: pmizzi | last post by:
When i compile my program with the -ansi -Wall -pedantic flags, i get this warning: `class vechile' has virtual functions but non-virtual destructor, and the same with my sub-classes. But when i...
7
by: eric | last post by:
hello i'm confused by an example in the book "Effective C++ Third Edition" and would be grateful for some help. here's the code: class Person { public: Person(); virtual ~Person(); // see...
17
by: Jess | last post by:
Hello, If I have a class that has virtual but non-pure declarations, like class A{ virtual void f(); }; Then is A still an abstract class? Do I have to have "virtual void f() = 0;"...
8
by: Shraddha | last post by:
What is the use of "PURE vitual distructors"? And why we can not have vitual constructors?
3
by: GAURAV AGRAWAL | last post by:
Hi Guys, Can someone please explain me why this is happening #include<iostream> using namespace std; class a { public: int a1; // If I remove this it'll work fine
0
by: Charles Arthur | last post by:
How do i turn on java script on a villaon, callus and itel keypad mobile phone
0
by: ryjfgjl | last post by:
If we have dozens or hundreds of excel to import into the database, if we use the excel import function provided by database editors such as navicat, it will be extremely tedious and time-consuming...
0
by: emmanuelkatto | last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud. Please let me know. Thanks! Emmanuel
0
BarryA
by: BarryA | last post by:
What are the essential steps and strategies outlined in the Data Structures and Algorithms (DSA) roadmap for aspiring data scientists? How can individuals effectively utilize this roadmap to progress...
0
by: Hystou | last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can...
0
Oralloy
by: Oralloy | last post by:
Hello folks, I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>". The problem is that using the GNU compilers,...
0
jinu1996
by: jinu1996 | last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven...
0
by: Hystou | last post by:
Overview: Windows 11 and 10 have less user interface control over operating system update behaviour than previous versions of Windows. In Windows 11 and 10, there is no way to turn off the Windows...
0
tracyyun
by: tracyyun | last post by:
Dear forum friends, With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.