"Andy Skypeck" <as******@earthlink.net> wrote...
"Victor Bazarov" <v.********@comAcast.net> wrote in message
news:<KuJzb.418968$HS4.3341510@attbi_s01>...
"Andy Skypeck" <as******@earthlink.net> wrote... I am looking for some validation against a dubious coding practice
that prevails where I work.
Take my word for it: it's better to go with the flow than against
it. Whether your coding practice is dubious or not, it's accepted
in the organisation, and you should do the same if you want to keep
your job.
The organisation touts itself as a quality driven "six sigma"
environment. It seeks to write portable, robust, correct C++
code. Questioning what to me seems to be an incorrect
practice is very much in the spirit of the organisation.
Correctness should win out.
C types defined in types.h (Linux) or
stdint.h (Windows, C99?) are used as if they belong to the C++
standard namespace.
std::uint8_t instead of uint8_t
std::uint32_t instead of uint32_t
...
I don't think the use of std:: is correct. Nowhere are these types
explicitly added to the std namespace.
What do you mean by that?
In fact GCC 3.3 fails on them.
So? How is that proof of anything?
The release notes for GCC-3.3 discuss types included in std::
Neither are they among the types defined in the C++ standard language
support files listed on page 433 in Stroustrup (2nd Ed.)
std::size_t
std::ptrdiff_t
std::NULL
defined in <cstddef> are ok. I am wrong about this?
NULL is a macro, it cannot be defined in a namespace. The Standard
says (17.4.1.1):
I stand corrected on NULL.
Now, there is a subclause that says "It is undefined for a C++
program to add declarations or definitions to namespace std [...]"
but it could be argued that types you listed (uint8_t, etc.) are
part of the library implementation and as such belong to std...
I would accept that but, as I said above, the types are defined in a
file that is not part of the library implementation.
Why don't you ask your development supervisor where they get those
types? They will probably be able to explain why 'std::' is used
there.
I have. They have an external file stdint.h defining these types.
It is not part of any of the compilers we use. It is hand made to
imitate the types defined for C99. Some definitions init it even
collide with those in types.h in gcc-3.3. I have brought up this point
repeatedly with the leads to no avail. For my own satisfaction I'd
like to get to the bottom of this, which is why I posted.
Andy,
If you're trying to figure out why such thing has been done, you need
to keep talking to your colleagues and leads. There must not be "to no
avail" there. You are simply not supposed to give up. They are YOUR
colleagues, you're supposed to work TOGETHER, not against each other.
If you're looking for a justification to pick up a fight with them,
it is quite possible that you'll lose. They will tell you "we needed
those C99 types, since they are likely to be included in C++0x, so we
put them where our compiler can find them, and we put them in the 'std'
namespace because that's where they'll end up when added to C++0x".
The header <stdint.h> is standard in C99 and contains the "exact-width
integer types". A conflict with a GCC's non-standard header <types.h>
does NOT matter and has to be dealt with in a routine manner, not argued
about in public.
Just MHO.
Victor
