Rows Cannot be Programmatically added.

[M1kkelZU]

Hey guys, I'm getting an error when I want t add a file to my dataGridView that I can't add any data because it is databound. I've been working around this but still gives me the same error. heres the snippet of the code:

       private void btnOpenLog_Click(object sender, EventArgs e)
        {
            OpenFileDialog openFileDialog1 = new OpenFileDialog();
            if (openFileDialog1.ShowDialog() != DialogResult.Cancel)
            {
                String sLine = "";
                try
                {
                    System.IO.StreamReader FileStream = new System.IO.StreamReader(openFileDialog1.FileName);
                    sLine = FileStream.ReadLine();
                    string[] s = sLine.Split(';');
                    for (int i = 0; i <= s.Count() - 1; i++)
                    {
                        DataGridViewColumn colHold = new DataGridViewTextBoxColumn();
                        colHold.Name = "col" + System.Convert.ToString(i);
                        colHold.HeaderText = s[i].ToString();
                        dataGridView1.Columns.Add(colHold);
                    }
                    sLine = FileStream.ReadLine();
                    while (sLine != null)
                    {
                        dataGridView1.Rows.Add();
                        for (int i = 0; i <= s.Count() - 1; i++)
                        {
                            s = sLine.Split('|');
                            dataGridView1.Rows[dTable.Rows.Count - 1].Cells[i].Value = s[i].ToString();
                        }
                        sLine = FileStream.ReadLine();
                    }
                    FileStream.Close();
                }
                catch (Exception err)
                {
                    System.Windows.Forms.MessageBox.Show("Error:  " + err.Message, "Program Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
                }
            }
        }

If anyone can help that would be awesome.

Thanks.

[Mikkeee]

I would instead create and populate a datatable and then set the datasource of your GridView to the datatable.

[M1kkelZU]

Hmm. I'll have a look at that. Where would I place the right statements etc then?

[Mikkeee]

Your code is almost there right now. First create a new datatable and add the columns inside your first loop where you're populating your gridview columns.

dt.Columns.Add(String.Format("col{0}",i), typeof(string));
 

And then in your code where you're reading your file you need to add the data to the data table.

row[i] = i.ToString();
 

Place the row into the datatable after you're done filling the row with values.

dt.Rows.Add(row);
 

And you need to set the datasource when you're done.

dataGridView1.DataSource = dt;
 

[M1kkelZU]

Ok thanks, only thing is I can't use the

row = i.ToString();

as it gives me an error that I don't have row declared and can't use

DataRow row = new DataRow();

as it starts whining that it can't convert DataRow to String.

[Mikkeee]

You do need to declare your DataRow first but you missed the [i] part after the row;

row[i] = i.ToString();

[M1kkelZU]

oh lol I'm dumb. Now I at least don't get an errr that It can't add the data. Now it gives me a nicer error:

Input array is longer than the numer of columns in this table.

I have added a new column and everthing but it still doesnt work :/

[Mikkeee]

Please re-post your modified code.

[M1kkelZU]

private void btnOpenLog_Click(object sender, EventArgs e)
        {
            OpenFileDialog openFileDialog1 = new OpenFileDialog();
            if (openFileDialog1.ShowDialog() != DialogResult.Cancel)
            {
                String sLine = "";
                try
                {
                    StreamReader FileStream = new StreamReader(openFileDialog1.FileName);
                    sLine = FileStream.ReadLine();
                    string[] s = sLine.Split(';');
                    for (int i = 0; i <= s.Count() - 1; i++)
                    {
                        dTable.Columns.Add(String.Format("col{0}",i), typeof(string));
                    }
                    sLine = FileStream.ReadLine();
                    while (sLine != null)
                    {
                        //dataGridView1.Rows.Add();
                        for (int i = 0; i <= s.Count() - 1; i++)
                        {
                            s = sLine.Split('|');
                            DataRow row = dTable.NewRow();
                            row[i] = i.ToString();
                            dTable.Rows.Add(s);
                        }
                        sLine = FileStream.ReadLine();
                    }
                    dataGridView1.DataSource = dTable;
                    FileStream.Close();
                }
                catch (Exception err)
                {
                    System.Windows.Forms.MessageBox.Show("Error:  " + err.Message, "Program Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
                }
            }
        }

Here you go, if needed I'll upload the entire project for you.

[Mikkeee]

You have a few lines of code inside a for loop that should be outside the for loop.
Change:

for (int i = 0; i <= s.Count() - 1; i++)
{
    s = sLine.Split('|');
    DataRow row = dTable.NewRow();
    row[i] = i.ToString();
    dTable.Rows.Add(s);
}
 

To:

s = sLine.Split('|');
DataRow row = dTable.NewRow();
for (int i = 0; i <= s.Count() - 1; i++)
{
    row[i] = s[i].ToString();
}
// You need to add the row, not the 's' array
dTable.Rows.Add(row);
 

[M1kkelZU]

ok thanks, now the only thing its saying is

Can't find column 1

Any idea what could be going on?

[Mikkeee]

Which line of code is giving you that error?

[M1kkelZU]

I have no clue, Its the Exception MessageBox that says that.

[Mikkeee]

Well.. you need to be sure that the number of columns defined match the number values coming in. It does appear strange to me that you're pulling the first record of your file to create the column names which is defined by a semi-colon but you're delimiting the actual data with the pipe. I wish I could give you an answer here but really need to step into your code to find out which line is causing the issue. A very basic first step would be to learn how to debug your code. This will help you tremendously and save you tons of time in the future once you understand how to properly debug and use try/catch. Just search google for 'c sharp debugging tutorial' and you will find a bunch of tutorials.

[M1kkelZU]

Ah ok thanks :) Atleast its working that 1% extra.

[Mikkeee]

Just out of curiosity, do you have any columns defined in your GridView? If so, remove them and let the datatable take care of them.

[M1kkelZU]

Is what I have. What would I have to remove then.

[Mikkeee]

OK, then you need to be sure that the columns in your datatable match the columns in your GridView. To do this you should eat the header record and define the columns.

Remove:

string[] s = sLine.Split(';');
for (int i = 0; i <= s.Count() - 1; i++)
{
    dTable.Columns.Add(String.Format("col{0}",i), typeof(string));
}
 

Define your data table columns:

dTable.Columns.Add("Date", typeof(DateTime));
dTable.Columns.Add("Log Name", typeof(string));
// Keep going. Define your remaining columns and data types.
 

[M1kkelZU]

Yeah I just figured it out like 2 minutes before I saw your post. Thanks alot Mikkeee :)