SQL Error in C# code

[E11esar]

Hi there.

I have the following code in the body of a web method:

string maxCmd = "select max(aValue) + 1 from a_table where aValue < 1000";
string newValue = string.Empty;
 
OracleCommand comm = new OracleCommand("maxCmd", conn);
OracleDataReader reader = comm.ExecuteReader();
while (reader.Read())
{
   newValue = reader[0].ToString();
}
 
 

This produces an error message of the form "Invalid SQL command" though I can't see what I am missing here as this runs okay in the sql client. Can anybody see my mistake please?

Thank you.

M :o)

[PRR]

well you haven't opened connection?

[E11esar]

@DeepBlue
Yes I have but I haven't shown that part of the code sample.

Thank you.

M :o)

[E11esar]

Hi there.

I just solved it. I had the string for the sql command in quotes in the command definition:

OracleCommand comm = new OracleCommand("maxCmd", conn);

This should be:

OracleCommand comm = new OracleCommand(maxCmd, conn);

Thank you.

M :o)

[PRR]

oh yeah! i missed that ... do continue to post your queries on Bytes