I/O not reading the last line of a file.

[Adam Sandler]

Hello,

I'm trying to input a txt file. Each line in the text file contains a
discrete code or value -- so I want to populate the an arraylist with
each line. I've noticed a problem. The code I have never reads the
last line of the file. Here's the code:

while (!sr.EndOfStream)
{
line = sr.ReadLine();
}
sr.Close();

If the txt file has 10 lines, after this code, there are only 9 items
in the arraylist. How can I get that last line in my arraylist?
Suggestions are greatly appreciated.

Thanks!

[Peter Duniho]

On Sun, 31 Aug 2008 17:31:56 -0700, Adam Sandler <co****@excite.comwrote:

I'm trying to input a txt file. Each line in the text file contains a
discrete code or value -- so I want to populate the an arraylist with
each line. I've noticed a problem. The code I have never reads the
last line of the file. Here's the code:

while (!sr.EndOfStream)
{
line = sr.ReadLine();
}
sr.Close();

That's because the EndOfStream property returns information about the
underlying stream, not the reader state itself. The reader buffers the
input data, and so very well may reach the end of the underlying stream
before it's returned all of the text in the stream. Clearly, that's
what's happening to you.

If the txt file has 10 lines, after this code, there are only 9 items
in the arraylist. How can I get that last line in my arraylist?

Instead of checking the EndOfStream property, just read until you get a
null line:

while ((line = sr.ReadLine()) != null)
{
}

Pete

[Marc Gravell]

I might be wrong, but looking at Red Gate's .NET Reflector [still
getting used to that...] EndOfStream appears to respect the buffer...?

Marc

[Peter Duniho]

On Mon, 01 Sep 2008 00:01:44 -0700, Marc Gravell <ma**********@gmail.com>
wrote:

I might be wrong, but looking at Red Gate's .NET Reflector [still
getting used to that...] EndOfStream appears to respect the buffer...?

On my computer, using Roeder's Reflection, I see the same thing as you.
If there's data left in the buffer, or refilling the buffer returns a
non-zero number of characters, EndOfStream returns "false". But...

What version of .NET? I'm up-to-date on this computer. Maybe it didn't
used to and the OP is using an earlier version of .NET. The docs
certainly don't guarantee that it does, and in fact seem to me to imply
the opposite. On top of that, it not respecting the buffer is the best
explanation I can come up with for the OP seeing the behavior he's
describing.

I admit, I didn't go over to his office and look over his shoulder to
verify that his code is doing what he says it's doing. But it seems
reasonable to take his word for it. :)

To the OP: if you are using the latest version of .NET, then you should
post a concise-but-complete code sample that demonstrates the problem
because, as Marc points out, the code you posted so far should work fine.

Pete

[=?UTF-8?B?QXJuZSBWYWpow7hq?=]

Peter Duniho wrote:

On Mon, 01 Sep 2008 00:01:44 -0700, Marc Gravell
<ma**********@gmail.comwrote:

>I might be wrong, but looking at Red Gate's .NET Reflector [still
getting used to that...] EndOfStream appears to respect the buffer...?

On my computer, using Roeder's Reflection,

Same software. Lutz Roeder just gave/sold Reflector to Red Gate.

Arne

[Peter Duniho]

On Mon, 01 Sep 2008 19:30:48 -0700, Arne Vajhøj <ar**@vajhoej.dkwrote:

Peter Duniho wrote:

>On Mon, 01 Sep 2008 00:01:44 -0700, Marc Gravell
<ma**********@gmail.comwrote:

>>I might be wrong, but looking at Red Gate's .NET Reflector [still
getting used to that...] EndOfStream appears to respect the buffer..?

On my computer, using Roeder's Reflection,

Same software. Lutz Roeder just gave/sold Reflector to Red Gate.

Well...okay. Fine. But do you know why the OP isn't getting the last
line of input?

[=?UTF-8?B?QXJuZSBWYWpow7hq?=]

Peter Duniho wrote:

On Mon, 01 Sep 2008 19:30:48 -0700, Arne Vajhøj <ar**@vajhoej.dkwrote:

>Peter Duniho wrote:

>>On Mon, 01 Sep 2008 00:01:44 -0700, Marc Gravell
<ma**********@gmail.comwrote:
I might be wrong, but looking at Red Gate's .NET Reflector [still
getting used to that...] EndOfStream appears to respect the buffer..?
On my computer, using Roeder's Reflection,

Same software. Lutz Roeder just gave/sold Reflector to Red Gate.

Well...okay. Fine. But do you know why the OP isn't getting the last
line of input?

Nope.

For that part I am like the rest - it would be nice to see a
complete example.

Arne

[Adam Sandler]

On Aug 31, 6:45*pm, "Peter Duniho" <[e-mail]>
wrote:

On Sun, 31 Aug 2008 17:31:56 -0700, Adam Sandler <[e-mail]:

I'm trying to input a txt file. *Each line in the text file contains a
discrete code or value -- so I want to populate the an arraylist with
each line. *I've noticed a problem. *The code I have never reads the
last line of the file. *Here's the code:

* * * * * * while (!sr.EndOfStream)
* * * * * * {
* * * * * * * * line = sr.ReadLine();
* * * * * * }
* * * * * * sr.Close();

That's because the EndOfStream property returns information about the *
underlying stream, not the reader state itself. *The reader buffers the*
input data, and so very well may reach the end of the underlying stream *
before it's returned all of the text in the stream. *Clearly, that's *
what's happening to you.

If the txt file has 10 lines, after this code, there are only 9 items
in the arraylist. *How can I get that last line in my arraylist?

Instead of checking the EndOfStream property, just read until you get a *
null line:

* * *while ((line = sr.ReadLine()) != null)
* * *{
* * *}

Pete

Thanks for the help; that worked!

[Marc Gravell]

Thanks for the help; that worked!- Hide quoted text -

Interesting... can you perhaps tell us which version (including SP) of
the .NET framework you are using? It *looks* like (in 3.5 SP1, at
least) the two should work the same. I'm glad it is sorted though - a
good call by Pete.

Marc