473,378 Members | 1,139 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,378 software developers and data experts.

.Net 2.0 classes very buggy?

Hi all,

I'm playing with Lutz Roeders Reflector and have found several areas
where I think there are issues in the framework libraries. I can't see
how the following should work as expected and the compiler gives me an
error on the 'text1 = text1...' line. Is it really this buggy (this
particular bug is in several places) or am I missing something? You can
see that that code has a possibility of crashing if the property has a
.. in it. I think the line should read 'text1 = property.Name....'.

The code is from the ProfileBuilder class in the System.Web.Compilation
class.

private void CreateCodeForProperty(AssemblyBuilder assemblyBuilder,
CodeTypeDeclaration type, ProfileNameTypeStruct property)
{
string text1;
int num1 = property.Name.IndexOf('.');
if (num1 > 0)
{
text1 = text1.Substring(num1 + 1);
}
if (!assemblyBuilder.CodeDomProvider.IsValidIdentifie r(text1))
{
throw new
ConfigurationErrorsException(SR.GetString("Profile _bad_name"),
property.FileName, property.LineNumber);
}
CodeMemberProperty property1 = new CodeMemberProperty();
property1.Name = text1;
property1.Attributes = MemberAttributes.Public;
property1.HasGet = true;
property1.Type = property.PropertyCodeRefType;
CodeMethodInvokeExpression expression1 = new
CodeMethodInvokeExpression();
expression1.Method.TargetObject = new
CodeThisReferenceExpression();
expression1.Method.MethodName = "GetPropertyValue";
expression1.Parameters.Add(new CodePrimitiveExpression(text1));
CodeMethodReturnStatement statement1 = new
CodeMethodReturnStatement(new CodeCastExpression(property1.Type,
expression1));
property1.GetStatements.Add(statement1);
if (!property.IsReadOnly)
{
CodeMethodInvokeExpression expression2 = new
CodeMethodInvokeExpression();
expression2.Method.TargetObject = new
CodeThisReferenceExpression();
expression2.Method.MethodName = "SetPropertyValue";
expression2.Parameters.Add(new
CodePrimitiveExpression(text1));
expression2.Parameters.Add(new
CodePropertySetValueReferenceExpression());
property1.HasSet = true;
property1.SetStatements.Add(expression2);
}
type.Members.Add(property1);
}

Your thoughts would be welcome.

Ryan

Jun 12 '06 #1
9 1323
"Ryan" <ry***@lightsdown.com> wrote in message
news:11**********************@j55g2000cwa.googlegr oups.com...
Hi all,

I'm playing with Lutz Roeders Reflector and have found several areas
where I think there are issues in the framework libraries. I can't see
how the following should work as expected and the compiler gives me an
error on the 'text1 = text1...' line. Is it really this buggy (this
particular bug is in several places) or am I missing something? You can
see that that code has a possibility of crashing if the property has a
. in it. I think the line should read 'text1 = property.Name....'.

The code is from the ProfileBuilder class in the System.Web.Compilation
class.

private void CreateCodeForProperty(AssemblyBuilder assemblyBuilder,
CodeTypeDeclaration type, ProfileNameTypeStruct property)
{
string text1;
int num1 = property.Name.IndexOf('.');
if (num1 > 0)
{
text1 = text1.Substring(num1 + 1);
} ....
<snip>
.... Your thoughts would be welcome.


When I look at that method with Reflector the first line is:
string text1 = property.Name;
which means that all is well. If it's any help I'm using Reflector
v4.2.27.0.

Chris Jobson
Jun 12 '06 #2

Chris Jobson wrote:
"Ryan" <ry***@lightsdown.com> wrote in message
news:11**********************@j55g2000cwa.googlegr oups.com...
Hi all,

I'm playing with Lutz Roeders Reflector and have found several areas
where I think there are issues in the framework libraries. I can't see
how the following should work as expected and the compiler gives me an
error on the 'text1 = text1...' line. Is it really this buggy (this
particular bug is in several places) or am I missing something? You can
see that that code has a possibility of crashing if the property has a
. in it. I think the line should read 'text1 = property.Name....'.

The code is from the ProfileBuilder class in the System.Web.Compilation
class.

private void CreateCodeForProperty(AssemblyBuilder assemblyBuilder,
CodeTypeDeclaration type, ProfileNameTypeStruct property)
{
string text1;
int num1 = property.Name.IndexOf('.');
if (num1 > 0)
{
text1 = text1.Substring(num1 + 1);
}

...
<snip>
...
Your thoughts would be welcome.


When I look at that method with Reflector the first line is:
string text1 = property.Name;
which means that all is well. If it's any help I'm using Reflector
v4.2.27.0.

Chris Jobson


V4.2.43.0 seems to have bugs then, thanks for checking it out.

Ryan

Jun 12 '06 #3
What makes you think this class is buggy? What exactly do you mean with
crashing? Any exception would be helpfull. Also, keep in mind that you are
reverse engineering a private non documented class.

Willy.
"Ryan" <ry***@lightsdown.com> wrote in message
news:11**********************@j55g2000cwa.googlegr oups.com...
| Hi all,
|
| I'm playing with Lutz Roeders Reflector and have found several areas
| where I think there are issues in the framework libraries. I can't see
| how the following should work as expected and the compiler gives me an
| error on the 'text1 = text1...' line. Is it really this buggy (this
| particular bug is in several places) or am I missing something? You can
| see that that code has a possibility of crashing if the property has a
| . in it. I think the line should read 'text1 = property.Name....'.
|
| The code is from the ProfileBuilder class in the System.Web.Compilation
| class.
|
| private void CreateCodeForProperty(AssemblyBuilder assemblyBuilder,
| CodeTypeDeclaration type, ProfileNameTypeStruct property)
| {
| string text1;
| int num1 = property.Name.IndexOf('.');
| if (num1 > 0)
| {
| text1 = text1.Substring(num1 + 1);
| }
| if (!assemblyBuilder.CodeDomProvider.IsValidIdentifie r(text1))
| {
| throw new
| ConfigurationErrorsException(SR.GetString("Profile _bad_name"),
| property.FileName, property.LineNumber);
| }
| CodeMemberProperty property1 = new CodeMemberProperty();
| property1.Name = text1;
| property1.Attributes = MemberAttributes.Public;
| property1.HasGet = true;
| property1.Type = property.PropertyCodeRefType;
| CodeMethodInvokeExpression expression1 = new
| CodeMethodInvokeExpression();
| expression1.Method.TargetObject = new
| CodeThisReferenceExpression();
| expression1.Method.MethodName = "GetPropertyValue";
| expression1.Parameters.Add(new CodePrimitiveExpression(text1));
| CodeMethodReturnStatement statement1 = new
| CodeMethodReturnStatement(new CodeCastExpression(property1.Type,
| expression1));
| property1.GetStatements.Add(statement1);
| if (!property.IsReadOnly)
| {
| CodeMethodInvokeExpression expression2 = new
| CodeMethodInvokeExpression();
| expression2.Method.TargetObject = new
| CodeThisReferenceExpression();
| expression2.Method.MethodName = "SetPropertyValue";
| expression2.Parameters.Add(new
| CodePrimitiveExpression(text1));
| expression2.Parameters.Add(new
| CodePropertySetValueReferenceExpression());
| property1.HasSet = true;
| property1.SetStatements.Add(expression2);
| }
| type.Members.Add(property1);
| }
|
| Your thoughts would be welcome.
|
| Ryan
|
Jun 12 '06 #4

Ryan wrote:
Hi all,

I'm playing with Lutz Roeders Reflector and have found several areas
where I think there are issues in the framework libraries. I can't see
how the following should work as expected and the compiler gives me an
error on the 'text1 = text1...' line.
What's the error?
Is it really this buggy (this
particular bug is in several places) or am I missing something? You can
see that that code has a possibility of crashing if the property has a
. in it.


OK. Can you show us the code that would make this crash?

--
Larry Lard
Replies to group please

Jun 12 '06 #5
You are too quick to consider things to be buggy.
Reflector is right, if you are not sure check the IL..

IL_0015: ldloc.1
IL_0016: ldc.i4.1
IL_0017: add
IL_0018: callvirt instance string [mscorlib]System.String::Substring(int32)

which turns into...

text1 = text1.Substring(num1 + 1);
in C#

Willy.
"Ryan" <ry***@lightsdown.com> wrote in message
news:11**********************@j55g2000cwa.googlegr oups.com...
|
| Chris Jobson wrote:
| > "Ryan" <ry***@lightsdown.com> wrote in message
| > news:11**********************@j55g2000cwa.googlegr oups.com...
| > > Hi all,
| > >
| > > I'm playing with Lutz Roeders Reflector and have found several areas
| > > where I think there are issues in the framework libraries. I can't see
| > > how the following should work as expected and the compiler gives me an
| > > error on the 'text1 = text1...' line. Is it really this buggy (this
| > > particular bug is in several places) or am I missing something? You
can
| > > see that that code has a possibility of crashing if the property has a
| > > . in it. I think the line should read 'text1 = property.Name....'.
| > >
| > > The code is from the ProfileBuilder class in the
System.Web.Compilation
| > > class.
| > >
| > > private void CreateCodeForProperty(AssemblyBuilder assemblyBuilder,
| > > CodeTypeDeclaration type, ProfileNameTypeStruct property)
| > > {
| > > string text1;
| > > int num1 = property.Name.IndexOf('.');
| > > if (num1 > 0)
| > > {
| > > text1 = text1.Substring(num1 + 1);
| > > }
| > ...
| > <snip>
| > ...
| > > Your thoughts would be welcome.
| >
| > When I look at that method with Reflector the first line is:
| > string text1 = property.Name;
| > which means that all is well. If it's any help I'm using Reflector
| > v4.2.27.0.
| >
| > Chris Jobson
|
| V4.2.43.0 seems to have bugs then, thanks for checking it out.
|
| Ryan
|
Jun 12 '06 #6

Larry Lard wrote:
Ryan wrote:
Hi all,

I'm playing with Lutz Roeders Reflector and have found several areas
where I think there are issues in the framework libraries. I can't see
how the following should work as expected and the compiler gives me an
error on the 'text1 = text1...' line.


What's the error?
Is it really this buggy (this
particular bug is in several places) or am I missing something? You can
see that that code has a possibility of crashing if the property has a
. in it.


OK. Can you show us the code that would make this crash?

--
Larry Lard
Replies to group please


Well, I think the issue is with the later versions of reflector. The IL
may be correct but it is not easy to read so I am going on VB/C#
output. As Chris Jobson pointed out, it looks like my particular
version of reflector (or a conflict with the add ins).

I did not assume that the .Net classes were buggy, I was just asking as
I was not certain what was going on.

It looks like inline initialisation is not being output correctly. The
following;
private void CreateCodeForProperty(AssemblyBuilder assemblyBuilder,
CodeTypeDeclaration type, ProfileNameTypeStruct property)
{
string text1;
int num1 = property.Name.IndexOf('.');
if (num1 > 0)
{
text1 = text1.Substring(num1 + 1);

Should read (according to Chris);
private void CreateCodeForProperty(AssemblyBuilder assemblyBuilder,
CodeTypeDeclaration type, ProfileNameTypeStruct property)
{
string text1 = property.Name;
int num1 = property.Name.IndexOf('.');
if (num1 > 0)
{
text1 = text1.Substring(num1 + 1);

So you get text1 manipulation of an empty string and the compiler
complains.

Ryan

Jun 12 '06 #7
Sorry, I misread Chris post, he is right the first line should look like ...

string text1 = property.Name;

this is not the only bug in reflector (all versions), I for one never trust
the output generated by reflector.

Willy.

"Willy Denoyette [MVP]" <wi*************@telenet.be> wrote in message
news:O0**************@TK2MSFTNGP02.phx.gbl...
| You are too quick to consider things to be buggy.
| Reflector is right, if you are not sure check the IL..
|
| IL_0015: ldloc.1
| IL_0016: ldc.i4.1
| IL_0017: add
| IL_0018: callvirt instance string
[mscorlib]System.String::Substring(int32)
|
| which turns into...
|
| text1 = text1.Substring(num1 + 1);
| in C#
|
| Willy.
|
|
| "Ryan" <ry***@lightsdown.com> wrote in message
| news:11**********************@j55g2000cwa.googlegr oups.com...
||
|| Chris Jobson wrote:
|| > "Ryan" <ry***@lightsdown.com> wrote in message
|| > news:11**********************@j55g2000cwa.googlegr oups.com...
|| > > Hi all,
|| > >
|| > > I'm playing with Lutz Roeders Reflector and have found several areas
|| > > where I think there are issues in the framework libraries. I can't
see
|| > > how the following should work as expected and the compiler gives me
an
|| > > error on the 'text1 = text1...' line. Is it really this buggy (this
|| > > particular bug is in several places) or am I missing something? You
| can
|| > > see that that code has a possibility of crashing if the property has
a
|| > > . in it. I think the line should read 'text1 = property.Name....'.
|| > >
|| > > The code is from the ProfileBuilder class in the
| System.Web.Compilation
|| > > class.
|| > >
|| > > private void CreateCodeForProperty(AssemblyBuilder assemblyBuilder,
|| > > CodeTypeDeclaration type, ProfileNameTypeStruct property)
|| > > {
|| > > string text1;
|| > > int num1 = property.Name.IndexOf('.');
|| > > if (num1 > 0)
|| > > {
|| > > text1 = text1.Substring(num1 + 1);
|| > > }
|| > ...
|| > <snip>
|| > ...
|| > > Your thoughts would be welcome.
|| >
|| > When I look at that method with Reflector the first line is:
|| > string text1 = property.Name;
|| > which means that all is well. If it's any help I'm using Reflector
|| > v4.2.27.0.
|| >
|| > Chris Jobson
||
|| V4.2.43.0 seems to have bugs then, thanks for checking it out.
||
|| Ryan
||
|
|
Jun 12 '06 #8
On 12 Jun 2006 06:51:36 -0700, "Ryan" <ry***@lightsdown.com> wrote:

I did not assume that the .Net classes were buggy, I was just asking as
I was not certain what was going on.

Ryan


Ryan,

I think you should look again at the title that you gave this thread:
".NET 2.0 classes very buggy?"

Sorry, but it is a pet peeve of mine to check these technical
newsgroups and see dozens of posts implying that there is a bug with
such-and-such class or method in the framework.

For me personally, if I hit a problem with the framework, the order
that I follow in diagnosing it is:

1. Have I made a simple typo?
2. Do I have a misunderstanding with how the method/class is supposed
to function?
3. Re-read the MSDN Library docs.
4. Is this a common misunderstanding? (search the newsgroups)
5. Check books on my bookshelf.
6. Look at the internals of the framework with Reflector to get a
better understanding of what is going on under the covers.

etc.

Claiming to have found a bug in the .NET Framework would probably be
the last step in my search, yet for so, so many people, it seems to be
step #1.

Rant-mode off.

Chuck

Jun 21 '06 #9

Chuck Heatherly wrote:
On 12 Jun 2006 06:51:36 -0700, "Ryan" <ry***@lightsdown.com> wrote:

I did not assume that the .Net classes were buggy, I was just asking as
I was not certain what was going on.

Ryan


Ryan,

I think you should look again at the title that you gave this thread:
".NET 2.0 classes very buggy?"

Sorry, but it is a pet peeve of mine to check these technical
newsgroups and see dozens of posts implying that there is a bug with
such-and-such class or method in the framework.

For me personally, if I hit a problem with the framework, the order
that I follow in diagnosing it is:

1. Have I made a simple typo?
2. Do I have a misunderstanding with how the method/class is supposed
to function?
3. Re-read the MSDN Library docs.
4. Is this a common misunderstanding? (search the newsgroups)
5. Check books on my bookshelf.
6. Look at the internals of the framework with Reflector to get a
better understanding of what is going on under the covers.

etc.

Claiming to have found a bug in the .NET Framework would probably be
the last step in my search, yet for so, so many people, it seems to be
step #1.

Rant-mode off.

Chuck


Hey, I understand, that'll be why I put a question mark there at the
end of the title. I was after some input from more knowledgable people
because I did not take at face value what I was seeing.

Jun 21 '06 #10

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

1
by: Michal Vitecek | last post by:
hello, does the type() command work correctly for new style classes? i guess it does not, unfortunately. for example, for a new style class' instance it returns <class '__main__.ClassName'>, but...
10
by: Frances Del Rio | last post by:
I've been wondering for a while whether you can do this... let's say I define a class thus: ..myClass {font-family:verdana,sans-serif; font-size:11px; color:#006699; text-decoration:underline}...
17
by: rkusenet | last post by:
This sure looks like a troll, but IBM folks should go there and defend DB2 ...
11
by: Zoury | last post by:
Hi there! :O) I've noticed some strange behavior with the VS IDE. Here's two a can think of right now... but those are most fusstrating i've encountered. 1. Every now and then, I haven't...
11
by: unwantedspam | last post by:
I am getting an "Object Expected" error on line 0. Do you see anything wrong with the following code: var iTest = 60 function test(msg) { var NewMessage = msg;
173
by: Zytan | last post by:
I've read the docs on this, but one thing was left unclear. It seems as though a Module does not have to be fully qualified. Is this the case? I have source that apparently shows this. Are...
5
by: lobequadrat | last post by:
Hello, I am trying to get the following code work (unfortunately not mine ... :( ) template <class Tclass Test { public: class ELEM;
3
by: juro | last post by:
Hi, I have a small problem: I'd like to call static variables from different classes - their names are stored in an array. Example of a class: class MyClass1{ public static $mysql_table =...
10
by: Phat G5 (G3) | last post by:
I was toying around with adding a new method to the Array class. It works fine in FF but not in Safari. I have no idea in IE. I have not gotten that far yet. Array.prototype.find =...
1
by: CloudSolutions | last post by:
Introduction: For many beginners and individual users, requiring a credit card and email registration may pose a barrier when starting to use cloud servers. However, some cloud server providers now...
0
by: Faith0G | last post by:
I am starting a new it consulting business and it's been a while since I setup a new website. Is wordpress still the best web based software for hosting a 5 page website? The webpages will be...
0
isladogs
by: isladogs | last post by:
The next Access Europe User Group meeting will be on Wednesday 3 Apr 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM). In this session, we are pleased to welcome former...
0
by: taylorcarr | last post by:
A Canon printer is a smart device known for being advanced, efficient, and reliable. It is designed for home, office, and hybrid workspace use and can also be used for a variety of purposes. However,...
0
by: Charles Arthur | last post by:
How do i turn on java script on a villaon, callus and itel keypad mobile phone
0
by: aa123db | last post by:
Variable and constants Use var or let for variables and const fror constants. Var foo ='bar'; Let foo ='bar';const baz ='bar'; Functions function $name$ ($parameters$) { } ...
0
by: ryjfgjl | last post by:
If we have dozens or hundreds of excel to import into the database, if we use the excel import function provided by database editors such as navicat, it will be extremely tedious and time-consuming...
0
BarryA
by: BarryA | last post by:
What are the essential steps and strategies outlined in the Data Structures and Algorithms (DSA) roadmap for aspiring data scientists? How can individuals effectively utilize this roadmap to progress...
1
by: Sonnysonu | last post by:
This is the data of csv file 1 2 3 1 2 3 1 2 3 1 2 3 2 3 2 3 3 the lengths should be different i have to store the data by column-wise with in the specific length. suppose the i have to...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.