Raising a base class event

[Simon]

Hi folks,

I have an object library where there are base classes that have a
declared event. I have hit the problem where the derived class cannot
raise the event. After some thought I had the idea of declaring a
protected method in the base class to raise the event, so that the
derived class can just call this method when it needs to raise this event.

Is this good form, or is there a better way.

eg

public class myBaseClass {

public delegate void ChangedDelegate();
public event ChangedDelegate OnChanged;

protected void RaiseChangedEvent() {
if (OnChanged != null)
OnChanged();
}
}

public class myDerivedClass : myBaseClass {

private string _someValue;

public string SomeValue {
get { return _someValue; }
set {
if (_someValue != value)
RaiseChangedEvent();
_someValue = value;
}
}

[Daniel O'Connell [C# MVP]]

"Simon" <si****************@nodomain.com> wrote in message
news:O1**************@tk2msftngp13.phx.gbl...

Hi folks,

I have an object library where there are base classes that have a declared
event. I have hit the problem where the derived class cannot raise the
event. After some thought I had the idea of declaring a protected method
in the base class to raise the event, so that the derived class can just
call this method when it needs to raise this event.

Is this good form, or is there a better way.

That is about the only way available. Its just fine

[Anders Norås]

Your code is good, but there is one little detail that should be changed.
In the section:

set {
if (_someValue != value)
RaiseChangedEvent();
_someValue = value;
}
}

....you're rasing the changed event before the value is changed. The _someValue
member should be set first, and then ypu should call the RaiseChangedEvent
method. After all, the value hasn't changed until you assign a new value
to it.

Anders Norås
http://dotnetjunkies.com/weblog/anoras/

[Simon]

Thanks for the feedback folks.

I take your point Anders. Thanks for that.

Simon

Anders Norås wrote:

Your code is good, but there is one little detail that should be
changed. In the section:

set {
if (_someValue != value)
RaiseChangedEvent();
_someValue = value;
}
}

...you're rasing the changed event before the value is changed. The
_someValue member should be set first, and then ypu should call the
RaiseChangedEvent method. After all, the value hasn't changed until you
assign a new value to it.

Anders Norås
http://dotnetjunkies.com/weblog/anoras/