473,324 Members | 2,268 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,324 software developers and data experts.

OOP question

Hi,

I have an LDAPUser Class.

It has 4 properties and One method as below.
public static LDAP FindLDAPUser(string emailaddress)
{
find user
if(user is found)
{
NewUser = new LDAP(sUID,sFirstName,sLastName,sEmailAddress);
return NewUser;
}
else
{
NewUser = new LDAP(empty values)
}
I am using the static method to contain my actual New contruct of the class.

In my code behind page of a webform(user enters an email address into a
textbox and presses enter).
I have the following code (drastically shortened):

private void cmdSearch_Click(object sender, System.EventArgs e)
{
LDAP NewUser;

NewUser = LDAP.FindLDAPUser(this.txtboxEmail.Text);

this.txtboxEmail.Text = NewUser.Email.ToString();
this.txtboxFName.Text = NewUser.FirstName.ToString();
this.txtboxLName.Text = NewUser.LastName.ToString();
this.txtboxUsername.Text = NewUser.EmployeeId.ToString();
}

Because my FindLDAPUser is a static method and actually creates the class
inside itself, is this bad OOD?

It works fine and everything, however because in the click event I do not
instantiate my class with new as below, my intellisence cannot pick up the
NewUser properties if I try to access these properties outside my if
statement. Please remember I left out a bunch of code.

LDAP NewUser = New LDAP(empty values);

I just don't like the idea of purposefully putting in bogus properties
values so that I can gain better access to my properties and methods. I would
then replace the empty values for the object with real values after I run the
FindLDAP user.
Should I just return a serialized peace of data from the FindLDAPUser method
and deserialize it into the new construct method?

I'd prefer not to instantiate an object at all if I can't find a user in the
first place after searching LDAP.

please advise.

thanks

chris



Nov 17 '05 #1
2 1099

"Chris" <Ch***@discussions.microsoft.com> wrote in message
news:27**********************************@microsof t.com...
...
private void cmdSearch_Click(object sender, System.EventArgs e)
{
LDAP NewUser;

NewUser = LDAP.FindLDAPUser(this.txtboxEmail.Text);

this.txtboxEmail.Text = NewUser.Email.ToString();
this.txtboxFName.Text = NewUser.FirstName.ToString();
this.txtboxLName.Text = NewUser.LastName.ToString();
this.txtboxUsername.Text = NewUser.EmployeeId.ToString();
}

Because my FindLDAPUser is a static method and actually creates the class
inside itself, is this bad OOD?


Putting the allocation inside the FindLDAPUser is fine. You are initializing
the NewUser variable by calling the function that returns the correct type.
I have done things like this, and never had a problem with intellisense
because of it. However, if you want the thing to not exist when there's no
user, than you are going to have to test for its existance before using its
properties. That's just the way programming works. Your FindUser can return
null if no user is found. Then the statement that does the assignments
should go inside a block like
if ( NewUser != null ){}

If you want your object to automatically have empty values to assign when
there's no user so the rest of your code doesn't have to test for the user's
existance, then you have to instantiate it with empty values. The choice is
yours.

-Rachel
Nov 17 '05 #2

"Chris" <Ch***@discussions.microsoft.com> wrote in message
news:27**********************************@microsof t.com...
Hi,

I have an LDAPUser Class.

It has 4 properties and One method as below.
public static LDAP FindLDAPUser(string emailaddress)
{
find user
if(user is found)
{
NewUser = new LDAP(sUID,sFirstName,sLastName,sEmailAddress);
return NewUser;
}
else
{
NewUser = new LDAP(empty values)
}
I am using the static method to contain my actual New contruct of the
class.

In my code behind page of a webform(user enters an email address into a
textbox and presses enter).
I have the following code (drastically shortened):

private void cmdSearch_Click(object sender, System.EventArgs e)
{
LDAP NewUser;

NewUser = LDAP.FindLDAPUser(this.txtboxEmail.Text);

this.txtboxEmail.Text = NewUser.Email.ToString();
this.txtboxFName.Text = NewUser.FirstName.ToString();
this.txtboxLName.Text = NewUser.LastName.ToString();
this.txtboxUsername.Text = NewUser.EmployeeId.ToString();
}

Because my FindLDAPUser is a static method and actually creates the class
inside itself, is this bad OOD?
- No. This is a implemented simple Factory-pattern. What you do above is
great OO. Having a static method build an instance is neat.
I just don't like the idea of purposefully putting in bogus properties
values so that I can gain better access to my properties and methods. I
would
then replace the empty values for the object with real values after I run
the
FindLDAP user.
Indeed. Hence the invention of null =)
please advise.


oki

Happy Coding
- Michael S
Nov 17 '05 #3

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

3
by: Stevey | last post by:
I have the following XML file... <?xml version="1.0"?> <animals> <animal> <name>Tiger</name> <questions> <question index="0">true</question> <question index="1">true</question> </questions>
3
by: Ekqvist Marko | last post by:
Hi, I have one Access database table including questions and answers. Now I need to give answer id automatically to questionID column. But I don't know how it is best (fastest) to do? table...
53
by: Jeff | last post by:
In the function below, can size ever be 0 (zero)? char *clc_strdup(const char * CLC_RESTRICT s) { size_t size; char *p; clc_assert_not_null(clc_strdup, s); size = strlen(s) + 1;
56
by: spibou | last post by:
In the statement "a *= expression" is expression assumed to be parenthesized ? For example if I write "a *= b+c" is this the same as "a = a * (b+c)" or "a = a * b+c" ?
2
by: Allan Ebdrup | last post by:
Hi, I'm trying to render a Matrix question in my ASP.Net 2.0 page, A matrix question is a question where you have several options that can all be rated according to several possible ratings (from...
0
by: DolphinDB | last post by:
Tired of spending countless mintues downsampling your data? Look no further! In this article, you’ll learn how to efficiently downsample 6.48 billion high-frequency records to 61 million...
0
by: ryjfgjl | last post by:
ExcelToDatabase: batch import excel into database automatically...
0
by: Vimpel783 | last post by:
Hello! Guys, I found this code on the Internet, but I need to modify it a little. It works well, the problem is this: Data is sent from only one cell, in this case B5, but it is necessary that data...
0
by: ArrayDB | last post by:
The error message I've encountered is; ERROR:root:Error generating model response: exception: access violation writing 0x0000000000005140, which seems to be indicative of an access violation...
1
by: CloudSolutions | last post by:
Introduction: For many beginners and individual users, requiring a credit card and email registration may pose a barrier when starting to use cloud servers. However, some cloud server providers now...
1
by: Shællîpôpï 09 | last post by:
If u are using a keypad phone, how do u turn on JavaScript, to access features like WhatsApp, Facebook, Instagram....
0
by: af34tf | last post by:
Hi Guys, I have a domain whose name is BytesLimited.com, and I want to sell it. Does anyone know about platforms that allow me to list my domain in auction for free. Thank you
0
by: Faith0G | last post by:
I am starting a new it consulting business and it's been a while since I setup a new website. Is wordpress still the best web based software for hosting a 5 page website? The webpages will be...
0
isladogs
by: isladogs | last post by:
The next Access Europe User Group meeting will be on Wednesday 3 Apr 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM). In this session, we are pleased to welcome former...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.